Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Dec 2022 06:57:39 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Wenchao Hao <haowenchao@huawei.com>
Cc:     Masami Hiramatsu <mhiramat@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
        <liuzhiqiang26@huawei.com>, <linfeilong@huawei.com>
Subject: Re: [PATCH] cma:tracing: Print alloc result in
 trace_cma_alloc_finish
Message-ID: <20221216065739.30511197@gandalf.local.home>
In-Reply-To: <4e9f9b32-7835-e4c5-55cb-9db82c98f9c1@huawei.com>
References: <20221208142130.1501195-1-haowenchao@huawei.com>
        <4e9f9b32-7835-e4c5-55cb-9db82c98f9c1@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Fri, 16 Dec 2022 19:47:59 +0800
Wenchao Hao <haowenchao@huawei.com> wrote:

> On 2022/12/8 22:21, Wenchao Hao wrote:
> > The result of allocation is not printed in trace_cma_alloc_finish
> > now, while it's important to do it so we can set filters to catch
> > specific error on allocation or trigger some operations on specific
> > error.
> > 
> > Although we have printed the result in log, but the log is
> > conditional and could not be filtered by tracing event.
> > 
> > What's more, it introduce little overhead to print this result.
> > The result of allocation is named as errorno in trace.
> > 
> > Signed-off-by: Wenchao Hao <haowenchao@huawei.com>
> > ---

> 
> pinging


From a tracing point of view, I see nothing wrong with it.

Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>

But I believe Andrew needs to take it.

-- Steve