Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Dec 2022 12:53:42 +0000
From:   "Russell King (Oracle)" <linux@armlinux.org.uk>
To:     Stefan Wiehler <stefan.wiehler@nokia.com>
Cc:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESENDv2] arm: topology: Consider clock-frequency
 property from parent /cpus node
Message-ID: <Y5xqVmO9ZHWYW3Du@shell.armlinux.org.uk>
References: <20221216124157.13270-1-stefan.wiehler@nokia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221216124157.13270-1-stefan.wiehler@nokia.com>
Sender: Russell King (Oracle) <linux@armlinux.org.uk>
Precedence: bulk

Hi,

On Fri, Dec 16, 2022 at 01:41:58PM +0100, Stefan Wiehler wrote:
> +	cn = of_get_cpu_node(cpu, NULL);
> +	if (!cn)
> +		pr_err("missing device node for CPU %d\n", cpu);
> +	cn = of_get_parent(cn);

Doesn't this need to do an of_node_put()?

> +	if (!cn)
> +		pr_err("missing parent node for CPU %d\n", cpu);
> +	common_rate = of_get_property(cn, "clock-frequency", &common_rate_len);

And here too?

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!