Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e3c73d1c20e12ab351a74ef1abc949810fc1ba77.camel@collabora.com>
Subject: Re: [PATCHv7 7/7] arm64: dts: rockchip: Add rock-5b board
From:   Nicolas Dufresne <nicolas.dufresne@collabora.com>
To:     Sebastian Reichel <sebastian.reichel@collabora.com>,
        Heiko Stuebner <heiko@sntech.de>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Marc Zyngier <maz@kernel.org>, Jagan Teki <jagan@edgeble.ai>,
        Linus Walleij <linus.walleij@linaro.org>,
        Christopher Obbard <chris.obbard@collabora.com>,
        Benjamin Gaignard <benjamin.gaignard@collabora.com>,
        linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel@collabora.com,
        Michael Riesch <michael.riesch@wolfvision.net>
Date:   Fri, 16 Dec 2022 10:47:44 -0500
In-Reply-To: <20221215183002.211081-8-sebastian.reichel@collabora.com>
References: <20221215183002.211081-1-sebastian.reichel@collabora.com>
         <20221215183002.211081-8-sebastian.reichel@collabora.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.2 (3.46.2-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

Hi Sebastian and Christopher,

Le jeudi 15 d=C3=A9cembre 2022 =C3=A0 19:30 +0100, Sebastian Reichel a =C3=
=A9crit=C2=A0:
> From: Christopher Obbard <chris.obbard@collabora.com>
>=20
> Add board file for the RK3588 Rock 5B board. This is a basic
> implementation which just brings up the eMMC and UART which is
> enough to successfully boot Linux.
>=20
> The ethernet controller is connected via PCIe so support will
> come in a follow-up patch.
>=20
> Signed-off-by: Christopher Obbard <chris.obbard@collabora.com>
> Reviewed-by: Michael Riesch <michael.riesch@wolfvision.net>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
>  arch/arm64/boot/dts/rockchip/Makefile         |  1 +
>  .../boot/dts/rockchip/rk3588-rock-5b.dts      | 44 +++++++++++++++++++
>  2 files changed, 45 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
>=20
> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/=
rockchip/Makefile
> index 87a853435142..c5bdd0176ce0 100644
> --- a/arch/arm64/boot/dts/rockchip/Makefile
> +++ b/arch/arm64/boot/dts/rockchip/Makefile
> @@ -83,4 +83,5 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3568-evb1-v10.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3568-odroid-m1.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3568-rock-3a.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3588-evb1-v10.dtb
> +dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3588-rock-5b.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3588s-rock-5a.dtb
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64=
/boot/dts/rockchip/rk3588-rock-5b.dts
> new file mode 100644
> index 000000000000..baf46bd30b38
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> @@ -0,0 +1,44 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +
> +/dts-v1/;
> +
> +#include "rk3588.dtsi"
> +
> +/ {
> +	model =3D "Radxa Rock 5B Board";
> +	compatible =3D "radxa,rock-5b", "rockchip,rk3588";
> +
> +	aliases {
> +		mmc1 =3D &sdhci;

I have no useful knowledge, but it seems the mmc alias don't match the vend=
or.
When I run your branch on Rock5B, the EMMC endup on /dev/mmcblk1 (aka mmc1 =
alias
I think) while when I boot the vendor kernel, it is always mmcblk0 (aka mmc=
0
alias?). Perhaps the vendor didn't add aliases ?

There could also be mainline rules to number based on the boot order. In th=
is
case, the difference would be acceptable, since SPL boot order is (usb?) > =
SD
Card > EMMC > SPI NOR. Though, the SPL is picked from the opposite order (s=
pi,
emmc, sd card). Anyway, I'm just trying to express that I noticed a differe=
nce,
and its not guarantied to be a bug.

> +		serial2 =3D &uart2;
> +	};
> +
> +	chosen {
> +		stdout-path =3D "serial2:1500000n8";
> +	};
> +
> +	vcc5v0_sys: vcc5v0-sys-regulator {
> +		compatible =3D "regulator-fixed";
> +		regulator-name =3D "vcc5v0_sys";
> +		regulator-always-on;
> +		regulator-boot-on;
> +		regulator-min-microvolt =3D <5000000>;
> +		regulator-max-microvolt =3D <5000000>;
> +	};
> +};
> +
> +&sdhci {
> +	bus-width =3D <8>;
> +	no-sdio;
> +	no-sd;
> +	non-removable;
> +	max-frequency =3D <200000000>;
> +	mmc-hs400-1_8v;
> +	mmc-hs400-enhanced-strobe;
> +	status =3D "okay";
> +};
> +
> +&uart2 {
> +	pinctrl-0 =3D <&uart2m0_xfer>;
> +	status =3D "okay";
> +};
> --=20
> 2.39.0
>=20
>=20