Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8e8bfa5e-f713-4590-95db-66ed6454881b@seco.com>
Date:   Fri, 16 Dec 2022 11:37:33 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [irqchip: irq/irqchip-next] irqchip/ls-extirq: Fix endianness
 detection
Content-Language: en-US
To:     linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc:     Marc Zyngier <maz@kernel.org>, tglx@linutronix.de
References: <20221201212807.616191-1-sean.anderson@seco.com>
 <167023926482.4906.17012979311813913704.tip-bot2@tip-bot2>
From:   Sean Anderson <sean.anderson@seco.com>
In-Reply-To: <167023926482.4906.17012979311813913704.tip-bot2@tip-bot2>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UzhoVEZBNVJ3bDBNeDNUQXJ2TXBnTzZ6MFZMVHg4MGRsRkNicVV0UTZSazhE?=
 =?utf-8?B?dHNwY2xqN3RQZnhEeTY3MG9DV0RlcFRFZFhkc2ZqTkhoM0x2U0Y1cC81UE5G?=
 =?utf-8?B?ZC9KZGFDVmtqNkxzd2ZuSFFoWGdiWEZXVU0xcHd2cXE5ei9WblhTK3pMa0g4?=
 =?utf-8?B?T2ExNmY5MGJJa3d6aWFlNUgrMGVIL0tUL2JTMWVFd2NUTk9kYVBtTjYxL253?=
 =?utf-8?B?RnRPSkJ5T1d2YjFRbmdMTExZOTYzZS9iNENpZDE5UDlvUlM5d0lwK3QyTENK?=
 =?utf-8?B?cjN5MnB5bTlyN3dnSzgyME9ZQy9lOUw0bklncEp5UFlKNXZtZkJSWWJJMXFy?=
 =?utf-8?B?OE15YncwSUpabHYvaEYwT24xMnlyOHVjTGhac0pLeWtnYWJwSi9EcHFtNzBp?=
 =?utf-8?B?K05Nend1ZzVwOU9MYmEzNW4vZEowTTdqVHdUZW9vc2JnUDdJQlhRSGwvWllL?=
 =?utf-8?B?cjhKUmVabW11R2ZQS0pLQXIyaDlXbExucEEwMEJjQzFHazU0Q3JFeFNiNEVt?=
 =?utf-8?B?WVBCNmFyQ2x6cklUb0x2ZkhQWFVJUE9SWWxyL0dkalVLWlFGK3RTbzFTakJC?=
 =?utf-8?B?ajJtS042Y0ZZQk5xdjVjM3Nyc1lveHhTV1l0SCtIWDBRU2ZXNFU4aWg3K2g1?=
 =?utf-8?B?Y0JDZmpJb1o3RzdNdTQydHAvNXh5NTBvQ0FBekNlVlhwZ2wwZFUwZWdwL3d3?=
 =?utf-8?B?N2VycnJlNjZNR0s4aGtiKy90eXFzaHlwK3RiMHVmMEl5YXU3K3g5UzA5VHNX?=
 =?utf-8?B?dEZ2NmQyeDNVZ0dyYjMrUGtsajVORCtFRktiSDBLQ01WQ0pjaGwyOWdDejU3?=
 =?utf-8?B?OVRMdHBYUUphS0VCYjNHN0gxVEM0UmJJM0UrSWluc3lEV0pGUXY4NG9DVW9h?=
 =?utf-8?B?YVJma0p2bVZpaE56NTQvQm9UNHNTaUhtZHAzQnJ3VHhIeXBYTGc3Y3N4ZkFl?=
 =?utf-8?B?UGJSY0phcjFqenVadDFERlBReEpkaVFIT3VsZFBxbEkzSThHSVU0cHArUDBJ?=
 =?utf-8?B?WVkwL1RHdVo0cngxVVRiaTZPWjlLQXdMOFlVRXc4VDNUTTJOOWRNTmhwcXVG?=
 =?utf-8?B?SFVHd1RtSDE2eEZUN0NaZnpyYUZaeTlUcGhFdGpEc1BGZ3FBd0kxakxHaW1L?=
 =?utf-8?B?cDRaNFpNNGxSNFlRek43ZzE2d280cE9DcU54RFFtV3pRZDZXSEVRNndSZStH?=
 =?utf-8?B?cWhFaTNsMGo1dDVyczQycTNwT3F2UEpwZkZaYzdEV2tCRENqeWhXT1o5OENE?=
 =?utf-8?B?TE1yMUJhaU9pKzEwVjdUTWZqRUs3L25wNEN6MVFoSCtkb3VFMmVpcStBRjBP?=
 =?utf-8?B?K2lqNlorTk9RL3pIYkpIRHc0TGViQlNkR3M0OEgrZldhb2s4L1FnVmpWdVE0?=
 =?utf-8?B?VkJuVnhNa3FYcGZlTlNoV01TdVc2OGJIZG5CTkNvZVRISTJtYmdCQjQ4VnRy?=
 =?utf-8?B?V1FPRDFUcFAwZDN6cFFoVXZXd3Jsci9NM2ZmcGhoQkE4N3U1S3hOYklHYzVJ?=
 =?utf-8?B?clVrb1dMa2dZaVp2U2hzV2pUTkVKOVp4cy80NVFDTXEybnBVUFp3S0JXMEwr?=
 =?utf-8?B?aDVUUVR1YVJGMkVYZlZ0Q2laVU9WUXFROWxNVG0xQTNjNWV2dFhsOTdBSEhx?=
 =?utf-8?B?eEpPQ2o2ekFBWTVqeERVVTdkczZSMDREdFdRM3laOFMvOWxHMG9iUXVBYk1B?=
 =?utf-8?B?czFWcklwT01GbGNQcDg5QVMrakpJY21wQkVqQkN2VTg1eFZ2TjBxWDY4dlNQ?=
 =?utf-8?B?T1lDMkxJcEIyVVY4NmVaVlNJcDBJWEs0dWlhZnI4RXR5SFkwdGFjMG5qWTBa?=
 =?utf-8?B?VllvS3dsczZaaFUzT2lpZFhyY21DT0RIM1ZPLzFlaDEzQmRaQjdzaERIN1RG?=
 =?utf-8?B?bng3M1hGZE85KzJBdThpUGtmS1BGdE5sd0ovbUdvei8rMlNIQnRsY0cxTytZ?=
 =?utf-8?B?RGR6cHZuMVBnRE1nMy9EY1F4c1MrbnhHMEVQSlJ2MWpVdzRBSU5KWmJ1R2hv?=
 =?utf-8?B?OWluQVNsaUJIdnZDNlFkWjluanJZS3M3bGp3MmNGQks0cnpidDRsVVMzZVBC?=
 =?utf-8?B?RW1OQVZVMVBRTXVDSHZVUGJ3YVhZLzdncVBWRTlmSFp5U0FKQ0xKYmg4c3Yz?=
 =?utf-8?B?czUwdTZ0OUtNdGVxZlRVS3ZDS2dxeEdNVGQrTXYwZ1VhQVZTN1VnTDVtUDgw?=
 =?utf-8?B?TUE9PQ==?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d6c2ced3-d1fc-471e-f020-08dadf83d74c
X-MS-Exchange-CrossTenant-AuthSource: DB9PR03MB8847.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2022 16:37:37.3918
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OlaVyUZqyfu4w/g3zBMF/4TB7hGek6Rx9Ueif+Q9zl5dvcKeilOWdKttnWLUrMNKD8UcakpXhYwK0e+LWnJnsw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB6757
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Stable maintainers,

On 12/5/22 06:21, irqchip-bot for Sean Anderson wrote:
> The following commit has been merged into the irq/irqchip-next branch of irqchip:
> 
> Commit-ID:     3ae977d0e4e3a2a2ccc912ca2d20c9430508ecdd
> Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/3ae977d0e4e3a2a2ccc912ca2d20c9430508ecdd
> Author:        Sean Anderson <sean.anderson@seco.com>
> AuthorDate:    Thu, 01 Dec 2022 16:28:07 -05:00
> Committer:     Marc Zyngier <maz@kernel.org>
> CommitterDate: Mon, 05 Dec 2022 10:39:52
> 
> irqchip/ls-extirq: Fix endianness detection
> 
> parent is the interrupt parent, not the parent of node. Use
> node->parent. This fixes endianness detection on big-endian platforms.
> 
> Fixes: 1b00adce8afd ("irqchip/ls-extirq: Fix invalid wait context by avoiding to use regmap")
> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> Link: https://lore.kernel.org/r/20221201212807.616191-1-sean.anderson@seco.com
> ---
>  drivers/irqchip/irq-ls-extirq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-ls-extirq.c b/drivers/irqchip/irq-ls-extirq.c
> index d8d48b1..139f26b 100644
> --- a/drivers/irqchip/irq-ls-extirq.c
> +++ b/drivers/irqchip/irq-ls-extirq.c
> @@ -203,7 +203,7 @@ ls_extirq_of_init(struct device_node *node, struct device_node *parent)
>         if (ret)
>                 goto err_parse_map;
> 
> -       priv->big_endian = of_device_is_big_endian(parent);
> +       priv->big_endian = of_device_is_big_endian(node->parent);
>         priv->is_ls1021a_or_ls1043a = of_device_is_compatible(node, "fsl,ls1021a-extirq") ||
>                                       of_device_is_compatible(node, "fsl,ls1043a-extirq");
>         raw_spin_lock_init(&priv->lock);

This patch has made it into linux/master, but it should also get
backported to 6.1. Just want to make sure this doesn't fall through the
cracks, since this was a really annoying bug to deal with (causes an IRQ
storm).

--Sean