Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2989719rwb; Fri, 16 Dec 2022 08:49:25 -0800 (PST) X-Google-Smtp-Source: AA0mqf7l6rpHG/4K6HOgHA+CyeQZarUMIadM26nPnx53MtcNHJYDsDydILv6OVxaqlNVipA8mX86 X-Received: by 2002:a05:6a20:3b1d:b0:af:6cc0:344d with SMTP id c29-20020a056a203b1d00b000af6cc0344dmr12341517pzh.18.1671209365152; Fri, 16 Dec 2022 08:49:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671209365; cv=none; d=google.com; s=arc-20160816; b=IeBFW2JGRSgcHCJiM2E8SF4FP5FDS+4YHcp+HX9vKyIpyddwm9njShDUSVClDUlxzQ cnAIi7aYvVCoQw38CHG6Hhi9XVinnipj5HMf5elFpDrEFehgDaLpYU3EI0lpMDla9bGZ HU+dztF21OqYb2Eg9lZd6zyMWuIDXULCanTR+6u3mORUvNtcZFnqST7By119l+PSnLeS Nf0slBQNTZyVo41ejE9xvOc+jo3RzE8vDTmx+DFnlW070RZzTJtkDBsiZ/8Dv/xQB5Gx 9/5b4rrFlQiwSrWpBcnkzOULI+1we8q4cJ/OTXXKl328ym7eOi4ECrne1DXWg0K5Ui1R t5Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=3EPggp5DfpTVo+3t1sm+GEre13nB1Zgkn7l9hWWjtHI=; b=fzxsTGa7eubLJWPbx/KGcHb/wUe4/+3wkAmHrwnE+d6ClXJIPlo+rppy0M0mMkP+z/ E3lo/TEl8qKX0LJCVkpmyDauZHEQ++R/5bJSAA0tsOFoUYdV7Xje0VHSkkfp1bzDFEIp LQONMQFCdHFxt3JYDEdWHM5FM8skjs8Mq/DvWoLRKYfGauULjljxdjiK/pH0IILhU1LS soAZeYFSztclHYA8CV6fEzCJxqry89vYssnv9FutGvO7f7v77LjY7Q4wVslGc6UgSow5 LvI883Xj9oD9G2RXbCtZxPm151E442TzPw6cikixI/NCsyxYk5LUetCDyAQrzJktt7mr SB+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KNP6sHNu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j17-20020a056a00131100b0056de69b0c7esi2745056pfu.284.2022.12.16.08.49.15; Fri, 16 Dec 2022 08:49:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KNP6sHNu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231756AbiLPQWR (ORCPT + 68 others); Fri, 16 Dec 2022 11:22:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231759AbiLPQVi (ORCPT ); Fri, 16 Dec 2022 11:21:38 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BBF03F070; Fri, 16 Dec 2022 08:21:37 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 9A1FACE1D96; Fri, 16 Dec 2022 16:21:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ABB46C433D2; Fri, 16 Dec 2022 16:21:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671207693; bh=PzuPc7E2HGZcpKuiGsxipxlDPcMLq+hLcAA6BrGvXh8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KNP6sHNuqvsfLwddUOtgW00IFIbDXFC5VOfkOxvaXCmrT34Ud8SdZORryruHKnqa/ CVZouFi3Go0zZIVhkTLo0kO8nUSEvD4ESUY5aSa8RNyOi08jsL1fnpbn51E7DKE7qs ioi5DNMNI6eTJ/RJW2QaY3LjEU5CbouE1UHVXoo3jg3/c5TBTP1/CyoilB4IxNfPYS BOpzE7lJKfrJCqgDd5LkZqBmZvjY7cy3rMCiogfntS1F8b+MdyQrTM6Md3qEq0Rm8I 6Oc7H2eLXxHHxeBaDk/7PLV41rMUjGhCgHJDfhvdCaO0zHKgh2z+v/rCgEPhH3pi9C Dl/4Tc4CiXB7A== From: Bjorn Helgaas To: Kurt Schwemmer , Logan Gunthorpe Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas Subject: [PATCH v2 1/2] PCI: switchtec: Simplify switchtec_dma_mrpc_isr() Date: Fri, 16 Dec 2022 10:21:25 -0600 Message-Id: <20221216162126.207863-2-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221216162126.207863-1-helgaas@kernel.org> References: <20221216162126.207863-1-helgaas@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bjorn Helgaas The "ret" variable in switchtec_dma_mrpc_isr() is superfluous. Remove it and just return the value. No functional change intended. Signed-off-by: Bjorn Helgaas Reviewed-by: Logan Gunthorpe --- drivers/pci/switch/switchtec.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pci/switch/switchtec.c b/drivers/pci/switch/switchtec.c index 75be4fe22509..d7ae84070e29 100644 --- a/drivers/pci/switch/switchtec.c +++ b/drivers/pci/switch/switchtec.c @@ -1480,15 +1480,13 @@ static irqreturn_t switchtec_event_isr(int irq, void *dev) static irqreturn_t switchtec_dma_mrpc_isr(int irq, void *dev) { struct switchtec_dev *stdev = dev; - irqreturn_t ret = IRQ_NONE; iowrite32(SWITCHTEC_EVENT_CLEAR | SWITCHTEC_EVENT_EN_IRQ, &stdev->mmio_part_cfg->mrpc_comp_hdr); schedule_work(&stdev->mrpc_work); - ret = IRQ_HANDLED; - return ret; + return IRQ_HANDLED; } static int switchtec_init_isr(struct switchtec_dev *stdev) -- 2.25.1