Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp3074823rwb; Fri, 16 Dec 2022 09:44:19 -0800 (PST) X-Google-Smtp-Source: AA0mqf7wYAuegU2MY/cE57qhb3V//pTukiO/3V09HU+DNM7pMtbKGP5Il/MYb7DsiAnFNG4Lv6jm X-Received: by 2002:a17:903:251:b0:189:db2b:ac1a with SMTP id j17-20020a170903025100b00189db2bac1amr38457048plh.36.1671212659081; Fri, 16 Dec 2022 09:44:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671212659; cv=none; d=google.com; s=arc-20160816; b=slddyR+kwiQicJKwpIFCfkHLbimyqPQqrdH8/3zza6V6JFb+EQ51RntE6QlYVdHyyQ u3XaxsvFZuP4dnUaUEVe3TIYi75uKxGhLJws/rjgx81opesK6KbUZbwPNyoqN/Ln61Qb kgpd7kKKt/rLmkI8eJu0an/5QCbXNx1Z7rRbf7YVAuUvR+AH1DC2g/ycKZZvRQ+gSgp4 ZSkkoT5qoetUgz4zVnAdLY3cD4D+GOTpquaOBeJPpaRkCnjg8lHwexEpjh6mYnzuaM7Q v/Ij7zb6nBEbyWafNi+Ejycto+RnAe+h79onJ2vx70ejI+wk47DQcWAMnvH41bz9m6wL oCbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=mSdHitnkISCDHxH+DqoMhtW/CPh93wXQUD36BiNJhs0=; b=M/rok2Ok4DAvqB8Qg8Miy+BA4MlDktFWzTNRAn9tbwIVTRA/C+sGmGxfvYcXohmo8F FcZbQytqBQlB2Dbt4iXbRghzx8KGTqBArkSAYtv5YWhaeQPy6zU1ZqhM8MqGGdNJxOw7 rmO/AdXO8oeoXPIt3dKLJJF82POArEyJsqoVlvVni5rKDj05qNSzGO3Fz0WFhPFMMtZN N+QretcT26xSPtV+f7mQ9zAkhk2WMYclJTCjLm6UBMOIPpRFC81w1mNpd3JMTjRqMd8U +bOI800DLcAw6ZFoP1jclLyUgmrl89m0z1MYnEXqJRIxCV5O1Y5jsmfv/F4ViNCSjFvF GskQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w24-20020a63fb58000000b00470422252c7si3504195pgj.122.2022.12.16.09.44.10; Fri, 16 Dec 2022 09:44:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231394AbiLPQx2 (ORCPT + 68 others); Fri, 16 Dec 2022 11:53:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230429AbiLPQxY (ORCPT ); Fri, 16 Dec 2022 11:53:24 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6987B22B; Fri, 16 Dec 2022 08:53:21 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A394FB81D39; Fri, 16 Dec 2022 16:53:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30686C433D2; Fri, 16 Dec 2022 16:53:17 +0000 (UTC) Date: Fri, 16 Dec 2022 11:53:14 -0500 From: Steven Rostedt To: David Laight Cc: 'Andreas Schwab' , "'Leizhen (ThunderTown)'" , Geert Uytterhoeven , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , "live-patching@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Masahiro Yamada" , Alexei Starovoitov , Jiri Olsa , Kees Cook , Andrew Morton , Luis Chamberlain , "linux-modules@vger.kernel.org" , Ingo Molnar , linux-m68k , "Jason A. Donenfeld" Subject: Re: [PATCH v9] kallsyms: Add self-test facility Message-ID: <20221216115314.6120beb7@gandalf.local.home> In-Reply-To: <819801284eb745d9a4189759bad297f5@AcuMS.aculab.com> References: <20221115083349.1662-1-thunder.leizhen@huawei.com> <49070ac3-02bb-a3b3-b929-ede07e3b2c95@huawei.com> <4aaede14-8bd3-6071-f17b-7efcb5f0de42@huawei.com> <66ec4021-b633-09ba-73ee-b24cdb3fa25a@huawei.com> <06345dca-0afb-00a5-c9e9-5ba830d8ad05@huawei.com> <52450ec1da164d6d87587063c3b3d3d2@AcuMS.aculab.com> <592dce7a0de24c62bd31c29f86ce6c1b@AcuMS.aculab.com> <87pmcjidfe.fsf@igel.home> <1ba1fadb39994a4d91edabdfd9d69fa6@AcuMS.aculab.com> <87len7ibtt.fsf@igel.home> <87fsdfib07.fsf@igel.home> <819801284eb745d9a4189759bad297f5@AcuMS.aculab.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 16 Dec 2022 16:32:08 +0000 David Laight wrote: > From: Andreas Schwab > > Sent: 16 December 2022 16:12 > > On Dez 16 2022, David Laight wrote: > > > > > The other issue is a missing "memory" clobber. > > > > strcmp is a pure read-only operation. > > Still needs the memory clobber. What memory is being modified? I don't know m68k assembly, but I'm guessing the (%O)+ and the (%1)+ only modifies the register being used, and no memory is being touched. -- Steve