Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp3139618rwb; Fri, 16 Dec 2022 10:33:50 -0800 (PST) X-Google-Smtp-Source: AA0mqf4w3QlG1Y1tpGwHIBN9XZBCzaC1Bb88etVLcYD4DAjTm7cezmy6CWvwxdC8ivlANvnuALmB X-Received: by 2002:a17:903:2687:b0:189:985c:849d with SMTP id jf7-20020a170903268700b00189985c849dmr39672307plb.1.1671215630536; Fri, 16 Dec 2022 10:33:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671215630; cv=none; d=google.com; s=arc-20160816; b=LxbCventqfAgLeSjkouVuEKtqt1k2dNQiDzxgOYb8u+kvIoE5lIUCEQuA29ZvSbiyd Xr1ryppaCXIqnQJKM+eqeZFXbFhTNMf5foe3tMMBpCw4ZbH/J6AU6sOsW/PEVuSCe0Bh KvU4OxjLPspS3lezvnM0YdHPiH8YhlcSL3oMAYPwxMMzWo9ZgeGNyf4T8c25+ckkxd2M mtWg1I/LiwskR4Wh/+PB6Z1ET8PRCiidXGsf50PXotpyf2UapIcRuSE0suhrQvc3t/M7 pL1ebOhAWl3Psq2qi+jpjqbhGbnLiuEY1fH0n7vS2kTwyXMxon5I+pOIgQ4y9ctBpf5C tbaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=/Rm+iVjAfIXMXmAIFuOfbGqfQqlF00OjdLY1JM/TOgI=; b=oQ9UcPOgegmTlZxoFyE6ZDJNdDq5ynlioDm/7h3769prs7tQ28bRqeKPxfV4U30XLk 1HdNGIxiWtwPqLNkZKBNxiDbB/fdRwOG48R6Q9MB+GrkA1bMYjy1XH84YgMz3zKwbhgY ZrdGU9fCXB5XW5GVbz3SSW0s7/Phk5OyJwEuC/iRxKXJXysCD8diQ6LpQ3Mbbh36vwa3 YDT6Ty4shkWC35K9S/sZq3xYnhMr3xjUEsZfmb5uRXi2oFGosBpP2Evd44AWWzhEIKKT Mvz5nbgq65hmt3YCMIrL76BYJpyEG1zM61kD45b3/l0IsCijbfjWfmYLM2uOmqfhGQjQ FMxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=Bln6Fejp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id iw2-20020a170903044200b001870464adb6si3004236plb.183.2022.12.16.10.33.41; Fri, 16 Dec 2022 10:33:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=Bln6Fejp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231489AbiLPSSs (ORCPT + 68 others); Fri, 16 Dec 2022 13:18:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231601AbiLPSSb (ORCPT ); Fri, 16 Dec 2022 13:18:31 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73430654D8; Fri, 16 Dec 2022 10:18:24 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 211E2B81DE4; Fri, 16 Dec 2022 18:18:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 264FDC433EF; Fri, 16 Dec 2022 18:18:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1671214701; bh=vRbKCiLdExOTUt5BW7wyrYFNrRg54Ri2oAjQj3d/9yk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Bln6FejpwP8y1LDhKqmy+1hWW84LthPXn0iMaqmr7jjsV8vUCNoa3AbTP6gTXvcnt 5k1MnZzSKSjSw8zGq4T3SDYvSuIrSIPn0I5ykHvHgLObdmF1BnKHrl2EV/YTJxvSLm jUEqZ7JjMxY2xhleRkc/9KbfpeUuDBAyINIcUquE= Date: Fri, 16 Dec 2022 10:18:20 -0800 From: Andrew Morton To: Michal Hocko Cc: Mina Almasry , Tejun Heo , Zefan Li , Johannes Weiner , Jonathan Corbet , Roman Gushchin , Shakeel Butt , Muchun Song , Huang Ying , Yang Shi , Yosry Ahmed , weixugc@google.com, fvdl@google.com, bagasdotme@gmail.com, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] Revert "mm: add nodes= arg to memory.reclaim" Message-Id: <20221216101820.3f4a370af2c93d3c2e78ed8a@linux-foundation.org> In-Reply-To: References: <20221202223533.1785418-1-almasrymina@google.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 16 Dec 2022 10:54:16 +0100 Michal Hocko wrote: > I have noticed that the patch made it into Linus tree already. Can we > please revert it because the semantic is not really clear and we should > really not create yet another user API maintenance problem. Well dang. I was waiting for the discussion to converge, blissfully unaware that the thing was sitting in mm-stable :( I guess the Acked-by: Michal Hocko Acked-by: Shakeel Butt Acked-by: Muchun Song fooled me. I think it's a bit premature to revert at this stage. Possibly we can get to the desired end state by modifying the existing code. Possibly we can get to the desired end state by reverting this and by adding something new. If we can't get to the desired end state at all then yes, I'll send Linus a revert of this patch later in this -rc cycle.