Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp3159770rwb; Fri, 16 Dec 2022 10:52:16 -0800 (PST) X-Google-Smtp-Source: AA0mqf6agMhxmP9MhtFP3Sr6V2ila77U0OohJ73Jw6per1TIUXCc2sI56T86/KsY6zs8wvp6MM9h X-Received: by 2002:a17:906:1c04:b0:7c1:1444:da2e with SMTP id k4-20020a1709061c0400b007c11444da2emr26485742ejg.63.1671216735863; Fri, 16 Dec 2022 10:52:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671216735; cv=none; d=google.com; s=arc-20160816; b=p3lw6to+asFbZ165mnPqjal2nVKSYuj0D1Y3pFPHuV0MgAaFKYWrZtmDMB+OQDn1wN AWvCYFAEESQz1YWFNSTnkwOYTdoUPZfyYx+vVR7VoP5bMkXMyr0hQo1cuMc0UA3oeuMY RJ8+0OYtHy8wrQO5RWG8mzDqUCH2DNQhpulI5MIqz2V2OVJ8cVfHDm48eO/MGgrwkccy ZuKoxm1kSEcm1JUgKtbJ7zqh4Z3Q1sDQLg1B2m/C1Tm6o3zvOa6N0fK9WK1bHUR2DCBe OCLGZNtQ3U1xxA3svvapr2PlK22oXlIefWwdfr6Pin8C2eOiKf3C67y9Wu++jW3WbFnA RrOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:message-id:user-agent :references:in-reply-to:subject:cc:to:from:date:mime-version :dkim-signature; bh=EhBzvtZHPK1sfjuHTW2xAB2l4y21Gb5i7jLvFXKuQTE=; b=HUOdELQn553SQTgUGaDN7ia5c+UetU7PXDRkRORrkcShYomIr6vE7gktTZ/2AlhVB6 AbceJlo2TIcJGpST9KqVHeTH/yzXM0S0EPrvtrWOOuGWFdUBzflRwDRjL813T0H/+2xo 4BCO9MkCxu1oYE1VcggXVkwbMG3j7706GPeEIiYWX2LfQtzZWbTKdritIQIUE37vkXVO Dfl9OnLW6yum1QjAKswdwVPhKIn09s5BmCEbhMO0k91qzjolrHhOA1NUqcQG2uXBggSe eYdWIdBaioi+B6qruKF0SVEASKZHy3zldNI2xOqMv8bRMgAAIWJnSpanHUg8tB6y+oSX RVBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=csDZAsIR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q13-20020a170906144d00b007c16e4896edsi2533442ejc.739.2022.12.16.10.51.59; Fri, 16 Dec 2022 10:52:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=csDZAsIR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231241AbiLPSWi (ORCPT + 68 others); Fri, 16 Dec 2022 13:22:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229547AbiLPSWf (ORCPT ); Fri, 16 Dec 2022 13:22:35 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 236DB37FB1; Fri, 16 Dec 2022 10:22:35 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9943E621D1; Fri, 16 Dec 2022 18:22:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 077AAC433EF; Fri, 16 Dec 2022 18:22:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671214954; bh=WcpiSQBig1AiMsghPaAPcivsTzSqVtCX6MpwJVHU5fg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=csDZAsIRjcmF9g22vcI1LgtJXuHcdgXulHvMQCBTfxICApnkufWZ/eoOb1cNkVeFF 8HXsFNG/FpFdzJiez0071VOagduyugSxkfDVM+EZ8GW4coC4dhXAX+LGjwEvh2qdxk 4MTYE+kMmcN8Oo510dWd9XZZxGRaaTxsZ6f730B+pDWA9Z10WiZZ3RWElfE1NuxWOg mO6wl3pPFJdPDnraOAGxFohFMWODi3tofbKyfexRf+qoM6WG/GZ6YeAi8IToDQSL6x XXBi64bq3Ye/w3TqzcdAMU2dJAiOf1iEQIq60yRoHtLOeB3DoJsm9iK+EkqDwLj4yv /6GTdq7Mg3w7A== Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1p6FLr-00D8Vv-NV; Fri, 16 Dec 2022 18:22:31 +0000 MIME-Version: 1.0 Date: Fri, 16 Dec 2022 18:22:31 +0000 From: Marc Zyngier To: Sean Anderson Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, tglx@linutronix.de Subject: Re: [irqchip: irq/irqchip-next] irqchip/ls-extirq: Fix endianness detection In-Reply-To: <8e8bfa5e-f713-4590-95db-66ed6454881b@seco.com> References: <20221201212807.616191-1-sean.anderson@seco.com> <167023926482.4906.17012979311813913704.tip-bot2@tip-bot2> <8e8bfa5e-f713-4590-95db-66ed6454881b@seco.com> User-Agent: Roundcube Webmail/1.4.13 Message-ID: <9a7ef68d94e7d0ca879b9f55f7634df5@kernel.org> X-Sender: maz@kernel.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: sean.anderson@seco.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, tglx@linutronix.de X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-12-16 16:37, Sean Anderson wrote: > Hi Stable maintainers, > > On 12/5/22 06:21, irqchip-bot for Sean Anderson wrote: >> The following commit has been merged into the irq/irqchip-next branch >> of irqchip: >> >> Commit-ID: 3ae977d0e4e3a2a2ccc912ca2d20c9430508ecdd >> Gitweb: >> https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/3ae977d0e4e3a2a2ccc912ca2d20c9430508ecdd >> Author: Sean Anderson >> AuthorDate: Thu, 01 Dec 2022 16:28:07 -05:00 >> Committer: Marc Zyngier >> CommitterDate: Mon, 05 Dec 2022 10:39:52 >> >> irqchip/ls-extirq: Fix endianness detection >> >> parent is the interrupt parent, not the parent of node. Use >> node->parent. This fixes endianness detection on big-endian platforms. >> >> Fixes: 1b00adce8afd ("irqchip/ls-extirq: Fix invalid wait context by >> avoiding to use regmap") >> Signed-off-by: Sean Anderson >> Signed-off-by: Marc Zyngier >> Link: >> https://lore.kernel.org/r/20221201212807.616191-1-sean.anderson@seco.com >> --- >> drivers/irqchip/irq-ls-extirq.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/irqchip/irq-ls-extirq.c >> b/drivers/irqchip/irq-ls-extirq.c >> index d8d48b1..139f26b 100644 >> --- a/drivers/irqchip/irq-ls-extirq.c >> +++ b/drivers/irqchip/irq-ls-extirq.c >> @@ -203,7 +203,7 @@ ls_extirq_of_init(struct device_node *node, struct >> device_node *parent) >> if (ret) >> goto err_parse_map; >> >> - priv->big_endian = of_device_is_big_endian(parent); >> + priv->big_endian = of_device_is_big_endian(node->parent); >> priv->is_ls1021a_or_ls1043a = of_device_is_compatible(node, >> "fsl,ls1021a-extirq") || >> of_device_is_compatible(node, >> "fsl,ls1043a-extirq"); >> raw_spin_lock_init(&priv->lock); > > This patch has made it into linux/master, but it should also get > backported to 6.1. Just want to make sure this doesn't fall through the > cracks, since this was a really annoying bug to deal with (causes an > IRQ > storm). If you wanted it backported, why didn't it have a Cc: stable the first place? In any case, if you want a backport to happen, you'll have to post that backport. Thanks, M. -- Jazz is not dead. It just smells funny...