Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp3161230rwb; Fri, 16 Dec 2022 10:53:38 -0800 (PST) X-Google-Smtp-Source: AA0mqf6HF4KIKePQadxVczjYVN0D5qIN2/F0N4BYFdtEAEeo4BrK1UMaFlx32leHMQq7CUy09oDk X-Received: by 2002:a17:906:6ad7:b0:7c1:ac8:399 with SMTP id q23-20020a1709066ad700b007c10ac80399mr13940676ejs.55.1671216818116; Fri, 16 Dec 2022 10:53:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671216818; cv=none; d=google.com; s=arc-20160816; b=CBn3I5L3Eh06QIn57Qd/EJBwKg7jKeik3UKT5uyvBTc/ELIboKkj/z/Pr0pvlRXQoO wk9zP5Kr3klUtpBvixP3IEyWk55KPG3YETnwIKC24lj0w3UGdvvQG+faZ0MrhlIKVMKT 7HxKDagwy44soJI8gmmrBIyZQ55u+MuKRS6YGyaxlQ3fv18DuMkiaRz7vZD184bL4ZV6 pBGC5fllQw+kSFziU0x8DDXGnIZr8TqyOFwK4gkJBZ3b107me3GC2gu79eF4ic/PhNO7 O9JAZMHq/koY0QPyTgWTQ6mdTzyUSPnYoLy5Ng0qcI8dAv9j45ss7ec6fz0EgLQLGqC1 hfhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=qGDsbONhSroNNnogCGytWZCxqJOGD8hy4/kdvkAx0qo=; b=QSnKWf3scTrJedfvqMMuAJ6zgWHjXmrQpNVNUrvww6sMboqssAv7jNqLp3ibqdDORL AZgFGBZGLMG+E/TnjSVrjvX9tXEeCino1hdIrPhdPtbFdtxxX6gqqw50cEHl0MrcG56s Ly07uWOdT97omIIEFZamRq+mvPifuPRCST1neygvhIq8NNzcBVrVaeYv7T3V04dbULvG sPOYp+jvNCEtJNL3yF0J/ksfaWMM8uLsZpVR8GtmHi7S7m6626WjoOiVEt1Wiwzm36JY lphCQKi/o9xTlEyzUkeysSNc8qP2/3LCe2pBAiIHY4J1C/imso9AqmiaiJuWxWvjHgVu oARQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KY0rxR6f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z20-20020a170906075400b007c14a639dd9si2524303ejb.847.2022.12.16.10.53.22; Fri, 16 Dec 2022 10:53:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KY0rxR6f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231657AbiLPSVe (ORCPT + 68 others); Fri, 16 Dec 2022 13:21:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231604AbiLPSVW (ORCPT ); Fri, 16 Dec 2022 13:21:22 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6AD683723E; Fri, 16 Dec 2022 10:21:21 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id F07F7B81DD8; Fri, 16 Dec 2022 18:21:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23513C433D2; Fri, 16 Dec 2022 18:21:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671214878; bh=YRi61dvd+vhc0Jt2d3wnuf9Egv+wh7RlYmZmkXnVfU8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KY0rxR6fWzb/AcL6/G2C8c+1D3GmHWy4GRD4fb+VhOfY6dgMYG8p2CqGw6l5tWLZZ lZMqIbSkyMAtZBDxSrW9h5ZKISBzzh0HOaFWRpl7YZA7SWL0+fDP0gWCPNbamMIkzJ /9FHLpawB/dGp0Embw7y8BWxG3W7NEjq+xpNnE1GDZe1/EjDGtUrbeCArTtU5RjkUw KiG4ecAs6tmPf5j00bBi1EE9EcZpd5GhOdThQ+q2YP5PQfZEmhcIUYZ6s9eSu+C411 CBLJX6HMRGfNNTkcNwGhv3rlb8lFyImrKwBFvvYK1TcTGE0En593S08Uzsn913pzF/ 7GsXmw9qLKEKQ== Received: by pali.im (Postfix) id AB499711; Fri, 16 Dec 2022 19:21:15 +0100 (CET) Date: Fri, 16 Dec 2022 19:21:15 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Gregory Clement Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: marvell: Fix compatible strings for Armada 3720 boards Message-ID: <20221216182115.whsahozgifg5c2k7@pali> References: <20220713125644.3117-1-pali@kernel.org> <20220930233802.wjfzk3xkphm565uz@pali> <20221009120639.hds2nhdynwdzjizr@pali> <20221101224457.vyraefpfyphvnv4p@pali> <20221128182127.jq6255cwa44lnmxv@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221128182127.jq6255cwa44lnmxv@pali> User-Agent: NeoMutt/20180716 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org PING? On Monday 28 November 2022 19:21:27 Pali Rohár wrote: > PING? > > On Tuesday 01 November 2022 23:44:57 Pali Rohár wrote: > > PING? > > > > On Sunday 09 October 2022 14:06:39 Pali Rohár wrote: > > > PING > > > > > > On Saturday 01 October 2022 01:38:02 Pali Rohár wrote: > > > > Gregory: ping > > > > > > > > On Wednesday 13 July 2022 14:56:44 Pali Rohár wrote: > > > > > All Armada 3720 boards have Armada 3720 processor which is of Armada 3700 > > > > > family and do not have Armada 3710 processor. So none of them should have > > > > > compatible string for Armada 3710 processor. > > > > > > > > > > Fix compatible string for all these boards by removing wrong processor > > > > > string "marvell,armada3710" and adding family string "marvell,armada3700" > > > > > as the last one. (Note that this is same way how are defined Armada 3710 > > > > > DTS files). > > > > > > > > > > Signed-off-by: Pali Rohár > > > > > --- > > > > > arch/arm64/boot/dts/marvell/armada-3720-db.dts | 2 +- > > > > > arch/arm64/boot/dts/marvell/armada-3720-espressobin-emmc.dts | 2 +- > > > > > arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts | 2 +- > > > > > arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts | 2 +- > > > > > arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts | 2 +- > > > > > arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 2 +- > > > > > arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts | 2 +- > > > > > arch/arm64/boot/dts/marvell/armada-372x.dtsi | 2 +- > > > > > 8 files changed, 8 insertions(+), 8 deletions(-) > > > > > > > > > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-db.dts b/arch/arm64/boot/dts/marvell/armada-3720-db.dts > > > > > index bd4e61d5448e..0cfb38492021 100644 > > > > > --- a/arch/arm64/boot/dts/marvell/armada-3720-db.dts > > > > > +++ b/arch/arm64/boot/dts/marvell/armada-3720-db.dts > > > > > @@ -18,7 +18,7 @@ > > > > > > > > > > / { > > > > > model = "Marvell Armada 3720 Development Board DB-88F3720-DDR3"; > > > > > - compatible = "marvell,armada-3720-db", "marvell,armada3720", "marvell,armada3710"; > > > > > + compatible = "marvell,armada-3720-db", "marvell,armada3720", "marvell,armada3700"; > > > > > > > > > > chosen { > > > > > stdout-path = "serial0:115200n8"; > > > > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-emmc.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-emmc.dts > > > > > index 5c4d8f379704..6715a19c1483 100644 > > > > > --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-emmc.dts > > > > > +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-emmc.dts > > > > > @@ -18,7 +18,7 @@ > > > > > / { > > > > > model = "Globalscale Marvell ESPRESSOBin Board (eMMC)"; > > > > > compatible = "globalscale,espressobin-emmc", "globalscale,espressobin", > > > > > - "marvell,armada3720", "marvell,armada3710"; > > > > > + "marvell,armada3720", "marvell,armada3700"; > > > > > }; > > > > > > > > > > &sdhci0 { > > > > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts > > > > > index 070725b81be5..447760b69850 100644 > > > > > --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts > > > > > +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts > > > > > @@ -13,7 +13,7 @@ > > > > > / { > > > > > model = "Globalscale Marvell ESPRESSOBin Ultra Board"; > > > > > compatible = "globalscale,espressobin-ultra", "marvell,armada3720", > > > > > - "marvell,armada3710"; > > > > > + "marvell,armada3700"; > > > > > > > > > > aliases { > > > > > /* ethernet1 is WAN port */ > > > > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts > > > > > index 75401eab4d42..2a8aa3901a9f 100644 > > > > > --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts > > > > > +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts > > > > > @@ -19,7 +19,7 @@ > > > > > model = "Globalscale Marvell ESPRESSOBin Board V7 (eMMC)"; > > > > > compatible = "globalscale,espressobin-v7-emmc", "globalscale,espressobin-v7", > > > > > "globalscale,espressobin", "marvell,armada3720", > > > > > - "marvell,armada3710"; > > > > > + "marvell,armada3700"; > > > > > > > > > > aliases { > > > > > /* ethernet1 is wan port */ > > > > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts > > > > > index 48a7f50fb427..b03af87611a9 100644 > > > > > --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts > > > > > +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts > > > > > @@ -18,7 +18,7 @@ > > > > > / { > > > > > model = "Globalscale Marvell ESPRESSOBin Board V7"; > > > > > compatible = "globalscale,espressobin-v7", "globalscale,espressobin", > > > > > - "marvell,armada3720", "marvell,armada3710"; > > > > > + "marvell,armada3720", "marvell,armada3700"; > > > > > > > > > > aliases { > > > > > /* ethernet1 is wan port */ > > > > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts > > > > > index 1542d836c090..c5a834b33b77 100644 > > > > > --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts > > > > > +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts > > > > > @@ -16,5 +16,5 @@ > > > > > > > > > > / { > > > > > model = "Globalscale Marvell ESPRESSOBin Board"; > > > > > - compatible = "globalscale,espressobin", "marvell,armada3720", "marvell,armada3710"; > > > > > + compatible = "globalscale,espressobin", "marvell,armada3720", "marvell,armada3700"; > > > > > }; > > > > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > > > > > index caf9c8529fca..5840ed129309 100644 > > > > > --- a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > > > > > +++ b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > > > > > @@ -14,7 +14,7 @@ > > > > > / { > > > > > model = "CZ.NIC Turris Mox Board"; > > > > > compatible = "cznic,turris-mox", "marvell,armada3720", > > > > > - "marvell,armada3710"; > > > > > + "marvell,armada3700"; > > > > > > > > > > aliases { > > > > > spi0 = &spi0; > > > > > diff --git a/arch/arm64/boot/dts/marvell/armada-372x.dtsi b/arch/arm64/boot/dts/marvell/armada-372x.dtsi > > > > > index 5ce55bdbb995..02ae1e153288 100644 > > > > > --- a/arch/arm64/boot/dts/marvell/armada-372x.dtsi > > > > > +++ b/arch/arm64/boot/dts/marvell/armada-372x.dtsi > > > > > @@ -13,7 +13,7 @@ > > > > > > > > > > / { > > > > > model = "Marvell Armada 3720 SoC"; > > > > > - compatible = "marvell,armada3720", "marvell,armada3710"; > > > > > + compatible = "marvell,armada3720", "marvell,armada3700"; > > > > > > > > > > cpus { > > > > > cpu1: cpu@1 { > > > > > -- > > > > > 2.20.1 > > > > >