Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Dec 2022 11:01:39 -0800
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Liam Howlett <liam.howlett@oracle.com>
Cc:     "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        Andrei Vagin <avagin@gmail.com>,
        "usama.anjum@collabora.com" <usama.anjum@collabora.com>,
        Mike Rapoport <rppt@kernel.org>
Subject: Re: [PATCH] maple_tree: Fix mas_spanning_rebalance() on
 insufficient data
Message-Id: <20221216110139.fe9b0cc2951014e1856d0042@linux-foundation.org>
In-Reply-To: <20221216185233.2036415-1-Liam.Howlett@oracle.com>
References: <20221216185233.2036415-1-Liam.Howlett@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 16 Dec 2022 18:53:15 +0000 Liam Howlett <liam.howlett@oracle.com> wrote:

> Mike Rapoport contacted me off-list with a regression in running criu.
> Periodic tests fail with an RCU stall during execution.  Although rare,
> it is possible to hit this with other uses so this patch should be
> backported to fix the regression.
> 
> An insufficient node was causing an out-of-bounds access on the node in
> mas_leaf_max_gap().  The cause was the faulty detection of the new node
> being a root node when overwriting many entries at the end of the tree.
> 
> Fix the detection of a new root and ensure there is sufficient data
> prior to entering the spanning rebalance loop.
> 
> Add a testcase to the maple tree test suite for this issue.

Shall do.

> Cc: Andrei Vagin <avagin@gmail.com>
> Cc: usama.anjum@collabora.com
> Reported-by: Mike Rapoport <rppt@kernel.org>
> Fixes: 54a611b60590 ("Maple Tree: add new data structure")
> Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>

I guess we want a cc:stable there?

>  lib/test_maple_tree.c | 23 +++++++++++++++++++++++

Belated review: all this code runs at __init time, so every dang
function in there really should be marked __init, data marked
__initdata, etc.  Like lib/test_bitmap.c.

I wonder if there's some trick we can do external to the .c file to
have the same effect.

Also, maple_tree_seed():set[] could be static ;).  So we don't have to
initialize it at runtime.  Better would be static const.  Nitpick.