Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Dec 2022 11:05:05 -0800
From:   Conor Dooley <conor@kernel.org>
To:     Saleem Abdulrasool <abdulras@google.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>
CC:     linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: avoid enabling vectorized code generation
User-Agent: K-9 Mail for Android
In-Reply-To: <20221216185012.2342675-1-abdulras@google.com>
References: <20221216185012.2342675-1-abdulras@google.com>
Message-ID: <D734C5A0-5FE1-4287-BF7B-A1DE97C00D55@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hey Saleem,

On 16 December 2022 10:50:12 GMT-08:00, Saleem Abdulrasool <abdulras@googl=
e=2Ecom> wrote:
>The compiler is free to generate vectorized operations for zero'ing
>memory=2E  The kernel does not use the vector unit on RISCV, similar to
>architectures such as x86 where we use `-mno-mmx` et al to prevent the
>implicit vectorization=2E  Perform a similar check for
>`-mno-implicit-float` to avoid this on RISC-V targets=2E
>
>Signed-off-by: Saleem Abdulrasool <abdulras@google=2Ecom>
>---
> arch/riscv/Makefile | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/arch/riscv/Makefile b/arch/riscv/Makefile
>index 0d13b597cb55=2E=2E68433476a96e 100644
>--- a/arch/riscv/Makefile
>+++ b/arch/riscv/Makefile
>@@ -89,6 +89,10 @@ KBUILD_AFLAGS_MODULE +=3D $(call as-option,-Wa$(comma)=
-mno-relax)
> # architectures=2E  It's faster to have GCC emit only aligned accesses=
=2E
> KBUILD_CFLAGS +=3D $(call cc-option,-mstrict-align)
>=20
>+# Ensure that we do not vectorize the kernel code when the `v` extension=
 is
>+# enabled=2E  This mirrors the `-mno-mmx` et al on x86=2E

The v extension should not be enabled at all though, right?
Excuse my naivity here, but what am I missing?
The vector support thread is here:
https://lore=2Ekernel=2Eorg/linux-riscv/20220921214439=2E1491510-1-stillso=
n@rivosinc=2Ecom/

What have I missed that causes a problem without that patchset?
And if I have missed something, this patch needs to be cc: stable?

Thanks,
Conor=2E

>+KBUILD_CFLAGS +=3D $(call cc-option,-mno-implicit-float)
>+
> ifeq ($(CONFIG_STACKPROTECTOR_PER_TASK),y)
> prepare: stack_protector_prepare
> stack_protector_prepare: prepare0