Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <87a9df72-f15a-0cf6-566c-dd7522d40c4e@intel.com>
Date:   Fri, 16 Dec 2022 11:36:15 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.6.0
Subject: Re: [PATCH v5 1/1] x86/resctrl: Fix task CLOSID/RMID update race
Content-Language: en-US
To:     Peter Newman <peternewman@google.com>
CC:     <fenghua.yu@intel.com>, <bp@alien8.de>, <derkling@google.com>,
        <eranian@google.com>, <hpa@zytor.com>, <james.morse@arm.com>,
        <jannh@google.com>, <kpsingh@google.com>,
        <linux-kernel@vger.kernel.org>, <mingo@redhat.com>,
        <tglx@linutronix.de>, <x86@kernel.org>
References: <20221214114447.1935755-1-peternewman@google.com>
 <20221214114447.1935755-2-peternewman@google.com>
 <bbc57154-b7f5-4b9a-65ba-ca8dc0fe0dfe@intel.com>
 <CALPaoCgt+epHFO=O8B0LWfps0NjJ1RvwmfGey22XyamkUbm0hg@mail.gmail.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <CALPaoCgt+epHFO=O8B0LWfps0NjJ1RvwmfGey22XyamkUbm0hg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?em93U2pnbmRsQm9sdHpoWVEyYmlMbTNYSnI4aVhIM2lKZzJPTml3N004Zitv?=
 =?utf-8?B?UUtPQXJUVHUwMFIyajVzbnVSV0I5YncxTFNDUk9kRFNEMFI1V0RDelZGc0RI?=
 =?utf-8?B?NkpBZERwZ3d2aVRhb2djanZtdnVWMnNjdEs2L3ZMQ2FqK0FOTm9xd0hVUTNp?=
 =?utf-8?B?cXVkTXJlcUlnRGoxYXNsYXVFU3dQZC9WSVp2V3JZNVQySjY0aWZWVHBHL0wz?=
 =?utf-8?B?L2xNMUJkRUhKNFZYUVh0cUgxUTdQaThHdEI1WU5SZkJCdTM0V1VqcXpLQjE1?=
 =?utf-8?B?RWM2Rzh3K1VGWnc1MHVyT00yUDRwVFhTQ1hGZm9qRnpqSkhuTVdyT1pBSjNF?=
 =?utf-8?B?Mjd6cS9WYjJRclhIOGEvUlVndWhtNStJajAyNnkreXZYQW1IZUlpd3FuRVpZ?=
 =?utf-8?B?eC9oSW5nKy9Fa2U0MmM5ZElGaWJNdjh3MnRaNXVKMWhmRVdvWC9vczRCTGNP?=
 =?utf-8?B?TmpZQ0NkQXIza1ZSaEVJM3BUcWtieXlUS2RBRHRKa1V4VnFtTEkvZUhiZHlW?=
 =?utf-8?B?MG0wMEhBYkF6VEQxQXlXekg2QVZBMXp6ajJENHd2UDhoK3pMWUZCTHZtV0x3?=
 =?utf-8?B?UEFrOW8xdkkyUDZST2NBSHdURFVlcGNvRW5hRjViUEJNUXVCdENwTWI4YXpT?=
 =?utf-8?B?ZEkwWktKeGNqYk5KeGUxbWZhRHN3ZnhDUzlFcklXUFcwOUNlNkkxNGM5aDRm?=
 =?utf-8?B?eTFOMytrYmhsZjcrdGxhMk5Zblhua3pQVndFV1UzeUthd0F1cktDbHJoeHh2?=
 =?utf-8?B?SHIyRjZ2VWYwS3pZT3FXNWROSjJUb1JabHNFQkdOM0lEVzRsT3lzTVlmeXZh?=
 =?utf-8?B?ZXNUUDVnNXRBWExpYWdxTEZmNmw2WUhPOUp2UmlDMXN0OFplUThwd0hMR1R4?=
 =?utf-8?B?OGdJQ05iemNYd1QvVWdvM3dDNFVuZytjSWRqZkhoaytrWEJuTGtGbCtHUUxx?=
 =?utf-8?B?TVJZT3cvOFB6dVJ5S05XMlNoMVozZmdRZEI0dER1NHJNczhHenNiK1ZaenJG?=
 =?utf-8?B?RlMrak5YOWt6Sm9DTGtubStnZnNKN05rdDZMQ2x0YjdLZWVwKzQ4WWY4TEIr?=
 =?utf-8?B?dlAyN2tBbU9HVGNkUGhRSzVNZy9IUHg5SVdqYU1kWStKUVArZ29DZTYvQUhH?=
 =?utf-8?B?TVZZcEhXYnF4dzhrNzdWMElpMFRtbEVxUkpVSVZEQmNZcWxGb095ajdZQzEz?=
 =?utf-8?B?S2E0QWlzbGN1eWdKTVVNSURRL3I5czN1YXZZQ0ljYTRYbExxeDM5QkxiWmZs?=
 =?utf-8?B?MGN1aVNnVUZSUkJrUFRCTkR5RkNYWkFFdGp0OVR6ZmFhRG9LZU1XVnZvUzFo?=
 =?utf-8?B?bW9ib1JpeVRZRkFoZ294Wi92VnJDVVRmTjMrbHlGRkJHa1FJbmpRRWxyK21i?=
 =?utf-8?B?eFl1TWEvTEJTMUFiaXlJdHZydytjNzVJZkwzdEhRRDl0RGlWR1M1WG5iUWdU?=
 =?utf-8?B?N1A0L0s1NS90b2ZlS2FkNFk5TVVwMG04TXljdHZVRG1RakZQblpRKzNraVg0?=
 =?utf-8?B?bXNSREptcHh2UmFBYW55MUNUdmtJZ3BZeTFqY3NpVkNxMXFEcVFHdEo4Um4v?=
 =?utf-8?B?MWRNUDFvckRwdFNQYnFFaDhiU0pkTk1oUmJQQ1NlaDJaUG9JclV1NjlBWUVX?=
 =?utf-8?B?Q0krU1k5SmVveXhOQWtjcUR6Tm1Jcy92VnRUYnFuQ2dLVkRacStuNmZlRE1q?=
 =?utf-8?B?NW4vQWN1alFrZHpyeWN6aTcyYVprSzZybnVFZ0JPdWlSeFRINmNySE9LQWIz?=
 =?utf-8?B?bi9aNXNaUXhDYU0ybGxhdzRYbUZHN0dvUytUZXpWR2pTampoWmRoSzI1LzI3?=
 =?utf-8?B?QXQwUkhPWjVINlVGcXJUQTMyMjYrTlYxQzRKQnlxTVlJdzJRdHQ3RW1PRzM3?=
 =?utf-8?B?VVRhaDZMSTJQMXhPVTU0aU5QNkhxL1ZDNFNlaXFqUUR4TjVaVTlzbHJzMXBy?=
 =?utf-8?B?YlJFUU1Nb0p0ZXFTeVZSd2pNdnNQYXhCTDRaMDhmT3lnTlV4Z0MwZ052UUp1?=
 =?utf-8?B?ZGk4eFpQNE4zN2p0SkNDN2NCYWdZaktqcnNyUzEyNUJ6aEw3cDFzSFdvMnpz?=
 =?utf-8?B?Zmgzb2YzRUsveGFpdWJ3SUY2VDR2QzFZNDNTd3g1bjRLQ044QXE1ajVZdFpm?=
 =?utf-8?B?VEVPbGI4ankwNkpVSGxJM1JLemxTYWVQUERyMC9CajR0REJmNURaM3EwL2pv?=
 =?utf-8?B?UVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9bb09376-b1b9-43cc-1c77-08dadf9ccd34
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2022 19:36:17.8701
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tpWujroM6199MvSHKgQ6s1Sy+0vA+xji7hFQ2BwHdwkuvpoLCW90SR/idoWyyLCp3KpU5rNtd2HmUld3oU31q89iu7Cjx9gDCYvsPwZiY2c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7351
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Peter,

On 12/16/2022 2:26 AM, Peter Newman wrote:
> Hi Reinette,
> 
> On Fri, Dec 16, 2022 at 12:52 AM Reinette Chatre
> <reinette.chatre@intel.com> wrote:
>>
>> For a fix a Fixes: tag is expected. It looks like the following
>> may be relevant:
>> Fixes: ae28d1aae48a ("x86/resctrl: Use an IPI instead of task_work_add() to update PQR_ASSOC MSR")
>> Fixes: 0efc89be9471 ("x86/intel_rdt: Update task closid immediately on CPU in rmdir and unmount")
> 
> Thanks for preparing these lines. I'll include them.
> 
>>
>>> Signed-off-by: Peter Newman <peternewman@google.com>
>>
>> Also, please do let the stable team know about this via:
>> Cc: stable@vger.kernel.org
> 
> I wasn't sure if this fix met the criteria for backporting to stable,
> because I found it by code inspection, so it doesn't meet the "bothers
> people" criterion.

That is fair. Encountering the issue does not have an obvious error, the
consequence is that there could be intervals during which tasks may not
get resources/measurements they are entitled to. I do think that this will
be hard to test in order to demonstrate the impact.

My understanding was that this was encountered in your environment where
actions are taken at large scale. If this remains theoretical then no need
to include the stable team. With the Fixes tags they can decide if it is
something they would like to carry.

> 
> However I can make a case that it's exploitable:
> 
> "In a memory bandwidth-metered compute host, malicious jobs could
> exploit this race to remain in a previous CLOSID or RMID in order to
> dodge a class-of-service downgrade imposed by an admin or steal
> bandwidth."
> 

I am not comfortable with such high level speculation. For this
exploit to work the malicious jobs needs to control scheduler decisions
as well as time the exploit with the admin's decision to move the target task.


Reinette