Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <941d8fa9-9c7b-8e06-e87a-b1c9ed80a639@ieee.org>
Date:   Fri, 16 Dec 2022 15:34:23 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH net-next v3] net: ipa: Remove redundant comparison with
 zero
Content-Language: en-US
To:     Kang Minchul <tegongkang@gmail.com>, Alex Elder <elder@kernel.org>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20221216211124.154459-1-tegongkang@gmail.com>
From:   Alex Elder <elder@ieee.org>
In-Reply-To: <20221216211124.154459-1-tegongkang@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/16/22 3:11 PM, Kang Minchul wrote:
> platform_get_irq_byname() returns non-zero IRQ number on success,
> and negative error number on failure.
> 
> So comparing return value with zero is unnecessary.
> 
> Signed-off-by: Kang Minchul <tegongkang@gmail.com>
> ---
>   drivers/net/ipa/gsi.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c
> index bea2da1c4c51..e05e94bd9ba0 100644
> --- a/drivers/net/ipa/gsi.c
> +++ b/drivers/net/ipa/gsi.c
> @@ -1302,7 +1302,7 @@ static int gsi_irq_init(struct gsi *gsi, struct platform_device *pdev)
>   	int ret;
>   
>   	ret = platform_get_irq_byname(pdev, "gsi");
> -	if (ret <= 0)
> +	if (ret < 0)
>   		return ret ? : -EINVAL;

In doing this, you assume platform_get_irq_byname() never
returns 0.  I accept that assumption now.  But in that case,
ret will *always* be non-zero if the branch is taken, so the
next line should simply be:

		return ret;

There are two other places in the IPA driver that follow exactly
the same pattern of getting the IRQ number and handling the
possibility that the value returned is (erroneously) 0.  If
you're making this change in one place, please do so in all
of them.

Frankly though, I think this change adds little value, and I
would be content to just leave everything as-is...

					-Alex

>   
>   	gsi->irq = ret;