Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221216211124.154459-1-tegongkang@gmail.com> <941d8fa9-9c7b-8e06-e87a-b1c9ed80a639@ieee.org>
In-Reply-To: <941d8fa9-9c7b-8e06-e87a-b1c9ed80a639@ieee.org>
From:   Kang Minchul <tegongkang@gmail.com>
Date:   Sat, 17 Dec 2022 06:39:42 +0900
Message-ID: <CA+uqrQCChwyE--PDxvrGMnfk9W1Nf0C4kS9fW0Ozmx-mQpyH8w@mail.gmail.com>
Subject: Re: [PATCH net-next v3] net: ipa: Remove redundant comparison with zero
To:     Alex Elder <elder@ieee.org>
Cc:     Alex Elder <elder@kernel.org>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

2022=EB=85=84 12=EC=9B=94 17=EC=9D=BC (=ED=86=A0) =EC=98=A4=EC=A0=84 6:34, =
Alex Elder <elder@ieee.org>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:
>
> On 12/16/22 3:11 PM, Kang Minchul wrote:
> > platform_get_irq_byname() returns non-zero IRQ number on success,
> > and negative error number on failure.
> >
> > So comparing return value with zero is unnecessary.
> >
> > Signed-off-by: Kang Minchul <tegongkang@gmail.com>
> > ---
> >   drivers/net/ipa/gsi.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c
> > index bea2da1c4c51..e05e94bd9ba0 100644
> > --- a/drivers/net/ipa/gsi.c
> > +++ b/drivers/net/ipa/gsi.c
> > @@ -1302,7 +1302,7 @@ static int gsi_irq_init(struct gsi *gsi, struct p=
latform_device *pdev)
> >       int ret;
> >
> >       ret =3D platform_get_irq_byname(pdev, "gsi");
> > -     if (ret <=3D 0)
> > +     if (ret < 0)
> >               return ret ? : -EINVAL;
>
> In doing this, you assume platform_get_irq_byname() never
> returns 0.  I accept that assumption now.  But in that case,
> ret will *always* be non-zero if the branch is taken, so the
> next line should simply be:
>
>                 return ret;
>
> There are two other places in the IPA driver that follow exactly
> the same pattern of getting the IRQ number and handling the
> possibility that the value returned is (erroneously) 0.  If
> you're making this change in one place, please do so in all
> of them.
>
> Frankly though, I think this change adds little value, and I
> would be content to just leave everything as-is...
>
>                                         -Alex
>
> >
> >       gsi->irq =3D ret;
>

Hmm, yes.
I think you're right.
I don't think this code is worth much either.
Please ignore this patch and leave everything as-is.

Thanks for your feedback though :)

Kang Minchul