Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Dec 2022 15:09:11 -0800
From:   Andrew Morton <akpm@linux-foundation.org>
To:     John Hubbard <jhubbard@nvidia.com>
Cc:     Sidhartha Kumar <sidhartha.kumar@oracle.com>,
        <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
        <songmuchun@bytedance.com>, <mike.kravetz@oracle.com>,
        <willy@infradead.org>
Subject: Re: [PATCH mm-unstable] mm: move folio_set_compound_order() to
 mm/internal.h
Message-Id: <20221216150911.a99fe2079a6ba5c880989449@linux-foundation.org>
In-Reply-To: <963ba9b4-6ddf-39bc-85cf-2feef542029d@nvidia.com>
References: <20221213212053.106058-1-sidhartha.kumar@oracle.com>
        <20221216142733.e2a716a4cd7ea55240d98391@linux-foundation.org>
        <963ba9b4-6ddf-39bc-85cf-2feef542029d@nvidia.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 16 Dec 2022 14:56:47 -0800 John Hubbard <jhubbard@nvidia.com> wrote:

> On 12/16/22 14:27, Andrew Morton wrote:
> > On Tue, 13 Dec 2022 13:20:53 -0800 Sidhartha Kumar <sidhartha.kumar@oracle.com> wrote:
> > 
> >> folio_set_compound_order() is moved to an mm-internal location so external
> >> folio users cannot misuse this function. Change the name of the function
> >> to folio_set_order() and use WARN_ON_ONCE() rather than BUG_ON. Also,
> >> handle the case if a non-large folio is passed and add clarifying comments
> >> to the function.
> >>
> > 
> > This differs from the version I previously merged:
> > 
> > --- a/mm/internal.h~mm-move-folio_set_compound_order-to-mm-internalh-update
> > +++ a/mm/internal.h
> > @@ -384,8 +384,10 @@ int split_free_page(struct page *free_pa
> >    */
> >   static inline void folio_set_order(struct folio *folio, unsigned int order)
> >   {
> > -	if (WARN_ON_ONCE(!folio_test_large(folio)))
> > +	if (!folio_test_large(folio)) {
> > +		WARN_ON_ONCE(order);
> >   		return;
> > +	}
> 
> I think that's out of date?

Yes thanks, I'm looking at patches in the wrong order.  I'll drop the
above delta.