Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Dec 2022 23:08:16 +0000
From:   Wei Liu <wei.liu@kernel.org>
To:     Wedson Almeida Filho <wedsonaf@gmail.com>
Cc:     Wei Liu <wei.liu@kernel.org>, rust-for-linux@vger.kernel.org,
        Linux Kernel List <linux-kernel@vger.kernel.org>,
        Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>, Gary Guo <gary@garyguo.net>,
        =?iso-8859-1?Q?Bj=F6rn?= Roy Baron <bjorn3_gh@protonmail.com>
Subject: Re: [PATCH] rust: kernel: drop repetition in offset_of macro
Message-ID: <Y5z6YKNojBqoN5OD@liuwe-devbox-debian-v2>
References: <20221216174927.1008629-1-wei.liu@kernel.org>
 <CANeycqo2qKUnyh6XVkBHyAcVjvN9NKJ9sb9bTzkHq7jC1C-B0w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CANeycqo2qKUnyh6XVkBHyAcVjvN9NKJ9sb9bTzkHq7jC1C-B0w@mail.gmail.com>
Precedence: bulk

On Fri, Dec 16, 2022 at 06:26:57PM +0000, Wedson Almeida Filho wrote:
> On Fri, 16 Dec 2022 at 17:49, Wei Liu <wei.liu@kernel.org> wrote:
> >
> > It doesn't make sense to allow multiple fields to be specified in
> > offset_of.
> 
> Why do you say it doesn't make sense?
> 
> Here's what I had in mind:
> ```
>     struct Y {
>         z: u32
>     }
>     struct X {
>         y: Y
>     }
>     offset_of!(X, y.z)
> ```
> 
> Which is something very plausible.

You're right. I didn't consider that use case. This patch can be
ignored.

Thanks,
Wei.