Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp3487247rwb; Fri, 16 Dec 2022 16:05:05 -0800 (PST) X-Google-Smtp-Source: AA0mqf65+Y9OJldd6RlheG55RruC2w0CDMOPpe02pYtlONSPpnKaUF1jn+f73w3CgnjwY1vdN22t X-Received: by 2002:a17:906:37cd:b0:7c0:a36d:115b with SMTP id o13-20020a17090637cd00b007c0a36d115bmr30955448ejc.14.1671235505036; Fri, 16 Dec 2022 16:05:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671235505; cv=none; d=google.com; s=arc-20160816; b=jmDPxzg9OaLL1UNoWbOEt+0VTh5eP19NWAn7SLLoNHGI6WzFi4gVS1xzioJYADbiu0 ezCV5DKLXDm3tJ/6GIOxzY2ImnaVP7igY63ZG1LXq2++tHL4AEkXa6kwoM6dF2YDi++T WapfXqIqfbNRyYbm3fLOkiFa1Jwz+yJakIp3YdzLZ1VYiXt3U9PmhxbYbMZic1r/cyVC /FXqOjC4RFkR/Imrgn/u1MiX1OIJyWkdD4tzF7cctRBymmlDeUjbiQ44z83/IK3ctBQr t8NwcLbZPgucnkdtCZ+dmpCxtyTxxLfd+8sNNlHkKAEct6GnMeeADslj72CA0RticABN aavQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date; bh=lYHFPlROGXp5akLyKxuqwFgDiVWJJyBSGoVOgq+vALM=; b=N3sklFnozFnPy9U9V5nenyvuU6lBbsgya8Gm3s5SE7aymfWUOIhi/kPBJIeXS3a01V D3oEINau25e3JETUCPdtoOEexywb3QbJb1kssDWYx5rXhOTf1XdIXFYQ7za7TZmaLrNP o/savMNEYPJqnJmNXB2IBgTBa94sA69HUmLmck5oUsYsio8nbd1KeqH7+OohfyHVI+9D wVrmUuL1fgnIatbU9Npqb7bVEzITPPw8/3qq8E4/EFfnU827cnvfRiBxHOBSQ43NBBof 1jkPtbFn+ofb1X1XzC9VmH+QnoawaMNLURh4LdUuhl2mgCHiMtcLrIIOcKQvXGpsRDe6 YNTA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id oq19-20020a170906cc9300b0078dad659776si2522172ejb.320.2022.12.16.16.04.48; Fri, 16 Dec 2022 16:05:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229968AbiLPXmS (ORCPT + 68 others); Fri, 16 Dec 2022 18:42:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229926AbiLPXmQ (ORCPT ); Fri, 16 Dec 2022 18:42:16 -0500 Received: from relay05.th.seeweb.it (relay05.th.seeweb.it [5.144.164.166]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7860E4D5DB for ; Fri, 16 Dec 2022 15:42:15 -0800 (PST) Received: from SoMainline.org (94-209-172-39.cable.dynamic.v4.ziggo.nl [94.209.172.39]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 5AB513F360; Sat, 17 Dec 2022 00:42:13 +0100 (CET) Date: Sat, 17 Dec 2022 00:42:12 +0100 From: Marijn Suijten To: phone-devel@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Johan Hovold , Andy Gross , Bjorn Andersson , Konrad Dybcio , Jonathan Cameron , Lars-Peter Clausen , Robert Marko , Linus Walleij , Nuno =?utf-8?B?U8Oh?= , linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] thermal: qcom-spmi-adc5: Suppress probe-deferral error message Message-ID: <20221216234212.5rm3uwzci2zjq67d@SoMainline.org> Mail-Followup-To: Marijn Suijten , phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Johan Hovold , Andy Gross , Bjorn Andersson , Konrad Dybcio , Jonathan Cameron , Lars-Peter Clausen , Robert Marko , Linus Walleij , Nuno =?utf-8?B?U8Oh?= , linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221216190945.902754-1-marijn.suijten@somainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221216190945.902754-1-marijn.suijten@somainline.org> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Whoops, that tile must of course have started with: iio: adc: qcom-spmi-adc5: instead of blindly copying the suffix from the thermal monitor patch (this driver is not a thermal monitor...). I'll send a v2 if there are no other objections, unless this can be fixed up when the patch is applied. On 2022-12-16 20:09:45, Marijn Suijten wrote: > Much like 807efb7102e8 ("thermal: qcom-spmi-adc-tm5: suppress > probe-deferral error message") the ADC5 driver also spams a similar > probe-deferral error on startup when a channel is not yet available: > > [ 0.343136] qcom-spmi-adc-tm5 1c40000.spmi:pmic@0:adc-tm@3500: get dt data failed: -517 > > Suppress it by using dev_err_probe instead, which also takes care of > storing the message as reason for deferring. > > Signed-off-by: Marijn Suijten > --- > drivers/iio/adc/qcom-spmi-adc5.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/adc/qcom-spmi-adc5.c b/drivers/iio/adc/qcom-spmi-adc5.c > index 821fee60a765..69cc36004b5a 100644 > --- a/drivers/iio/adc/qcom-spmi-adc5.c > +++ b/drivers/iio/adc/qcom-spmi-adc5.c > @@ -894,10 +894,8 @@ static int adc5_probe(struct platform_device *pdev) > mutex_init(&adc->lock); > > ret = adc5_get_fw_data(adc); > - if (ret) { > - dev_err(dev, "adc get dt data failed\n"); > - return ret; > - } > + if (ret) > + return dev_err_probe(dev, ret, "adc get dt data failed\n"); > > irq_eoc = platform_get_irq(pdev, 0); > if (irq_eoc < 0) { > -- > 2.39.0 > Apologies for the clumsiness. - Marijn