Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 17 Dec 2022 01:59:57 +0100
From:   Pali =?utf-8?B?Um9ow6Fy?= <pali@kernel.org>
To:     Segher Boessenkool <segher@kernel.crashing.org>
Cc:     Christophe Leroy <christophe.leroy@csgroup.eu>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Nicholas Piggin <npiggin@gmail.com>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Jan-Benedict Glaw <jbglaw@lug-owl.de>,
        Joel Stanley <joel@jms.id.au>
Subject: Re: [PATCH v2] powerpc: Pass correct CPU reference to assembler
Message-ID: <20221217005957.o22gtjcwvw2njnvi@pali>
References: <01fe73614988e2402a7526fb6b6e903bc3777bb5.1671179743.git.christophe.leroy@csgroup.eu>
 <20221216171821.GA25951@gate.crashing.org>
 <73fc1107-b540-bec3-7625-c6e6d0641bbb@csgroup.eu>
 <20221216181048.GC25951@gate.crashing.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20221216181048.GC25951@gate.crashing.org>
User-Agent: NeoMutt/20180716
Precedence: bulk

On Friday 16 December 2022 12:10:48 Segher Boessenkool wrote:
> On Fri, Dec 16, 2022 at 05:57:46PM +0000, Christophe Leroy wrote:
> > Le 16/12/2022 à 18:18, Segher Boessenkool a écrit :
> > > On Fri, Dec 16, 2022 at 09:35:50AM +0100, Christophe Leroy wrote:
> > >> Today we have CONFIG_TARGET_CPU which provides the identification of the
> > >> expected CPU, it is used for GCC. Use it as well for the assembler.
> > > 
> > > Why do you use -Wa, at all for this?  The compiler should already pass
> > > proper options always!
> > 
> > That's historical I guess. Comes from commit 14cf11af6cf6 ("powerpc: 
> > Merge enough to start building in arch/powerpc.")
> 
> Ah.  The patch moves stuff around, I thought more of it is new than it
> really is.  Sorry.
> 
> It would be good to get rid of all such things that do no good and can
> easily cause problems, of course, but that does not belong to this patch
> of course.

Just a coincident but u-boot has similar problem...
https://patchwork.ozlabs.org/project/uboot/patch/20221211141204.8153-1-pali@kernel.org/

So I agree that removal of -Wa,-mXXX is a good idea. I checked that gcc
pass correct -Wa,-mXXX flag from -mcpu=YYY flag.

> > >> +cpu-as-$(CONFIG_PPC_BOOK3S_64)	+= $(call as-option,-Wa$(comma)-many)
> > > 
> > > What is this for?  Using -many is a huge step back, it hides many
> > > problems :-(
> > 
> > The only thing I did is removed the -Wa,-mpower4 from the line, leaving 
> > the remaining part. Initialy it was:
> > 
> > cpu-as-$(CONFIG_PPC_BOOK3S_64) += $(call as-option,-Wa$(comma)-mpower4) 
> > $(call as-option,-Wa$(comma)-many)
> > 
> > It was added in 2018 by commit 960e30029863 ("powerpc/Makefile: Fix 
> > PPC_BOOK3S_64 ASFLAGS"). There is a long explanation it the commit.
> > 
> > Should we remove it ?
> 
> The commit says it is a workaround for clang problems, so it needs
> testing there.  It also needs testing everywhere else, because as I said
> it hides a lot of problems, so removing it will make a lot of sloppy
> code that has crept in since 2018 scream bloody murder :-(
> 
> 
> Segher