Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Zhang, Qiang1" <qiang1.zhang@intel.com>
To:     "paulmck@kernel.org" <paulmck@kernel.org>
CC:     "frederic@kernel.org" <frederic@kernel.org>,
        "quic_neeraju@quicinc.com" <quic_neeraju@quicinc.com>,
        "joel@joelfernandes.org" <joel@joelfernandes.org>,
        "rcu@vger.kernel.org" <rcu@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] rcu: Fix opposite might_sleep() check in
 rcu_blocking_is_gp()
Thread-Topic: [PATCH] rcu: Fix opposite might_sleep() check in
 rcu_blocking_is_gp()
Thread-Index: AQHZEDjb4JuHblX+NUKrHh1V8qzf2q5xRmGAgAAGjvA=
Date:   Sat, 17 Dec 2022 02:08:27 +0000
Message-ID: <PH0PR11MB5880526CB255AFF91F0D76A2DAE79@PH0PR11MB5880.namprd11.prod.outlook.com>
References: <20221215035755.2820163-1-qiang1.zhang@intel.com>
 <20221217010345.GF4001@paulmck-ThinkPad-P17-Gen-1>
In-Reply-To: <20221217010345.GF4001@paulmck-ThinkPad-P17-Gen-1>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HIsFeXsRSUSzSFb3VpjbQEg+j4wWpasHvfRLd20sDu0I8FCfmReDKx7UHNi1?=
 =?us-ascii?Q?eQkD5khJPvImMb5bllUR22j4jEzvn2RSDRb/xNV89x/fcT3jaHZDZvtcwVB4?=
 =?us-ascii?Q?+d8wheE/tC+purVsMGeYp43NmanXS02zUtwvbOjtjjRV2BLGbrHj4QeMNgTL?=
 =?us-ascii?Q?M/WqfvA84xxkoWz802KbG8KJqNSRgx62SOssfUpTgXEb1oXdwTIJ0y20UZ5v?=
 =?us-ascii?Q?4S5K/BVsj4Pc2CwUcKeoxjkf4GU4iH/LWOCsHXIStBTCDBGxqkIblNHsHAne?=
 =?us-ascii?Q?hb3OrNtvo2PXwwQhxAakRVAV3cS42QciZi5Tz0mjexbYbKPusED/Izt83mjJ?=
 =?us-ascii?Q?aRA15WP+uLH4gxjIuWCcVVKqTDFSuV6tas8/mje5lGHAETV6ppYSEhl98X92?=
 =?us-ascii?Q?SzXiKZukd4EOXyobhBh3ecSj+lLfyZTwVMgssY86YLeJYB1XYRt6+FuVpYV+?=
 =?us-ascii?Q?I+iacH1I5eTpSiRI+4IBLvKaqXbijG6vt9vMVrDxKwXyT4LdRccL8tKcQWiF?=
 =?us-ascii?Q?BGRC7vWo/uc1GOdFCUlDDbr1zq8bcgsEhzmGOB0mpvJLrKjue9YCly5ZE/T1?=
 =?us-ascii?Q?wI/B5JoYMAKr+aZG8eOD/lIoYhBL8goFN45mFlaQr1FR0odaxSqhSOe54TL5?=
 =?us-ascii?Q?IyFi0NaW23tJTXC39BT9TxLghHiVg4pUK96bJzpAEMDxNG6x3tibve7Lc5yD?=
 =?us-ascii?Q?hEd8piKBkAsYjfJR4GS2gOyxpFD2OFHEnvzRryAn+T13ddDRxlUbYkvqgEQu?=
 =?us-ascii?Q?X231LZiQLHLYKhqT7Z9+qlPDRBXF6mxe8WyDaVP1RjEFM5ZGV5E2BoaT9gWB?=
 =?us-ascii?Q?zWXkKXc5id0hM2PLSJjZELlhODLTvWvAz80wTZDDYpjuQTnyx3Nl5+9KIVZU?=
 =?us-ascii?Q?dmxu105rrfZhfs+MCPo7Ll1BWzh9W0Puc1d4xVI1z3jIGBf7uhkpEULlVotC?=
 =?us-ascii?Q?eHZ+vmK9pDyQvG/UemZx0mwOblA6cDI5w1V3yNJv1WC7OVJn3ekCA92kRCOr?=
 =?us-ascii?Q?Lfj6i+Snzp7GftLfDmJcTAlB0DFXiwO6g1ZC5FYkXuB9VtIu96CkaRMapd3/?=
 =?us-ascii?Q?Uz+GYvLopkgUyPpZyK9jo9aYyLKtVsx7TRlzULa5FOaJu//4E63/s5X7IYgq?=
 =?us-ascii?Q?In/gCrMhRjL9/LrfMDSnnnFBoCPEFfCHzUti7m5I4QGNcmrlIh+mSuEfo4go?=
 =?us-ascii?Q?hbIRxQ+KLbSzhLu/QJYuyBRY8PM1ZovGQuzruexSzV5i+xegn5nYXScDvBVi?=
 =?us-ascii?Q?126V2bgfbyt4SQRF4hDVrQFkiYlwisWyGo5wfqJCRC9B/gZYZjtdOfr1biwW?=
 =?us-ascii?Q?DA/w4XSPM09SJMbWA4Y+Q92uFhw6vgJjuxE1cBUBdoACVFbwEXU6s9NkRiXV?=
 =?us-ascii?Q?3hr6eHE/H41fQ5VneuXCEO5JlY5Ys9ftwKXTayg90mCdFFxHJkeM+AXhF8hr?=
 =?us-ascii?Q?58m3n7C/D9CDl0TU7Z40VMBdt/MZ5LYOMT9TxSNLPiidyON/zricteLFZiT6?=
 =?us-ascii?Q?o2IvknAL1eVLVcBgbVwpll+COBp11H3etVW4SVnizroNyGq3exw7A9SaLU5P?=
 =?us-ascii?Q?nWLvkLp1CPsMmamcF/UUj/3Mek/g7rLqoRa6u0jQ?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5880.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 468430eb-866c-4cf1-1585-08dadfd3961a
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2022 02:08:27.5106
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vEURDLKke2O904lSSLLPgowN9BxY1cyY7tya4unFcAMa+YhvecIZ5dJ/0v5/eXWE4B8tr7+sWY4NHDuB8QjzVg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6313
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Dec 15, 2022 at 11:57:55AM +0800, Zqiang wrote:
> Currently, if the system is in the RCU_SCHEDULER_INACTIVE state, invoke
> synchronize_rcu_*() will implies a grace period and return directly,
> so there is no sleep action due to waiting for a grace period to end,
> but this might_sleep() check is the opposite. therefore, this commit
> puts might_sleep() check in the correct palce.
>=20
> Signed-off-by: Zqiang <qiang1.zhang@intel.com>
>
>Queued for testing and review, thank you!
>
>I was under the impression that might_sleep() did some lockdep-based
>checking, but I am unable to find it.  If there really is such checking,
>that would be a potential argument for leaving this code as it is.
>

__might_sleep
   __might_resched(file, line, 0)
      rcu_sleep_check()

Does it refer to this rcu_sleep_check() ?

If so, when in the RCU_SCHEDULER_INACTIVE state,  the debug_lockdep_rcu_ena=
bled() is always
return false, so the RCU_LOCKDEP_WARN() also does not produce an actual war=
ning.

Thanks
Zqiang


>But in the meantime, full speed ahead!  ;-)
>
>						Thanx, Paul
>
> ---
>  kernel/rcu/tree.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>=20
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index ee8a6a711719..65f3dd2fd3ae 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -3379,9 +3379,10 @@ void __init kfree_rcu_scheduler_running(void)
>   */
>  static int rcu_blocking_is_gp(void)
>  {
> -	if (rcu_scheduler_active !=3D RCU_SCHEDULER_INACTIVE)
> +	if (rcu_scheduler_active !=3D RCU_SCHEDULER_INACTIVE) {
> +		might_sleep();
>  		return false;
> -	might_sleep();  /* Check for RCU read-side critical section. */
> +	}
>  	return true;
>  }
> =20
> --=20
> 2.25.1
>=20