Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Zhang, Qiang1" <qiang1.zhang@intel.com>
To:     "paulmck@kernel.org" <paulmck@kernel.org>
CC:     "frederic@kernel.org" <frederic@kernel.org>,
        "quic_neeraju@quicinc.com" <quic_neeraju@quicinc.com>,
        "joel@joelfernandes.org" <joel@joelfernandes.org>,
        "rcu@vger.kernel.org" <rcu@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] rcu: Remove duplicate settings for rcu boost kthreads
 affinity
Thread-Topic: [PATCH] rcu: Remove duplicate settings for rcu boost kthreads
 affinity
Thread-Index: AQHZEGMOnvxGUFjU2Uq5+RiLJLzbVq5xR5qAgAABybA=
Date:   Sat, 17 Dec 2022 02:00:35 +0000
Message-ID: <PH0PR11MB5880B9403488CAB5DF9810FFDAE79@PH0PR11MB5880.namprd11.prod.outlook.com>
References: <20221215090029.2972236-1-qiang1.zhang@intel.com>
 <20221217010919.GG4001@paulmck-ThinkPad-P17-Gen-1>
In-Reply-To: <20221217010919.GG4001@paulmck-ThinkPad-P17-Gen-1>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8WyZiAl0tlJ+mE+tWBcugYt1DKZn885bwpFfynFieGmUrVVZG1TWtsQJe8zC?=
 =?us-ascii?Q?RiS1hlbRfgm+xWOLTgeRYmivfleo+viQd+sks9jnxvF23gp48657FO2iiEC7?=
 =?us-ascii?Q?tQrgrNGd3MaRmQp3VIyBhVCuoWet9Imngjg2/eeIc+cSr1oBhi6Mn079ZsL+?=
 =?us-ascii?Q?V1UVogi53054ZrNPacujmWq0OJt96mkHfFgNd3tUfn+k4eOiEL6/lPkQnTAr?=
 =?us-ascii?Q?tMqc/ahlkrqlWm7QEJwpALRfV0zXYmd5DegMGsP5mNYdVyfCbvYXsqd/3CGv?=
 =?us-ascii?Q?AxKdfCFHoEJZBFkDbokKi+8otQnmgB1vJOunwLafAZzTv89kBxly1Lnn6fZw?=
 =?us-ascii?Q?MJI4xuqPxwNkjDl881Pz+VMzfbWzBVC2t2EdQ9ATQw9flhnw1zWvHRHWBPaM?=
 =?us-ascii?Q?MYGkIOhpUBns+ckcq/vyktDhP+Hr5cNJjr5lrWF8G6CnxLuP25L8NbX8IDVH?=
 =?us-ascii?Q?ioUmLzBbbxVZo8EbiQwmlDh3Wlpi6gbHYRBrQCwGA10Nzw/TgEcZGk+HWZlb?=
 =?us-ascii?Q?yE1i7VOSSErJy8Awmj3et0g/N/t1SDghn5ViTYA63pP9HR91o8gcqCrW/C5W?=
 =?us-ascii?Q?DIz0nlt5TzHfasstQR03c1qQj3rpUBG3hkVYjP/0T74VEXWRvx74BrUNnBXG?=
 =?us-ascii?Q?XePrUfxT6cNjsBmDpoYSGpHA9N0rYSxT42dBHbwIjprJeDuK+hsIEBn5ank7?=
 =?us-ascii?Q?a4nUqh8zrCHg4DXCPRQE9RjNoNAv2jceEGYRauO9JpwgTqCR1UfkZl0gpBSL?=
 =?us-ascii?Q?qMKk+tK/EBdEyIar2Xsm1DqEnJ7hDz2dtnFm+9+W+YzuZGhdo0J0pgmvwkZv?=
 =?us-ascii?Q?LAckOipqat2i2Rof9WFr91VUUauYKBqFwFaCilssy4OGKK1+2AoKhe9Isa4w?=
 =?us-ascii?Q?Ts9jXkUDujHzZlnbzxuUgj9lWcEL0VJ+vQ3NVKKsEesZj3CTPUSfTvFh3Rp8?=
 =?us-ascii?Q?XnT3HyOFNFWMKw+a00w8ZirOIn9srzQXJkpxvEi/dUHaoKq7oKHzooIxHOl4?=
 =?us-ascii?Q?gGYYuAU+C44+eCMwqQPJ+0npPKcwauoskrvDbbxCYOFqy4dRUTJHuXGnicTQ?=
 =?us-ascii?Q?EYMUEWDxuh/hcATGX7fMRqJsEPO9w15RfHRn0683tEstaKox159C0EbRjEhj?=
 =?us-ascii?Q?cxuLnULd8eADlTryp+YXQtEPH+QEBFTekHsNPcekAHwPUEa+O6T1/RwhKdZQ?=
 =?us-ascii?Q?bKU27yU06dNWvvopFuO5SAH+6eWhqrV5ZgH5KYF5xkbJn52gmg9Gh6caq9V1?=
 =?us-ascii?Q?7125gnrRM8XU1mpUov+bbDrMJNG4MqLl9PGwVr5Kx7HnCcvYXFdRx4LqTd5s?=
 =?us-ascii?Q?X1M9Kq8NIqdhhdTsc4FwwboVjL8oG/yM3qvA6WQI1/QpqDl+aSYSLREAeYAO?=
 =?us-ascii?Q?oQg4AXr/dFTuQrr/j6l6S6E++lsgPwV+NrtuiKGAk1fpzw8yw4FWlUazWam7?=
 =?us-ascii?Q?z3YnXkbVXiUqalhEV/6yLZO2xlRPv+PRx72LuH9gsw1CxMLFMs5UfxXtOsLQ?=
 =?us-ascii?Q?C8UmdqSJ7IdR/IZ17P67ce5ABm1+DveaOEGbHoI/ADpa29TjP9FXyT8twAeA?=
 =?us-ascii?Q?ohqkwlwcnaBsDZfH6rq0m1eXzXRvuvYcNeYt/lYV?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5880.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: baefa717-9909-455f-5afe-08dadfd27cb9
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2022 02:00:35.4838
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ybtJCJXazedXEp4SM/7pMyX1hzqFDY8IT8UxhAb2k/7YiLsK+hEpOFAJY4/S1icXtl0sONIadXYUiIUffrs6zw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6313
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On Thu, Dec 15, 2022 at 05:00:29PM +0800, Zqiang wrote:
> Currently, when CPUs going offline, the rcu boost kthreads CPU
> affinity has been reset in rcutree_offline_cpu(), therefore this
> commit remove duplicate settings in rcutree_dead_cpu().
>=20
> Signed-off-by: Zqiang <qiang1.zhang@intel.com>
>
>One question...
>
>Given that rcutree_offline_cpu() causes rcu_boost_kthread_setaffinity()
>to be invoked with the number of the outgoing CPU, but rcutree_dead_cpu()
>instead passes in -1, are these two invocations really redundant?

Although -1 is passed in, but at this time, the outgoing CPU has been remov=
ed from=20
rcu_rnp_online_cpus(rnp),  in other words, we will eliminate the same CPU, =
which is
also  we passed in cpu in the rcutree_offline_cpu() before.

Thanks
Zqiang

>
>							Thanx, paul

> ---
>  kernel/rcu/tree.c | 5 -----
>  1 file changed, 5 deletions(-)
>=20
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index 65f3dd2fd3ae..20de83ed0c7e 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -4122,15 +4122,10 @@ static void rcu_cleanup_dead_rnp(struct rcu_node =
*rnp_leaf)
>   */
>  int rcutree_dead_cpu(unsigned int cpu)
>  {
> -	struct rcu_data *rdp =3D per_cpu_ptr(&rcu_data, cpu);
> -	struct rcu_node *rnp =3D rdp->mynode;  /* Outgoing CPU's rdp & rnp. */
> -
>  	if (!IS_ENABLED(CONFIG_HOTPLUG_CPU))
>  		return 0;
> =20
>  	WRITE_ONCE(rcu_state.n_online_cpus, rcu_state.n_online_cpus - 1);
> -	/* Adjust any no-longer-needed kthreads. */
> -	rcu_boost_kthread_setaffinity(rnp, -1);
>  	// Stop-machine done, so allow nohz_full to disable tick.
>  	tick_dep_clear(TICK_DEP_BIT_RCU);
>  	return 0;
> --=20
> 2.25.1
>=20