Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Zhang, Qiang1" <qiang1.zhang@intel.com>
To:     "Zhang, Qiang1" <qiang1.zhang@intel.com>,
        "paulmck@kernel.org" <paulmck@kernel.org>
CC:     "frederic@kernel.org" <frederic@kernel.org>,
        "quic_neeraju@quicinc.com" <quic_neeraju@quicinc.com>,
        "joel@joelfernandes.org" <joel@joelfernandes.org>,
        "rcu@vger.kernel.org" <rcu@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] rcu: Fix opposite might_sleep() check in
 rcu_blocking_is_gp()
Thread-Topic: [PATCH] rcu: Fix opposite might_sleep() check in
 rcu_blocking_is_gp()
Thread-Index: AQHZEDjb4JuHblX+NUKrHh1V8qzf2q5xRmGAgAAGjvCAABO7YA==
Date:   Sat, 17 Dec 2022 02:44:47 +0000
Message-ID: <PH0PR11MB588000890D537044BBAA209EDAE79@PH0PR11MB5880.namprd11.prod.outlook.com>
References: <20221215035755.2820163-1-qiang1.zhang@intel.com>
 <20221217010345.GF4001@paulmck-ThinkPad-P17-Gen-1>
 <PH0PR11MB5880526CB255AFF91F0D76A2DAE79@PH0PR11MB5880.namprd11.prod.outlook.com>
In-Reply-To: <PH0PR11MB5880526CB255AFF91F0D76A2DAE79@PH0PR11MB5880.namprd11.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NU7GLO6/vV17CXey5EulFDfJi3bOGR3avmtUMbp+hbp5UzSrY249A92CgIr/?=
 =?us-ascii?Q?8HJbz2Wn+dhnP5zanwO1+C/IOP/G5HlK6vzFWRZZ0qiY8rqxNlXHMJmOVA48?=
 =?us-ascii?Q?DahbQrt2QkyVOlrC/rfVhn1LFPmAyULzwF0BNA0g+dn6i/alEbec8Y6W1/lW?=
 =?us-ascii?Q?c4gCjkcLJYzhaPFHtXFiqen4l/KOinHrNIBjJwDyn8vWjDtkHDm4Qdbnb6Un?=
 =?us-ascii?Q?TaDleNd8nUqjerFnXB8swTKqpswLjWd69SUck/XZ78H/jwqqTOupuCXUodQD?=
 =?us-ascii?Q?ZoCVnMQ/gOHn9Ht2CLcVwx7F22sRJL72VRIY4Fs4BvHYlomrnnbmpdAEePzL?=
 =?us-ascii?Q?+hqaQCGn3a0hAdLypzRI39rOmJ0P6YC8Eadn7dR7zbN28wcvenNzyX6XITLI?=
 =?us-ascii?Q?nV6ZmdvnyZ/t13ALxdvRWrRlO5Qcswv9twa5MAMEY6AFa4ySY1fuCGmf9CAR?=
 =?us-ascii?Q?C78AFuvLs/TvDJsQpis9ki2NPSKSsD9GQkGsGJCEvjn4qKqAhKwOcXapfFjK?=
 =?us-ascii?Q?WltVHBiU+IxrUZJbgBPGpOtSN98xLZ5Oeqv5kcDmxZ33rKj+c8zqmYCtxA2G?=
 =?us-ascii?Q?SUlg27q6p5V9fG0I9S2WXUIG2rL5kodnBdx/3xi6HWNfLa42poAe4Rsi0yAk?=
 =?us-ascii?Q?92ovylYdyBZP3wWtH+weEBUoEzlLurAd34XuAeRMdJ5Jras6c3G9ewlvuMuX?=
 =?us-ascii?Q?GMWd3mkSoRtCiqZktUHjamLAg3q05kPOtobvUi0Mhv9UtDuqok1PDb6xY6ad?=
 =?us-ascii?Q?iegq7zP5yvBj3IJMDCUHaEqnB3tXt9722+qojuTuVME+ELBiQigWuzfPjxrH?=
 =?us-ascii?Q?1yW8KI4XHNvfshFG9c9Vegc5BpPsizS57xtF67miNC941MYakJifK7l4gaKS?=
 =?us-ascii?Q?IJijYMPO1fes2ugbEc4vORElGH0AaUcVi6i8c0DcuIimF4pf/kxG9MOo6g5U?=
 =?us-ascii?Q?xNac/opxohc3Frqp4tdS7S/xYYnvVLf6Xy5bXDF7+6VRY4rrxPL/IuT6aw0V?=
 =?us-ascii?Q?NKtVCJ1rglGD8PpAjQFVJnIXmjL3noUufh3bwA0orbPQaYAkYvuvAazik3PG?=
 =?us-ascii?Q?vXG0eOpCBLWCoqH0gDdamvnvcjyF0lb2HiGNCl9fImMmG9NsT6dBBXUu/4oE?=
 =?us-ascii?Q?URY5XZaxOjpKyfhVAvLaRR5QKWphVEewAEw+WdK8B4kBNRTme+p+gIO5bmCN?=
 =?us-ascii?Q?U2txg2ImqrLkA3bzO0KmQNbz4N4CJKJED3rO+iERTxPJmOOYcpEOXKxSIIqW?=
 =?us-ascii?Q?E3tiWTti49PWtc2p1+tezdB3ZkjYgJrpShZeCde9WfKKF5IZndoAZxx4aRRF?=
 =?us-ascii?Q?dm2qe2U2g3RoZskVIFdpAP9NwC2tNQNGRpyqLlhq/S+0Kh4fDU/5D3IUIfX1?=
 =?us-ascii?Q?DCW3RPS6QsuDYCLkVOw74LpQkNgGo/JVfZURTO7fxNFsistEfEW0hySVwb9T?=
 =?us-ascii?Q?bhmcV6D+eaqLJ1dYvqVqi4gDjwZW8bSIMnDX7hlIPkeDMlsABzrrw9mKIlfI?=
 =?us-ascii?Q?LfzaJeyoSy6o1Qp+/3uQpwE4Gx5wS5wz/RuKNXckcEjqL37Pq8SekxLshQHY?=
 =?us-ascii?Q?9phwfw4KUwrL8Tq8i8muKZnfj78vyJm3Se8WA5H8?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5880.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 29d752ab-142f-4832-c0a3-08dadfd8a965
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2022 02:44:47.3981
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cCU2h44+KZsDD/+Isu/maDcfQLebL7mqVi8VGSXpDhBTL7Pm/BcATWVxRkvZgQLvguGP1DjxCiIDK6V9Irmutg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6712
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On Thu, Dec 15, 2022 at 11:57:55AM +0800, Zqiang wrote:
> Currently, if the system is in the RCU_SCHEDULER_INACTIVE state, invoke
> synchronize_rcu_*() will implies a grace period and return directly,
> so there is no sleep action due to waiting for a grace period to end,
> but this might_sleep() check is the opposite. therefore, this commit
> puts might_sleep() check in the correct palce.
>=20
> Signed-off-by: Zqiang <qiang1.zhang@intel.com>
>
>Queued for testing and review, thank you!
>
>I was under the impression that might_sleep() did some lockdep-based
>checking, but I am unable to find it.  If there really is such checking,
>that would be a potential argument for leaving this code as it is.
>
>
>__might_sleep
>   __might_resched(file, line, 0)
>      rcu_sleep_check()
>
>Does it refer to this rcu_sleep_check() ?
>
>If so, when in the RCU_SCHEDULER_INACTIVE state,  the debug_lockdep_rcu_en=
abled() is always
>return false, so the RCU_LOCKDEP_WARN() also does not produce an actual wa=
rning.
>

and when the system_state =3D=3D SYSTEM_BOOTING, we just did  rcu_sleep_che=
ck()  and then  return.

Thanks
Zqiang

>Thanks
>Zqiang
>

>But in the meantime, full speed ahead!  ;-)
>
>						Thanx, Paul
>
> ---
>  kernel/rcu/tree.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>=20
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index ee8a6a711719..65f3dd2fd3ae 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -3379,9 +3379,10 @@ void __init kfree_rcu_scheduler_running(void)
>   */
>  static int rcu_blocking_is_gp(void)
>  {
> -	if (rcu_scheduler_active !=3D RCU_SCHEDULER_INACTIVE)
> +	if (rcu_scheduler_active !=3D RCU_SCHEDULER_INACTIVE) {
> +		might_sleep();
>  		return false;
> -	might_sleep();  /* Check for RCU read-side critical section. */
> +	}
>  	return true;
>  }
> =20
> --=20
> 2.25.1
>=20