Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 17 Dec 2022 04:56:03 +0000
From:   Matthew Wilcox <willy@infradead.org>
To:     Lorenzo Stoakes <lstoakes@gmail.com>
Cc:     linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org,
        Andrey Konovalov <andreyknvl@gmail.com>,
        Ingo Molnar <mingo@kernel.org>, Marco Elver <elver@google.com>,
        Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH] mm: remove unused alloc_pages_bulk_list()
Message-ID: <Y51L496TjNuiSxsG@casper.infradead.org>
References: <20221217001554.554913-1-lstoakes@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221217001554.554913-1-lstoakes@gmail.com>
Precedence: bulk

On Sat, Dec 17, 2022 at 12:15:54AM +0000, Lorenzo Stoakes wrote:
> This function is not referenced anywhere else in the kernel, remove it.

I think we're waiting to see if any users show up.  It's only been 18
months or so, so perhaps wait a little longer?

Also, if we do get rid of this, then __alloc_pages_bulk() can lose
the "list" argument.

> Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com>
> ---
>  include/linux/gfp.h | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/include/linux/gfp.h b/include/linux/gfp.h
> index 65a78773dcca..67c5164f4758 100644
> --- a/include/linux/gfp.h
> +++ b/include/linux/gfp.h
> @@ -188,13 +188,6 @@ unsigned long alloc_pages_bulk_array_mempolicy(gfp_t gfp,
>  				unsigned long nr_pages,
>  				struct page **page_array);
>  
> -/* Bulk allocate order-0 pages */
> -static inline unsigned long
> -alloc_pages_bulk_list(gfp_t gfp, unsigned long nr_pages, struct list_head *list)
> -{
> -	return __alloc_pages_bulk(gfp, numa_mem_id(), NULL, nr_pages, list, NULL);
> -}
> -
>  static inline unsigned long
>  alloc_pages_bulk_array(gfp_t gfp, unsigned long nr_pages, struct page **page_array)
>  {
> -- 
> 2.38.1
>