Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 17 Dec 2022 13:52:29 +0100
From:   Philipp Zabel <philipp.zabel@gmail.com>
To:     Mario Limonciello <mario.limonciello@amd.com>
Cc:     rafael@kernel.org,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        anson.tsao@amd.com, ben@bcheng.me, paul@zogpog.com,
        bilkow@tutanota.com, Shyam-sundar.S-k@amd.com,
        stable@vger.kernel.org, Len Brown <lenb@kernel.org>,
        linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ACPI: x86: s2idle: Stop using AMD specific codepath
 for Rembrandt+
Message-ID: <Y527jSpi96ARTZVN@rog>
References: <20221215191617.1438-1-mario.limonciello@amd.com>
 <20221215191617.1438-3-mario.limonciello@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221215191617.1438-3-mario.limonciello@amd.com>
Precedence: bulk

Am Thu, Dec 15, 2022 at 01:16:16PM -0600 schrieb Mario Limonciello:
> After we introduced a module parameter and quirk infrastructure for
> picking the Microsoft GUID over the SOC vendor GUID we discovered
> that lots and lots of systems are getting this wrong.
> 
> The table continues to grow, and is becoming unwieldy.
> 
> We don't really have any benefit to forcing vendors to populate the
> AMD GUID. This is just extra work, and more and more vendors seem
> to mess it up.  As the Microsoft GUID is used by Windows as well,
> it's very likely that it won't be messed up like this.
> 
> So drop all the quirks forcing it and the Rembrandt behavior. This
> means that Cezanne or later effectively only run the Microsoft GUID
> codepath with the exception of HP Elitebook 8*5 G9.
> 
> Fixes: fd894f05cf30 ("ACPI: x86: s2idle: If a new AMD _HID is missing assume Rembrandt")
> Cc: stable@vger.kernel.org # 6.1
> Reported-by: Benjamin Cheng <ben@bcheng.me>
> Reported-by: bilkow@tutanota.com
> Reported-by: Paul <paul@zogpog.com>
> Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2292
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216768
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>

Reviewed-by: Philipp Zabel <philipp.zabel@gmail.com>
Tested-by: Philipp Zabel <philipp.zabel@gmail.com>

regards
Philipp