Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp384173rwj; Sat, 17 Dec 2022 09:23:00 -0800 (PST) X-Google-Smtp-Source: AA0mqf67Nmt/tHwvtFZwkeSz9uLabhR0ZJtq4yM1EA/F6SjOYr9+iIyJSbNafhtzSU5hQXfJcZXp X-Received: by 2002:a17:906:f50:b0:7b2:c227:126d with SMTP id h16-20020a1709060f5000b007b2c227126dmr27758139ejj.20.1671297780662; Sat, 17 Dec 2022 09:23:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671297780; cv=none; d=google.com; s=arc-20160816; b=sGSveyA8EscZs0mBkK7vhXAOXCcgSLaUzdxOgGdd5yrw7I/SKHDbTGdBXNiK8QoGpb JByb1APy76/whTsIvYeID507U/HaSw9rvn6HlHRnvR2VAcbucUsGe7TSJ8JkKGAk54lQ Qqhs5uklhfsIuWI8YWB32EmCt0951MRYK58BcqP76LPPttOnpw5m/Z+gu+gigfGgjZ1B Jdo3u52BMDLwg7iPbQNZx1xsgeEe5IrzYHlQrQ2Mibh9D+a401/JD0edoXeEvG/f/XsA EAWUmC33XLqr1q/xitqK29sDDe885m4Ja9BC3ZGt77Gkx8QuAX7wZDL88MA81GvTg43P jy+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :message-id:subject:cc:to:from:date:dkim-signature; bh=adkLEfTwrhul8r/R4pO+I0uvNGAPhMoq38XZjivsiuU=; b=q8hzV4rlnBnhXtJDsX/cdFmiugCTLIIooV5Cw9yxYtjXSohsc3pcUlUmyOjR2uzioa YOnvdXzODx3aoMvdBCQiQMEkRFWD5TNdVujuiuljKKn0WF4EWsjJy1VKJAfcXqRKrS0D hrkkMhOikV88/vXeLmjuIpD3l+q7FAAzWYPa/HjHDkOV0wo3xejo41jFlysZnp6JjVKZ f1gnNn4rudOczHK7M/IHhUigE16bIcpEZ+nRZcUghKTTBiCVZt2J76MpremISC9sL8G9 PH/FSTALoHT5DAjTsJouTr55OUZoxqp68xolPuI+wbaMlLTpO8DMa85Mh/5oCF/rAqxd QutQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XnN2aKjI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id xj14-20020a170906db0e00b007877f3132d9si4970685ejb.438.2022.12.17.09.22.43; Sat, 17 Dec 2022 09:23:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XnN2aKjI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230217AbiLQQER (ORCPT + 70 others); Sat, 17 Dec 2022 11:04:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230385AbiLQQD4 (ORCPT ); Sat, 17 Dec 2022 11:03:56 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BDCF3B9 for ; Sat, 17 Dec 2022 07:58:46 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4ADC7B802C5 for ; Sat, 17 Dec 2022 15:58:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7A67C433D2; Sat, 17 Dec 2022 15:58:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671292723; bh=0SWU9xGA4GT0P8n+P8Hu88az0XrllApnKjpIJZPfI6w=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=XnN2aKjICo0GvkdUazSQ2jmJaoJ2C1FSTVpRoP4SN0crKqSmV0v4ZlGh5x2jXYra7 /t2Qks3AmvR+uri2OMeXWCeiCiQNQWjZCrmb/fuSim9MmgUXt8JgmDgQ0uQYRRSs/T aVBOVdzT8Dh411yZ7fKdJxFux0Yo09QLu/rX4dBT4Ur9swiVSYwKY05XfTYhnkKoq5 E6+MCKwJSb4JNYV/+uxOvQI8oA5Y7IsuoI1AO1UVltLQKNctFGNc97FPDwqUicC37m g/XQjEKmj7R/sI79ineVDreqH8+KqgFfTvsgGQDaUqy5OrjzZLlqwaP+FiR89fshjq UE1CVe1VNmdag== Date: Sat, 17 Dec 2022 09:58:42 -0600 From: Bjorn Helgaas To: Baoquan He Cc: Eric Biederman , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Bjorn Helgaas Subject: Re: [PATCH 0/2] kexec: Remove unnecessary arch hook Message-ID: <20221217155842.GA389338@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 17, 2022 at 05:48:51PM +0800, Baoquan He wrote: > On 12/15/22 at 12:23pm, Bjorn Helgaas wrote: > > From: Bjorn Helgaas > > > > There are no arch-specific things in arch_kexec_kernel_image_load(), so > > remove it and just use the generic version. > > I ever posted below patch to do the same thing, Andrew only picked the > memory leak fixing patch. > > [PATCH v2 2/2] kexec_file: clean up arch_kexec_kernel_image_load > https://lore.kernel.org/all/20220223113225.63106-3-bhe@redhat.com/T/#u Indeed! Sorry, I wasn't aware of your previous work. If you repost it, cc me and I'll be glad to help review it. > > Bjorn Helgaas (2): > > x86/kexec: Remove unnecessary arch_kexec_kernel_image_load() > > kexec: Remove unnecessary arch_kexec_kernel_image_load() > > > > arch/x86/include/asm/kexec.h | 3 --- > > arch/x86/kernel/machine_kexec_64.c | 11 ----------- > > include/linux/kexec.h | 8 -------- > > kernel/kexec_file.c | 6 +++--- > > 4 files changed, 3 insertions(+), 25 deletions(-)