Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp1247760rwj; Sun, 18 Dec 2022 05:04:21 -0800 (PST) X-Google-Smtp-Source: AMrXdXt9nIC+TBdbCFXDuzqZwB2/HHu9P954mgD4SLfUh5dCyIo/E9AxvnWUXcNc/86o+3P+ga0F X-Received: by 2002:a17:907:9a8c:b0:7fc:3fef:ab86 with SMTP id km12-20020a1709079a8c00b007fc3fefab86mr4078332ejc.71.1671368661474; Sun, 18 Dec 2022 05:04:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671368661; cv=none; d=google.com; s=arc-20160816; b=pSwYrdDu8zFtkVzbvIwsF6G4HKpXMbtDvOpvDVJGWpDOHedUQ9X6wXuuLxdANVtbxh Lxr4Xy/3G/tdz14AQ4v3CClzZQUxD6SCkw6WdQd+MfDoqFrV4cvwgX6hwmjvy68nDIiU uWD9FjABG9a9Y6quIRFlzx0BWGeH3e8HBbDGTTnByIX49BnWslHyvcKHVNMSlO+0agub nlXnQF9Zc5dRF4pC1QULUzFGTow7W/dvFUYEgfC4SwWAf+W2/vf5MQdiH+YHmIFfJerG e+t3KdbVJ5zxvlbzWas80X+EfeIvyxF+24uY7yYQBWzYM9PT1vjgdfJjP4eqga9nMhOY V5UQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :cc:to:subject:from:date; bh=VqJmQ7Iv3ZnMCuEPZUttaGFHJUuPRQJrWa5L94sMWRI=; b=sd4F3UNPLk0GBM1nRxlQwdvBUcc/218VxvViTApN+40UBf3rH6SY2Qvh5AmdC0JBbl 0q18A4jN6ynokWytdkge+ibs97f1V0DfMn95KecIV7P42AkcTHeP6rCMs/MkKr06urOZ eGktCFWQUd+OIofBa2JL++2zGZqYLWLpGoWez5krtWPZkUmfoN9mVRkw1lW9rexoaSsr noIUe21Jh/6BZHIQxhylawBfHzOPbSs5XBmu/MZbNm1UJOaf1JLViaPb+3/iQpPhii08 cWUt+fA74ADxc2Eb1RnP31JZZGC9IM/xSacCB5n/aQYSaLMP9oA+jswKoIOmaafLpNL6 eLNw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g20-20020a1709065d1400b007adb868f102si7693329ejt.476.2022.12.18.05.04.02; Sun, 18 Dec 2022 05:04:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230259AbiLRLKx (ORCPT + 71 others); Sun, 18 Dec 2022 06:10:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230191AbiLRLKt (ORCPT ); Sun, 18 Dec 2022 06:10:49 -0500 Received: from m-r2.th.seeweb.it (m-r2.th.seeweb.it [IPv6:2001:4b7a:2000:18::171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E44AF8; Sun, 18 Dec 2022 03:10:47 -0800 (PST) Received: from [192.168.2.144] (adsl-d248.84-47-10.t-com.sk [84.47.10.248]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id D707D3EF28; Sun, 18 Dec 2022 12:10:43 +0100 (CET) Date: Sun, 18 Dec 2022 12:10:37 +0100 From: Martin Botka Subject: Re: [PATCH v4 3/4] arm64: dts: qcom: sm6125: Add apps_smmu with streamID to SDHCI 1/2 nodes To: Marijn Suijten Cc: phone-devel@vger.kernel.org, Will Deacon , Joerg Roedel , Bjorn Andersson , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Jami Kettunen , Lux Aliaga , Robin Murphy , Rob Herring , Krzysztof Kozlowski , Andy Gross , Konrad Dybcio , Dmitry Baryshkov , Thierry Reding , Melody Olvera , Greg Kroah-Hartman , Bhupesh Sharma , Douglas Anderson , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Message-Id: In-Reply-To: <20221216215819.1164973-4-marijn.suijten@somainline.org> References: <20221216215819.1164973-1-marijn.suijten@somainline.org> <20221216215819.1164973-4-marijn.suijten@somainline.org> X-Mailer: geary/40.0 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,RCVD_IN_SORBS_HTTP, RCVD_IN_SORBS_SOCKS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 16 2022 at 10:58:18 PM +01:00:00, Marijn Suijten wrote: > When enabling the APPS SMMU the mainline driver reconfigures the SMMU > from its bootloader configuration, loosing the stream mapping for > (among > which) the SDHCI hardware and breaking its ADMA feature. This feature > can be disabled with: > > sdhci.debug_quirks=0x40 > > But it is of course desired to have this feature enabled and working > through the SMMU. > > Signed-off-by: Marijn Suijten > --- > arch/arm64/boot/dts/qcom/sm6125.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi > b/arch/arm64/boot/dts/qcom/sm6125.dtsi > index 347665c2067c..f560499cc0ca 100644 > --- a/arch/arm64/boot/dts/qcom/sm6125.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm6125.dtsi > @@ -468,6 +468,7 @@ sdhc_1: mmc@4744000 { > <&gcc GCC_SDCC1_APPS_CLK>, > <&xo_board>; > clock-names = "iface", "core", "xo"; > + iommus = <&apps_smmu 0x160 0>; > > power-domains = <&rpmpd SM6125_VDDCX>; > > @@ -494,6 +495,7 @@ sdhc_2: mmc@4784000 { > <&gcc GCC_SDCC2_APPS_CLK>, > <&xo_board>; > clock-names = "iface", "core", "xo"; > + iommus = <&apps_smmu 0x180 0>; > > pinctrl-0 = <&sdc2_on_state>; > pinctrl-1 = <&sdc2_off_state>; > -- > 2.39.0 > With 0x0 as mask Reviewed-by: Martin Botka -Martin