Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936241AbXHPAdR (ORCPT ); Wed, 15 Aug 2007 20:33:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757549AbXHPAc5 (ORCPT ); Wed, 15 Aug 2007 20:32:57 -0400 Received: from rhun.apana.org.au ([64.62.148.172]:1435 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752840AbXHPAcz (ORCPT ); Wed, 15 Aug 2007 20:32:55 -0400 Date: Thu, 16 Aug 2007 08:32:26 +0800 From: Herbert Xu To: Satyam Sharma Cc: Segher Boessenkool , horms@verge.net.au, Stefan Richter , Linux Kernel Mailing List , "Paul E. McKenney" , ak@suse.de, netdev@vger.kernel.org, cfriesen@nortel.com, Heiko Carstens , rpjday@mindspring.com, jesper.juhl@gmail.com, linux-arch@vger.kernel.org, Andrew Morton , zlynx@acm.org, clameter@sgi.com, schwidefsky@de.ibm.com, Chris Snook , davem@davemloft.net, Linus Torvalds , wensong@linux-vs.org, wjiang@resilience.com Subject: Re: your mail Message-ID: <20070816003226.GA29491@gondor.apana.org.au> References: <46C30540.2070603@s5r6.in-berlin.de> <20070815145207.GA23106@gondor.apana.org.au> <46C3253F.5090707@s5r6.in-berlin.de> <20070815162722.GD9645@linux.vnet.ibm.com> <20070815185724.GH9645@linux.vnet.ibm.com> <2d2eeab6276cab2e6cc5830d36a43b98@kernel.crashing.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 884 Lines: 26 On Thu, Aug 16, 2007 at 06:06:00AM +0530, Satyam Sharma wrote: > > that are: > > while ((atomic_read(&waiting_for_crash_ipi) > 0) && msecs) { > mdelay(1); > msecs--; > } > > where mdelay() becomes __const_udelay() which happens to be in another > translation unit (arch/i386/lib/delay.c) and hence saves this callsite > from being a bug :-) The udelay itself certainly should have some form of cpu_relax in it. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/