Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 18 Dec 2022 22:25:23 +0300
From:   Serge Semin <fancer.lancer@gmail.com>
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     Arnd Bergmann <arnd@kernel.org>, Mark Brown <broonie@kernel.org>,
        Serge Semin <Sergey.Semin@baikalelectronics.ru>,
        Ramil Zaripov <Ramil.Zaripov@baikalelectronics.ru>,
        linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: dw_bt1: fix MUX_MMIO dependencies
Message-ID: <20221218192523.c6vnfo26ua6xqf26@mobilestation>
References: <20221215165247.1723462-1-arnd@kernel.org>
 <20221218142231.qhczawk2zhpgh6dl@mobilestation>
 <60290159-8d63-4358-9ff1-a65cc335e0c6@app.fastmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <60290159-8d63-4358-9ff1-a65cc335e0c6@app.fastmail.com>
Precedence: bulk

On Sun, Dec 18, 2022 at 06:56:24PM +0100, Arnd Bergmann wrote:
> On Sun, Dec 18, 2022, at 15:22, Serge Semin wrote:
> > Hi Arnd
> >
> > On Thu, Dec 15, 2022 at 05:52:34PM +0100, Arnd Bergmann wrote:
> >> From: Arnd Bergmann <arnd@arndb.de>
> >> 
> >> Selecting a symbol with additional dependencies requires
> >> adding the same dependency here:
> >> 
> >> WARNING: unmet direct dependencies detected for MUX_MMIO
> >>   Depends on [n]: MULTIPLEXER [=y] && OF [=n]
> >>   Selected by [y]:
> >>   - SPI_DW_BT1 [=y] && SPI [=y] && SPI_MASTER [=y] && SPI_DESIGNWARE [=y] && (MIPS_BAIKAL_T1 || COMPILE_TEST [=y])
> >> 
> >> Alternatively, we could drop this 'select' and require users to manually
> >> put it into their .config as we do for other drivers.
> >
> > Thanks for the patch. Seeing the driver is only implicitly dependent
> > from the mux-mmio driver (via the device described in the device tree
> > blob) I'd suggest to either drop the MUX_MMIO config reverse
> > dependency or convert it to the weak one - 'imply' (if it will solve
> > the problem).
> 

> Ok, I'll send a new patch. I don't want to use 'imply' though, that
> tends to cause other problems because almost nobody understands what
> it actually does.

Ok. Dropping it will be also suitable solution. I'll make sure our
defconfigs will be updated afterwards.

-Serge(y)

> 
>       Arnd