Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937860AbXHPCUQ (ORCPT ); Wed, 15 Aug 2007 22:20:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933427AbXHPCTx (ORCPT ); Wed, 15 Aug 2007 22:19:53 -0400 Received: from mga03.intel.com ([143.182.124.21]:45995 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762708AbXHPCTw (ORCPT ); Wed, 15 Aug 2007 22:19:52 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.19,268,1183359600"; d="scan'208";a="263787383" Message-ID: <46C3B428.4000003@intel.com> Date: Wed, 15 Aug 2007 19:19:20 -0700 From: "Kok, Auke" User-Agent: Thunderbird 2.0.0.4 (X11/20070623) MIME-Version: 1.0 To: Joe Perches , Andy Whitcroft , "Randy.Dunlap" , Joel Schopp CC: Dave Jones , Linux Kernel , rolandd@cisco.com, Chas Williams , Paul Mundt , isdn4linux@listserv.isdn4linux.de, mikep@linuxtr.net, netdev@vger.kernel.org, swen@vnet.ibm.com, linux390@de.ibm.com, linux-s390@vger.kernel.org, jdike@karaya.com, user-mode-linux-devel@lists.sourceforge.net, user-mode-linux-user@lists.sourceforge.net, netfilter-devel@lists.netfilter.org, coreteam@netfilter.org Subject: Re: drivers/infiniband/mlx/mad.c misplaced ; References: <20070815235825.GB17004@redhat.com> <1187224811.5906.55.camel@localhost> In-Reply-To: <1187224811.5906.55.camel@localhost> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1637 Lines: 38 Joe Perches wrote: > On Wed, 2007-08-15 at 19:58 -0400, Dave Jones wrote: >> Signed-off-by: Dave Jones >> >> diff --git a/drivers/infiniband/hw/mlx4/mad.c b/drivers/infiniband/hw/mlx4/mad.c >> index 3330917..0ed02b7 100644 >> --- a/drivers/infiniband/hw/mlx4/mad.c >> +++ b/drivers/infiniband/hw/mlx4/mad.c >> @@ -109,7 +109,7 @@ int mlx4_MAD_IFC(struct mlx4_ib_dev *dev, int ignore_mkey, int ignore_bkey, >> in_modifier, op_modifier, >> MLX4_CMD_MAD_IFC, MLX4_CMD_TIME_CLASS_C); >> >> - if (!err); >> + if (!err) > > There's more than a few of these (not inspected). > > $ egrep -r --include=*.c "\bif[[:space:]]*\([^\)]*\)[[:space:]]*\;" * > arch/sh/boards/se/7343/io.c: if (0) ; > drivers/atm/iphase.c: if (!desc1) ; > drivers/infiniband/hw/mlx4/mad.c: if (!err); > drivers/isdn/capi/capiutil.c: else if (c <= 0x0f); > drivers/net/tokenring/ibmtr.c: else if (ti->shared_ram_paging == 0xf); /* No paging in adapter */ > drivers/s390/scsi/zfcp_erp.c: if (status == ZFCP_ERP_SUCCEEDED) ; /* no further action */ > fs/hostfs/hostfs_user.c: if(attrs->ia_valid & HOSTFS_ATTR_CTIME) ; > net/netfilter/xt_u32.c: if (skb->len < 4 || pos > skb->len - 4); > sound/pci/au88x0/au88x0_synth.c: if (eax == 0) ; sounds like an excellent candidate check for checkpatch.pl !!! Cheers, Auke - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/