Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp1725147rwj; Sun, 18 Dec 2022 14:21:09 -0800 (PST) X-Google-Smtp-Source: AA0mqf5wy1FThhokTcfDo1tEGJ2e8QGnawqdFVHnUn/z7Rfmt2Vs1OPijU1jS9hgOcIYnk33mels X-Received: by 2002:a17:907:9208:b0:7c0:d605:fe42 with SMTP id ka8-20020a170907920800b007c0d605fe42mr26637502ejb.18.1671402068951; Sun, 18 Dec 2022 14:21:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671402068; cv=none; d=google.com; s=arc-20160816; b=AKyQhjwmHAGsjxzqYz4iEoekPxx6XdXj1CKZpUizovBtx8jY5fnXtwxwOpNBOrNKdb tIMdSOMPuOSm4qfWTxqCJSeHA5jvG8tFLRUy5wzzEFwvjoWy30Sbgz4zlX+GdGUBm74s 4g0H7ic73V+i0vsrJxykBnOGU3sUg4gi2YEmD8VLCfc60NBcuBNQFBaq9dRe9mePpTHX KkkS8Nd3DW2H7WVAl67gpMBqEEoTVjQDRIeX7gP0luJDo4UKeOUs2rdGdnqodYM7UTyY x9Zn1Ab5pNbpIV3oc8m1LyrC8qN4ev4zvzPvb8VMuyP5/018XcgZBcAONdeqrtpQh7Z6 M3ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=+nDChsAiauvTbVEjEy6+4uC6d/Qdg4vgddjYfyqQ9Xo=; b=ttNf8XYzx0L7xeZR/cqHG/rJ9OuZux2u3DDykk54bRWXO7NrHG5y3AqRkmCXmlRVo0 rFzBpSyu2DFbSRyIckGZgAEooa50UANw1XiV0s2uSjn6TPpX6iDEv1RQ/SBiwUEoYI54 leBKCbq1lpT5m1/swoakwWz0ELNq+nQ639c1g0qrzqHN/jIXAbFIbvj2F+k3Tmtddx8w Isgu5h+HIYHG6xjQU50AFf14VNu9/K0VRgPkZvQCWyF50+aYJE5JZK0uYo2QS6SOxcRG ozI2O5YuOOCOBuqfYqs3TKZ4jhOugAkj8jH8HGfAdWGDJeIKY8XqU3fn5cdo44+KYRlV cyZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@networkplumber-org.20210112.gappssmtp.com header.s=20210112 header.b=mGK+PMgM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=networkplumber.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u13-20020a170906408d00b007c17d93ca62si5750307ejj.971.2022.12.18.14.20.52; Sun, 18 Dec 2022 14:21:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@networkplumber-org.20210112.gappssmtp.com header.s=20210112 header.b=mGK+PMgM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=networkplumber.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231271AbiLRWQw (ORCPT + 70 others); Sun, 18 Dec 2022 17:16:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229507AbiLRWQl (ORCPT ); Sun, 18 Dec 2022 17:16:41 -0500 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F159D5F86 for ; Sun, 18 Dec 2022 14:16:40 -0800 (PST) Received: by mail-pl1-x636.google.com with SMTP id n4so7370504plp.1 for ; Sun, 18 Dec 2022 14:16:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=+nDChsAiauvTbVEjEy6+4uC6d/Qdg4vgddjYfyqQ9Xo=; b=mGK+PMgM1pZQQs/9Bu2754hwGDLH7/WmvhSNY20eHOI8H2XkLCpF3BnAcYW7LKK47n OGK83Zs7WwejNNqrs+QTsGqQV/pX01Z+/7PfUKOrhvusE2AyO2Lk3lvzFI1nwcuFRn18 CnxX3eEwbHzk58BJW1JCQpkpfTGIDVDAqlO2wTxEgckbvKmxMyPlAgpT79fkQfbYqpxL lcFD+Sm/SlTJ6hunAZ3b2EBnco02emf66kxkbft7DxCJrFJrFBhbV8r31S07Dxx6UENu QvDanI56PocdRtIkNgKRR11DQl8gwwT/n3/qISJqGQr+pFNhiY+nPoyFNTnxsFTXbjGw WsGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+nDChsAiauvTbVEjEy6+4uC6d/Qdg4vgddjYfyqQ9Xo=; b=Vfty+YSoMTs8d1x/vJPIw93RncqxVkeqIoKJ6P49sl8Bx2MEc68Bm6uIQMS0KDOBvF LrDwxYnZpyWpqNUSI77eofOfJXOQqe2QPpB2fn1l8FgJEiQR+Z7ESwu7h3/+42LztClI 1D1ZmTAKXQ4fHoCkEnJC1C9a+zjHZs1V5rrVL0SvwbkixEM7Ys5Hb21lrErdEnE/CxoU g+qruCerv577M9W+r0t3a0ZqZvC4Qg4Rfb3QSSlAJJzucBYaXqoh+d0ZR4EqNYghK5ie tTCqvfLsb22FaLEUruU/88BVI9YEczFJSE9ouLdYzSo4BS86uXj7La+kyOYlTQbsD4lG 2lCA== X-Gm-Message-State: ANoB5pnkmgFMN71MpbYbg/jYBd9ZyrVUznBwWf2yPNSxtiL8w3Cs6XlK SxO04Abt2Q505GjuAaGLcnoZBOIs+5FxxRErA+E= X-Received: by 2002:a17:903:330d:b0:189:aedc:f6d6 with SMTP id jk13-20020a170903330d00b00189aedcf6d6mr39548113plb.28.1671401800402; Sun, 18 Dec 2022 14:16:40 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id p15-20020a170902780f00b00186b69157ecsm5504029pll.202.2022.12.18.14.16.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Dec 2022 14:16:40 -0800 (PST) Date: Sun, 18 Dec 2022 14:16:38 -0800 From: Stephen Hemminger To: Thomas Winter Cc: davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org, kuba@kernel.org, a@unstable.cc, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] ip/ip6_gre: Fix changing addr gen mode not generating IPv6 link local address Message-ID: <20221218141638.41d8d32f@hermes.local> In-Reply-To: <20221218215718.1491444-2-Thomas.Winter@alliedtelesis.co.nz> References: <20221218215718.1491444-1-Thomas.Winter@alliedtelesis.co.nz> <20221218215718.1491444-2-Thomas.Winter@alliedtelesis.co.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 19 Dec 2022 10:57:17 +1300 Thomas Winter wrote: > + switch (dev->type) { > + #if IS_ENABLED(CONFIG_IPV6_SIT) > + case ARPHRD_SIT: > + addrconf_sit_config(dev); > + break; > + #endif > + #if IS_ENABLED(CONFIG_NET_IPGRE) || IS_ENABLED(CONFIG_IPV6_GRE) > + case ARPHRD_IP6GRE: > + case ARPHRD_IPGRE: > + addrconf_gre_config(dev); > + break; > + #endif Linux kernel style is to start any conditional compilation in first column I.e. #if IS_ENABLED(CONFIG_IPV6_SIT) Not #if IS_ENABLED(CONFIG_IPV6_SIT)