Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <77487520-3812-0a9f-54e6-e9cb7feb6e51@denx.de>
Date:   Mon, 19 Dec 2022 07:03:49 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [RESEND v12 4/4] phy: freescale: imx8m-pcie: Add i.MX8MP PCIe PHY
 support
To:     Hongxing Zhu <hongxing.zhu@nxp.com>,
        "vkoul@kernel.org" <vkoul@kernel.org>,
        "a.fatoum@pengutronix.de" <a.fatoum@pengutronix.de>,
        "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
        "l.stach@pengutronix.de" <l.stach@pengutronix.de>,
        "bhelgaas@google.com" <bhelgaas@google.com>,
        "lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
        "robh@kernel.org" <robh@kernel.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "alexander.stein@ew.tq-group.com" <alexander.stein@ew.tq-group.com>,
        "richard.leitner@linux.dev" <richard.leitner@linux.dev>
Cc:     "linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        dl-linux-imx <linux-imx@nxp.com>
References: <1665625622-20551-1-git-send-email-hongxing.zhu@nxp.com>
 <1665625622-20551-5-git-send-email-hongxing.zhu@nxp.com>
 <c21996f3-0f1d-8b77-95fb-ab98f3a28913@denx.de>
 <AS8PR04MB86767EFD1DE8CC1FBA574D708CE59@AS8PR04MB8676.eurprd04.prod.outlook.com>
Content-Language: en-US
From:   Marek Vasut <marex@denx.de>
In-Reply-To: <AS8PR04MB86767EFD1DE8CC1FBA574D708CE59@AS8PR04MB8676.eurprd04.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/19/22 04:25, Hongxing Zhu wrote:

Hi,

>>> @@ -238,6 +251,14 @@ static int imx8_pcie_phy_probe(struct
>> platform_device *pdev)
>>>    		return PTR_ERR(imx8_phy->reset);
>>>    	}
>>>
>>> +	if (imx8_phy->drvdata->variant == IMX8MP) {
>>> +		imx8_phy->perst =
>>> +			devm_reset_control_get_exclusive(dev, "perst");
>>> +		if (IS_ERR(imx8_phy->perst))
>>> +			dev_err_probe(dev, PTR_ERR(imx8_phy->perst),
>>
>> I just notice this , are we missing return here ?
>>
>> That is ... return dev_err_probe(...) ?
> 
> Ooh, it's my fault. Thanks for your reminder.
> One return should be here.
> -                       dev_err_probe(dev, PTR_ERR(imx8_phy->perst),
> +                       return dev_err_probe(dev, PTR_ERR(imx8_phy->perst),
> Hi Vinod @vkoul@kernel.org:
> Should I re-summit one fix patch?

I think just send a follow up patch with Fixes: tag .