Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 19 Dec 2022 15:16:17 +0800
From:   Baoquan He <bhe@redhat.com>
To:     Lorenzo Stoakes <lstoakes@gmail.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org, urezki@gmail.com,
        stephen.s.brennan@oracle.com, willy@infradead.org,
        akpm@linux-foundation.org, hch@infradead.org
Subject: Re: [PATCH v2 5/7] mm/vmalloc: skip the uninitilized vmalloc areas
Message-ID: <Y6APwfb9v2t3xUhv@MiWiFi-R3L-srv>
References: <20221217015435.73889-1-bhe@redhat.com>
 <20221217015435.73889-6-bhe@redhat.com>
 <Y52w/w3IqJ0SCI6I@lucifer>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y52w/w3IqJ0SCI6I@lucifer>
Precedence: bulk

On 12/17/22 at 12:07pm, Lorenzo Stoakes wrote:
> On Sat, Dec 17, 2022 at 09:54:33AM +0800, Baoquan He wrote:
> > @@ -3617,6 +3617,11 @@ long vread(char *buf, char *addr, unsigned long count)
> >  		if (!vm && !flags)
> >  			continue;
> >
> > +		if (vm->flags & VM_UNINITIALIZED)
> > +			continue;
> 
> This comes immediately after asserting that vm _might be null_. This surely must become:-
> 
> if (vm && vm->flags & VM_UNINITIALIZED)
>         continue;

You are right, will fix it in v3. Thanks for careful reivewing.