Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 19 Dec 2022 15:01:03 +0800
From:   Baoquan He <bhe@redhat.com>
To:     Bjorn Helgaas <helgaas@kernel.org>
Cc:     Eric Biederman <ebiederm@xmission.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H . Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
        Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH 0/2] kexec: Remove unnecessary arch hook
Message-ID: <Y6AML4BGQgeiwJ/j@MiWiFi-R3L-srv>
References: <Y52Qg8OvU1UsGZGC@MiWiFi-R3L-srv>
 <20221217155842.GA389338@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221217155842.GA389338@bhelgaas>
Precedence: bulk

On 12/17/22 at 09:58am, Bjorn Helgaas wrote:
> On Sat, Dec 17, 2022 at 05:48:51PM +0800, Baoquan He wrote:
> > On 12/15/22 at 12:23pm, Bjorn Helgaas wrote:
> > > From: Bjorn Helgaas <bhelgaas@google.com>
> > > 
> > > There are no arch-specific things in arch_kexec_kernel_image_load(), so
> > > remove it and just use the generic version.
> > 
> > I ever posted below patch to do the same thing, Andrew only picked the
> > memory leak fixing patch.
> > 
> > [PATCH v2 2/2] kexec_file: clean up arch_kexec_kernel_image_load
> > https://lore.kernel.org/all/20220223113225.63106-3-bhe@redhat.com/T/#u
> 
> Indeed!  Sorry, I wasn't aware of your previous work.  If you repost
> it, cc me and I'll be glad to help review it.

Sure, I will repost the patch for reviewing, thanks a lot.

> 
> > > Bjorn Helgaas (2):
> > >   x86/kexec: Remove unnecessary arch_kexec_kernel_image_load()
> > >   kexec: Remove unnecessary arch_kexec_kernel_image_load()
> > > 
> > >  arch/x86/include/asm/kexec.h       |  3 ---
> > >  arch/x86/kernel/machine_kexec_64.c | 11 -----------
> > >  include/linux/kexec.h              |  8 --------
> > >  kernel/kexec_file.c                |  6 +++---
> > >  4 files changed, 3 insertions(+), 25 deletions(-)
>