Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 19 Dec 2022 14:41:07 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Li zeming <zeming@nfschina.com>, mchehab@kernel.org,
        hverkuil-cisco@xs4all.nl, nicolas.dufresne@collabora.com
Cc:     linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] v4l2-core: v4l2-h264: check after increasing memory
 allocation
Message-ID: <Y6AVkwh+V/PjzIfK@debian.me>
References: <20221219033712.3270-1-zeming@nfschina.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="pKLsL9cNsnMmaJug"
Content-Disposition: inline
In-Reply-To: <20221219033712.3270-1-zeming@nfschina.com>
Precedence: bulk


--pKLsL9cNsnMmaJug
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Dec 19, 2022 at 11:37:12AM +0800, Li zeming wrote:
> The pointer *out_str adds judgment and should help with program robustnes=
s.
>=20

Terminology: if[-else] blocks are conditionals, not judgements.

> diff --git a/drivers/media/v4l2-core/v4l2-h264.c b/drivers/media/v4l2-cor=
e/v4l2-h264.c
> index 72bd64f65198..934aba539332 100644
> --- a/drivers/media/v4l2-core/v4l2-h264.c
> +++ b/drivers/media/v4l2-core/v4l2-h264.c
> @@ -305,6 +305,8 @@ static const char *format_ref_list_p(const struct v4l=
2_h264_reflist_builder *bui
>  	int n =3D 0, i;
> =20
>  	*out_str =3D kmalloc(tmp_str_size, GFP_KERNEL);
> +	if (!*out_str)
> +		return NULL;

Why did you add the check beside robustness?

Thanks.=20

--=20
An old man doll... just what I always wanted! - Clara

--pKLsL9cNsnMmaJug
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCY6AViwAKCRD2uYlJVVFO
o/t0AQCwcopw+TXZljE09jvLgDqqoeetJNthp3jE/EGMTsGsPgD/cBHqoyPpfbBn
ULgc5x/oOTjP9V3QOu9umw36f75TIAM=
=wTM6
-----END PGP SIGNATURE-----

--pKLsL9cNsnMmaJug--