Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 19 Dec 2022 10:07:34 +0000
From:   Mel Gorman <mgorman@techsingularity.net>
To:     Lorenzo Stoakes <lstoakes@gmail.com>
Cc:     Matthew Wilcox <willy@infradead.org>, linux-mm@kvack.org,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org,
        Andrey Konovalov <andreyknvl@gmail.com>,
        Ingo Molnar <mingo@kernel.org>, Marco Elver <elver@google.com>,
        Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH] mm: remove unused alloc_pages_bulk_list()
Message-ID: <20221219100734.jag6zejp4tug77yq@techsingularity.net>
References: <20221217001554.554913-1-lstoakes@gmail.com>
 <Y51L496TjNuiSxsG@casper.infradead.org>
 <Y51/Mt70d++6Zzzq@lucifer>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <Y51/Mt70d++6Zzzq@lucifer>
Precedence: bulk

On Sat, Dec 17, 2022 at 08:34:58AM +0000, Lorenzo Stoakes wrote:
> + Mel
> 
> On Sat, Dec 17, 2022 at 04:56:03AM +0000, Matthew Wilcox wrote:
> > I think we're waiting to see if any users show up.  It's only been 18
> > months or so, so perhaps wait a little longer?
> 
> Apologies, I should have researched the background of this further. I see it was
> added speculatively in 0f87d9d30f.
> 
> > Also, if we do get rid of this, then __alloc_pages_bulk() can lose
> > the "list" argument.
> 
> Ack. Will do a v2 if Mel feels it's appropriate to remove at this stage,
> otherwise we can drop the idea and wait for users to emerge.

I reckon we should give it another few months until May. There has been
one user recently that tried to use list but it turned out arrays were
more appropriate.

-- 
Mel Gorman
SUSE Labs