Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6fe62fbc-c666-8163-5cd2-6bac5447546f@amperemail.onmicrosoft.com>
Date:   Mon, 19 Dec 2022 17:12:29 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.5.1
Subject: Re: [PATCH] USB: gadget: Add ID numbers to configfs-gadget driver
 names
Content-Language: en-US
To:     Alan Stern <stern@rowland.harvard.edu>
Cc:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Chanh Nguyen <chanh@os.amperecomputing.com>,
        OpenBMC Maillist <openbmc@lists.ozlabs.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Dan Vacura <w36195@motorola.com>,
        Jakob Koschel <jakobkoschel@gmail.com>,
        Vijayavardhan Vennapusa <vvreddy@codeaurora.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Open Source Submission <patches@amperecomputing.com>,
        Frank Li <Frank.Li@nxp.com>, Rondreis <linhaoguo86@gmail.com>
References: <20221213041203.21080-1-chanh@os.amperecomputing.com>
 <720b814d-5102-04d3-4938-33a25e87a46d@wanadoo.fr>
 <6044a542-fbcd-0fe7-abd3-83f38b731ecc@amperemail.onmicrosoft.com>
 <Y5nqtYa9yC8YY839@rowland.harvard.edu>
From:   Chanh Nguyen <chanh@amperemail.onmicrosoft.com>
In-Reply-To: <Y5nqtYa9yC8YY839@rowland.harvard.edu>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SmVOYWxWRDN0c1N4MVNXb20wc2ZTeXJMSEVmSDdqUUx2OHp2R3plZXM1MVRP?=
 =?utf-8?B?MStJM0Z0MXFrZGp3RWswYmhNVU92ckNXbDBGc1lVd1ZhNnVqNzBzcDFTSnVl?=
 =?utf-8?B?NUZ2ei9ESVVLT0FaZkE0Si85ZzdqSFYzNjc4b2JDbTdqVWRrU2JJeDY5bXdL?=
 =?utf-8?B?Yk01SXpzakFKczIyYm1uZUVoMVY4dXhmVGFRN1ljUWtyK0htMjhBNFZPcWJa?=
 =?utf-8?B?MWhpOEJGTnhsS29CUXgxMnNQcGZRdHo4cGlVQWtFcTFFZllOdlZ2NDhjNHdN?=
 =?utf-8?B?cHpIQXdUbjcrYnZtdVJoRFdDY1Z1NFdCdnMxWGFzRTJrMTMzRU00bFZzRUZs?=
 =?utf-8?B?bU9GbmIrYTlvTG1vV2dQWFlWdlJNaUlKUGpRRkxqVW9jOEpwVjJqc3hxQ3BP?=
 =?utf-8?B?RGZNRjljUmpVdU1Cems1VkJUeVdIRTRYZ0o4MFM1RG1yQWxaSTdmRThUMzlC?=
 =?utf-8?B?TUdqRUJINWtSS2d2MkwyQ1M0SklrR3cvdWI1QzljNHNCQUI5OExPU0lHRUor?=
 =?utf-8?B?UzdKbHZsTnpIb0tHVE5mU09xSEJrelNHR1pPc0NOS1UwZUdQQkE3R0pwWitG?=
 =?utf-8?B?NFZ4aUhUNXRlcTdvTFBMaW1POE0xalJoTGg1QUZlMHNkVG5tWVBnRW1yM0xQ?=
 =?utf-8?B?QVVUb2RSdVpMYnJ5WXMyMFlFb0JwYU5neEdGOEoxVHQwSkw3VjdaN2prUk53?=
 =?utf-8?B?Wm84bStWblRvKzYyRlN2QjE2aWtMTkUvVW5hUDV0eDJtZjJRUWRodytTR3VZ?=
 =?utf-8?B?MTFNTmVGS1Y0Z2kzZnVyWGM3YTVUc3VzTWNLc054VWJhYzlxZEdVcDlraWFF?=
 =?utf-8?B?OE5ENE10WTFkTjJPM21YK2Q0eG1TTzJiNm8relhaQ1FNMVdobEJGS3JjUGdq?=
 =?utf-8?B?ZjY1TW5WR1czQlUrUmtrbkRCY1pGczdZVjNxS0lKcTRNTVljM0l1N1dzMnRQ?=
 =?utf-8?B?MVZWanJRZVhxZkkxYXNCQ2V0MnAzQmN3VXRHQ0dUVE5KV1lwYjJWNzNhQ3dN?=
 =?utf-8?B?NkJCMk83TkRTaktzUzhDbUJLWExxVVpYWWVtZ2tKbHJUdC93OVJ2QlVQWG1C?=
 =?utf-8?B?bFNseTlUNnJmangxT3BJWXh2cVlMNytHYlhhUjhyWlVFYmt2bkpuMC9zNS9s?=
 =?utf-8?B?VkVQYW1qbERZTm9lUXRvY0RkTHFxeFBXaExsT2Y5MmlSVXd6NW84Q2hmSUVn?=
 =?utf-8?B?d3JiZ3RKN3JXdVNvRjNvRENiYld6b2FSZFVrYlp2VlhRTUlhL3dKazFEc2FR?=
 =?utf-8?B?b1pnQ3ZVeUdoZmJEM2Yydml6U0VIaFJMeFQxOC9qeVBLd0tuYmh4b0h6QnBn?=
 =?utf-8?B?VU9kK2tySXd5UTZ0MExNeEJXK2FKa0Zia3RjZTM5cTNVRnhFVzdPeUJFYjc5?=
 =?utf-8?B?U2JLM25HRjgxWCs2WTJ6TWxESHBCSFhPUEtOZmc4bHV0cEs3YkVqT2VTL3dl?=
 =?utf-8?B?MWsrTlhPYkl6YmxsQTVheE1ReUJJK3F4WFBSNzE2V2RmRjBSMUVGZDRzL3lZ?=
 =?utf-8?B?bDdNSzJoNzhpcDhZY2xpWHpyRG1mREc2YndBaDRYcE9xdnBZUTZPOEJQanBK?=
 =?utf-8?B?UEZTcTJhT1lYZW1VaXVWRWtCVjBHcERZaXJuVy9VbmxqOUxnNmVrckZTSlF1?=
 =?utf-8?B?M2VUbzQrRkJxd09OZTF4YlpRVHN4RkF2YUJsbzEwT2gyU2NKZHVybnpkNUFU?=
 =?utf-8?B?VCtWM20vVEI4ODczOFhDeDRHZlZCdjd6aEt0ZnBNd3UwMmg1bzRreWNqUVJX?=
 =?utf-8?B?WjVBRmlDSXUvcDE2cUVYaUxsRXU3bUo1QkI5WTA1YkhCclZZbEl1b0wvZWNL?=
 =?utf-8?B?YnphZjlJOHRncDdBdGhIMGlwVXo0SUVUUExoYzVpNTRESWZQNVFzRlZreFVB?=
 =?utf-8?B?QTZ6MTErVkpLNzNoMDNDTU9BWUlWa05sUmVWTG9OUkFUWHRrODgxSXJBK2NG?=
 =?utf-8?B?YnhaMHVyOG1NdWhZRkVHNWpFZitLYXZuZ09kaERBK0J1dmk0TjFnQmlsb0xn?=
 =?utf-8?B?d1FhN2s5QXlJeUVsY3l3dCtGTkgvRW81cG01SDAwYy91QlVxZ0hSR2RINm56?=
 =?utf-8?B?TnhyUXNIMWVkbUhzYjUxN2tMc3Y5ZmdZSUVDQWJLOHlIRUxuVzU5bVdydElr?=
 =?utf-8?B?V0xWUEt3My81VUgxL0Rqa3AxR0JBM25nT2NpbDlsNnplajc4VmVQRHNFY0c2?=
 =?utf-8?Q?l/FQ0UCECaLAAC0aO1wfHMA=3D?=
X-OriginatorOrg: amperemail.onmicrosoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f62dfa12-d0ae-42e4-45ca-08dae1a98f44
X-MS-Exchange-CrossTenant-AuthSource: SN6PR01MB4973.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2022 10:12:40.0841
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bb1gL11sLpBqjzx8HPdWCPEXCbrXE04pHBmuZo8w+sA75/aZlFgjMBaHx0Ul5lGkjueFZFIOXzvJFQNEk9lhc7vF39uNZ29/+56O4lFNoPwjki1kB/Kbfwy2kR5XAm11
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR01MB4611
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_INVALID,
        DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,
        HEADER_FROM_DIFFERENT_DOMAINS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 14/12/2022 22:24, Alan Stern wrote:
> [EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please be mindful of safe email handling and proprietary information protection practices.]
> 
> 
> On Wed, Dec 14, 2022 at 11:15:48AM +0700, Chanh Nguyen wrote:
> 
>> Thanks CJ for the review!
>>
>> I've made some changes as below (in gadgets_make() to remove unnecessary
>> variables) and now trying to test it as much as possible. Will re-post it as
>> v2 if looks good soon.
>>
>> static inline struct gadget_info *to_gadget_info(struct config_item *item)
>> @@ -1623,13 +1629,25 @@ static struct config_group *gadgets_make(
>>
>>       gi->composite.gadget_driver = configfs_driver_template;
>>
>> +    gi->driver_id_number = ida_alloc(&driver_id_numbers, GFP_KERNEL);
>> +    if (gi->driver_id_number < 0)
>> +        goto err;
>> +
>> +    gi->composite.gadget_driver.driver.name =
>> +                          kasprintf(GFP_KERNEL, "configfs-gadget.%d",
>> +                                    gi->driver_id_number);
>> +    if (!gi->composite.gadget_driver.driver.name)
>> +        goto out_free_driver_id_number;
>> +
>>       gi->composite.gadget_driver.function = kstrdup(name, GFP_KERNEL);
>>       gi->composite.name = gi->composite.gadget_driver.function;
>>
>>       if (!gi->composite.gadget_driver.function)
>> -        goto err;
>> +        goto out_free_driver_id_number;
> 
> This should goto out_free_driver_name.
> 

Thanks Alan! I'll update that.

> 
>>
>>       return &gi->group;
>> +
>> +out_free_driver_id_number:
>> +    ida_free(&driver_id_numbers, gi->driver_id_number);
>>   err:
>>       kfree(gi);
>>       return ERR_PTR(-ENOMEM);