Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp2419827rwj; Mon, 19 Dec 2022 04:27:53 -0800 (PST) X-Google-Smtp-Source: AA0mqf729apgpAxd2QDBd2QxQ1Omv/T7o6C33VfAWvHY+QAzrnE9x0eACZxZUvV11RBW1uVLKzM/ X-Received: by 2002:a17:907:7794:b0:798:d745:f87 with SMTP id ky20-20020a170907779400b00798d7450f87mr34313218ejc.73.1671452873068; Mon, 19 Dec 2022 04:27:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671452873; cv=none; d=google.com; s=arc-20160816; b=y+dw18qpROnui+MaimDaFOV4Z7vMeiEnQh9w7nf+snq1p2y6ctPM38lnTaf1wtrWX4 zXiQ3mtO9ZgiNzi3a6jlFwWU+9XzLDXernxej8bvP2FHt8ZAM5VW3mrGlO9MKbHfTAHk EGY3o88AkoG97GoR5wXe75p6jP+GGJwotOe+k9zVZH84cdHgUle+eb9JmBlFw8Bubyjh ti36Zi1cF3SNqsgSH/wQZ6uy/WbGzQUa3k/c5ZoZ4GZ/Wt2ABhdfjbl+QagnAS4H2qnV gzguaFYSu0pJsNowP5kJ8YuAWp7ANEAkr99e2b6leOOaAWFmWkARAA4Ogmc4gDBAqIEL MaPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=HkISUt6vSsOy7wdCVXhvt/jllyTnBCAPphXCZrHl0tY=; b=f7QIub67Gb+6QQP97FyTo1eqPxG+rBa3mMdQJRBzZqNm5M8rofSvKNeujsVIWyk4n9 AJ1XmpgRB66qK/8uNxiP7CFiTE9oGMegKOc8qddtewxm0tQ4e/pPTu11W0WtCyBCix6R SrTYbiDNEXeQfFOv4HzETa2HR023r8yKCsfcxJ3voh7/4Ci5ZiMsBKAdFqk/V7gmnE8u lWcTx+FpTt0k8jZsQl/W6RdVnfNvbL5iDLQcb7wn0XdVPklmGohqCZDC20/+/agBwUfm RsIk5fywPbwXssTYqNK73+Q8Yy4oBXVj4+i4fEcMdhFvgzAYbvByf9nvbRTL+BNVxmky qqoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=TJP867Y3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i13-20020a170906250d00b007c1946d08b7si7619964ejb.998.2022.12.19.04.27.35; Mon, 19 Dec 2022 04:27:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=TJP867Y3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231439AbiLSMRI (ORCPT + 71 others); Mon, 19 Dec 2022 07:17:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230403AbiLSMRH (ORCPT ); Mon, 19 Dec 2022 07:17:07 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43EC7E4B; Mon, 19 Dec 2022 04:17:06 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D19D260F30; Mon, 19 Dec 2022 12:17:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6615C433EF; Mon, 19 Dec 2022 12:17:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1671452225; bh=M454FZy6i6tC3jkfuZrZnI4+MIoHRKwIkb5aPX5khWQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TJP867Y3xXJhBJry1TujzcTTETk5tVlpgsMLyk+lPa7t15vG0KPLZFuUPWSVThkXS m8Vmyka1mdWx/llSH6jGqgxRQy87YTqP5cHyl42MKhsDAtZ+smq8XottR7Ya+gMenh YQKyz0rDbnk8svL6udkEtH8vXL1pByQ17V0JgI50= Date: Mon, 19 Dec 2022 13:17:02 +0100 From: Greg KH To: Marc Zyngier Cc: Sean Anderson , linux-kernel@vger.kernel.org, stable@vger.kernel.org, tglx@linutronix.de Subject: Re: [irqchip: irq/irqchip-next] irqchip/ls-extirq: Fix endianness detection Message-ID: References: <20221201212807.616191-1-sean.anderson@seco.com> <167023926482.4906.17012979311813913704.tip-bot2@tip-bot2> <8e8bfa5e-f713-4590-95db-66ed6454881b@seco.com> <9a7ef68d94e7d0ca879b9f55f7634df5@kernel.org> <3c8c4cf8-9987-31d6-a19c-c18d9f41c7c1@seco.com> <1fd422cf6f379e03949362721ad623f2@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1fd422cf6f379e03949362721ad623f2@kernel.org> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 16, 2022 at 07:23:36PM +0000, Marc Zyngier wrote: > On 2022-12-16 19:11, Sean Anderson wrote: > > On 12/16/22 13:22, Marc Zyngier wrote: > > > On 2022-12-16 16:37, Sean Anderson wrote: > > > > Hi Stable maintainers, > > > > > > > > On 12/5/22 06:21, irqchip-bot for Sean Anderson wrote: > > > > > The following commit has been merged into the > > > > > irq/irqchip-next branch of irqchip: > > > > > > > > > > Commit-ID:???? 3ae977d0e4e3a2a2ccc912ca2d20c9430508ecdd > > > > > Gitweb:??????? https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/3ae977d0e4e3a2a2ccc912ca2d20c9430508ecdd > > > > > Author:??????? Sean Anderson > > > > > AuthorDate:??? Thu, 01 Dec 2022 16:28:07 -05:00 > > > > > Committer:???? Marc Zyngier > > > > > CommitterDate: Mon, 05 Dec 2022 10:39:52 > > > > > > > > > > irqchip/ls-extirq: Fix endianness detection > > > > > > > > > > parent is the interrupt parent, not the parent of node. Use > > > > > node->parent. This fixes endianness detection on big-endian > > > > > platforms. > > > > > > > > > > Fixes: 1b00adce8afd ("irqchip/ls-extirq: Fix invalid wait > > > > > context by avoiding to use regmap") > > > > > Signed-off-by: Sean Anderson > > > > > Signed-off-by: Marc Zyngier > > > > > Link: https://lore.kernel.org/r/20221201212807.616191-1-sean.anderson@seco.com > > > > > --- > > > > > ?drivers/irqchip/irq-ls-extirq.c | 2 +- > > > > > ?1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/drivers/irqchip/irq-ls-extirq.c > > > > > b/drivers/irqchip/irq-ls-extirq.c > > > > > index d8d48b1..139f26b 100644 > > > > > --- a/drivers/irqchip/irq-ls-extirq.c > > > > > +++ b/drivers/irqchip/irq-ls-extirq.c > > > > > @@ -203,7 +203,7 @@ ls_extirq_of_init(struct device_node > > > > > *node, struct device_node *parent) > > > > > ??????? if (ret) > > > > > ??????????????? goto err_parse_map; > > > > > > > > > > -?????? priv->big_endian = of_device_is_big_endian(parent); > > > > > +?????? priv->big_endian = of_device_is_big_endian(node->parent); > > > > > ??????? priv->is_ls1021a_or_ls1043a = > > > > > of_device_is_compatible(node, "fsl,ls1021a-extirq") || > > > > > ????????????????????????????????????? > > > > > of_device_is_compatible(node, "fsl,ls1043a-extirq"); > > > > > ??????? raw_spin_lock_init(&priv->lock); > > > > > > > > This patch has made it into linux/master, but it should also get > > > > backported to 6.1. Just want to make sure this doesn't fall > > > > through the > > > > cracks, since this was a really annoying bug to deal with > > > > (causes an IRQ > > > > storm). > > > > > > If you wanted it backported, why didn't it have a Cc: stable > > > the first place? In any case, if you want a backport to happen, > > > you'll have to post that backport. > > > > Usually, anything with a Fixes: tag gets picked up. That is NEVER guaranteed at all, please use the system we have had for the past 18+ years and properly tag patches with "cc: stable" that you want applied to a stable tree. > > Actually, I was > > expecting you to submit a PR for 6.1, since this was submitted before > > that release came out. > > Expectations are better stated rather than being implicit. > > > That said, this email is "option 2" of > > Documentation/process/stable-kernel-rules.rst, so I don't think I need > > to do "option 3". > > Here's to hope! I queued it up now, thanks. greg k-h