Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 19 Dec 2022 14:16:18 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Robin Murphy <robin.murphy@arm.com>
Cc:     devicetree@vger.kernel.org, iommu@lists.linux.dev,
        Laurentiu Tudor <laurentiu.tudor@nxp.com>,
        Will Deacon <will@kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        Shawn Guo <shawnguo@kernel.org>, Li Yang <leoyang.li@nxp.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-kernel@vger.kernel.org, Michael Walle <michael@walle.cc>
Subject: Re: [RFC PATCH] arm64: dts: ls1028a: mark ARM SMMU as DMA coherent
Message-ID: <20221219121618.z3dcyob542cnmdnk@skbuf>
References: <20221208151514.3840720-1-vladimir.oltean@nxp.com>
 <2a188b8a-ab16-d5d4-ed5f-f8eec236e4ca@arm.com>
 <20221214165356.6tbzmfyoifqt4cwk@skbuf>
 <3f3112e4-65ff-105d-8cd7-60495ec9054a@arm.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3f3112e4-65ff-105d-8cd7-60495ec9054a@arm.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TKuA/lFB+j+Tah9SRljbdo3bBnM0qje4dmZQ79TcWv1YFBOYbqUqjYrFqIFZ?=
 =?us-ascii?Q?2QMoRDlxRBgFIsnB0AODptRuqvL+wrakoPg18tR0Hp80tjIse+Vtw8ZApehi?=
 =?us-ascii?Q?CgKlAGgwVxe2fIrqZVH/qH13sF7LVDlUy8uNihrkbfOrsC9y1x12BjDt+feT?=
 =?us-ascii?Q?nzPremR0rV0WsKRfEawEQlpMTml/+CjjqasX3dXrZePMvOADOins6xRWwo5Q?=
 =?us-ascii?Q?Z09r3KMVlXABtVo8L/bvP09KRHtICMvEby4RS1cFRAC6+rkbLvFDmDMkw2D/?=
 =?us-ascii?Q?otmyjtphABo18fa6CsXNhkwyNkFzTs9utm1DrNl9OJ79u932dWr5BYTnWdAE?=
 =?us-ascii?Q?A/tgc/2+v4W/vDJxs93cDpA8iziFmZV30ec13dXpbthHiR78t+2GuK9fDSr5?=
 =?us-ascii?Q?vHKaVmT9Nb+STUIRFV61lZXWfbYbB0v4WhYSX3iT2kr2oAJpqAbxF5xYlhRW?=
 =?us-ascii?Q?yIaI0tD4GLx4yKL5m1ijFNKFAwDDajsV9nJ85j9qyCA98kR5AoUDPDl3ZJE6?=
 =?us-ascii?Q?oCCVD/fvZ7qlt5rIOi9dVFOxAbfsSqh8dWES6KGhTjlLzUWjE8eoTMtVxDGt?=
 =?us-ascii?Q?ZQZYkJp0GcpNaW1W3lPpLD9JWrD6oYitqKgUcX2DHZF37n3G0sc/06RMG9MH?=
 =?us-ascii?Q?s+SvDLO/SuCbEaOFj96BFyl7OcqJvfCo0M8Lh3hZN9q1A7jbiqLo6tkiXkIb?=
 =?us-ascii?Q?c3CuOFbK1V/amKukQpPo1RzQ/knJdvS543eidBh7cHIyWkbDchjHFqk7IhUY?=
 =?us-ascii?Q?iIiqfUzPejBIGogPdM7TFSnr7GOAUUHj2Gk/JFp5d96vqjv93Kubqk31abib?=
 =?us-ascii?Q?rrSVTyY7ZHYg/JDTefQiN6mFD1Cb0TgpfWq9aG9aTJlCskL5o6Lv6Y6d+/7A?=
 =?us-ascii?Q?9DNEvwi2fprvA3dK3yCPvHJUdjNXj6eTNAPJcjtouLagrlpxEtx6bTUTDU6Z?=
 =?us-ascii?Q?f2P4C6umUu1Vxl+HvhMoLANRn4ymP7fDBmlbZhAeKLNwUmmgqJfRAB4AgBd3?=
 =?us-ascii?Q?6d5PosVVcqwIiAmKcsYC4gt3DA2Qh0v61l3IHDe8qJCvypoNWVV8Og2qgeGK?=
 =?us-ascii?Q?Ejser57MrT31gBzJvNUnQHMpYgjQHB05Y6R2ARKuVaaBGVinC/59tApfhQFE?=
 =?us-ascii?Q?g8bQ9hd2bD2senhVzhZIFAIacXDPvdXEsmCTPdz/FGj8NBdtAgPAKhU5si5q?=
 =?us-ascii?Q?uYlO8xhcJZgAZ5lVjO+5ZcKQyEhs3JFgaXyUN/PmIZPVP03mC3W5XzStMlOn?=
 =?us-ascii?Q?VVsmWDpmGQMvrhD28aBMCMjCT5+2AunzxRFCTDVNroocQsYbc2bwKGom6XUW?=
 =?us-ascii?Q?1dVnx7IwOB24nEPD+jndAVZMHQjH6XJtLF5eNcZWXl8un7Nxuw6aebi6htje?=
 =?us-ascii?Q?sdVH+YOeADNRsMDjBV8KsdfUpyrBBLX2gcOKecsDG7wkba0lwGtOXxE+L4Gk?=
 =?us-ascii?Q?tgqHlmAwBa+u1FA9/3ZQjpCWptp6RlgQETCv0htf6K2vaBVPVewgXurFKe3s?=
 =?us-ascii?Q?DxMl0J51BhAtN6mMa2uXDX7BIGCfMq2O8W/gUnAAsaIXmCDlZXgUz/06lRZN?=
 =?us-ascii?Q?06MszOOcaqBFXR1sHasxM/jtaMzhHMMj07NBHHPVANhj8PlD4ToAV0wJi08F?=
 =?us-ascii?Q?uw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bca004ba-c872-4b7f-7134-08dae1bad727
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2022 12:16:21.7761
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XshcokpHHQU1T2BzCE9QOf3vM0PDOP9TjTVzJ+lCg3YliKUYSBt9Y00sytaaFy+UMXGrKKkguUP8HuMF9tIYiw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8054
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Robin,

On Wed, Dec 14, 2022 at 08:33:10PM +0000, Robin Murphy wrote:
> > Does looking at the CTTW bit make any sense for MMU-500?
> 
> In general, yes. The result above does imply that NXP have inadvertently set
> cfg_cttw wrong. For the avoidance of doubt, here's another MMU-500 showing
> SMMU_IDR0.CTTW set:
> 
> [    3.014972] arm-smmu arm-smmu.0.auto: probing hardware configuration...
> [    3.014974] arm-smmu arm-smmu.0.auto: SMMUv2 with:
> [    3.014976] arm-smmu arm-smmu.0.auto:        stage 2 translation
> [    3.014977] arm-smmu arm-smmu.0.auto:        coherent table walk
> [    3.014979] arm-smmu arm-smmu.0.auto:        stream matching with 128 register groups
> [    3.014981] arm-smmu arm-smmu.0.auto:        128 context banks (128 stage-2 only)
> [    3.014984] arm-smmu arm-smmu.0.auto:        Supported page sizes: 0x60211000
> [    3.014986] arm-smmu arm-smmu.0.auto:        Stage-2: 48-bit IPA -> 48-bit PA

Thanks for the explanations and the patch you've sent separately.

I have a side question, why is the dev_name() of your SMMU set to
"arm-smmu.0.auto" (determined by PLATFORM_DEVID_AUTO if I'm not mistaken)?
I'm asking because I would like to study the mechanism through which
your SMMU platform device get probed, to make sure that it's not
possible, during shutdown, for both platform_driver :: shutdown()
and platform_driver :: remove() methods to get called by the driver core.
This is generally not disallowed, and even possible if the entity who
registers these platform devices has its ->shutdown() method pointing
at ->remove().