Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp2438288rwj; Mon, 19 Dec 2022 04:43:54 -0800 (PST) X-Google-Smtp-Source: AA0mqf4/vDlX1O6aWgT7LHnhSyBURQ/omgBBMlAL9BcsBcpl1gFWRa7Leu8dJMb6QftORb/jcgbn X-Received: by 2002:a17:906:668e:b0:79e:5ea1:4f9f with SMTP id z14-20020a170906668e00b0079e5ea14f9fmr34294889ejo.54.1671453834336; Mon, 19 Dec 2022 04:43:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671453834; cv=none; d=google.com; s=arc-20160816; b=hlLiA+Gv3mbVM/u3OvEf4S+RAXxPzTVuyvRGB0fThkr8X07ktVFcaz8ho+HuNcA0na NWwdq++vErYPE1od75IsXuERy4ZaoJ4ozKiERmHPKs7bOp0doPGvzPkg7mM+tbUOEmMe wH3OaFrfL3Abskkw4W4F4pt+USqqkQk0FcfkFufxX+5DKvzqCkjoE0HS9uX5gE8aCKQP jk+mBMMeBLPW/Ti5X8YwoueAzfrrPRMs1N6fgA+szPd+Dd+BwLYLZKenZePaODryZPlZ ciuqfkVKMFSC5p6uWLbw89RVy+ADQ7BeHFWlxJ2y0crCgftaPdjp8EMpEH859xDlz6d1 P6bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=XLI4Q5BF1S4Y7/1I9tMeZIh/hDmMgqL/1tXLD7cwxp4=; b=S2W0++8WgtUgnAo27+pMmzvMLcGYrppauBOK70LbNcI/invmx83jGlYW/Nh+dB/V+u SFH/2eD+zVds1btcNwCBOr/4k3RDSqq3pEGufOkoZqUVtZBStLRSVw9wlCx1gIA64RIK NBMngArA3ePFP9q6iNpYbi3kV/M48ivH3uG3EgJkUL4DIqOvTqoJN4tFnFIIJEhH0VD9 SmYrgzNlObpf2JM0zYYR0vMDhSlUNKs31lAmABfz8gvhuyL3Kx8qeyLIUbdvFO+lSU+0 qUvv6px0VkuH9OcBdU0z4TX8VXuDpNsUAvP/zJC5RmQlBMYc+jCoAcueC9eaZRbPP9mc Wv8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@igalia.com header.s=20170329 header.b="IIZ+0am/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g16-20020a1709065d1000b007f1501a8c3esi5918266ejt.511.2022.12.19.04.43.37; Mon, 19 Dec 2022 04:43:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@igalia.com header.s=20170329 header.b="IIZ+0am/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231897AbiLSMIi (ORCPT + 70 others); Mon, 19 Dec 2022 07:08:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231837AbiLSMIQ (ORCPT ); Mon, 19 Dec 2022 07:08:16 -0500 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01D83A449 for ; Mon, 19 Dec 2022 04:07:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=XLI4Q5BF1S4Y7/1I9tMeZIh/hDmMgqL/1tXLD7cwxp4=; b=IIZ+0am/AGpSBN/8WsZv+nY15m D6nCIeDL2TtuT0vFmnyOAG7RhDcFQUjUeX449QizsXNwnPMntNZRfwg/9Y3+gMwGGrj8OvDeBjtOW yjMEqoPrpu2J8GuZmee8B5+OY31HWWgFx3O+Q6H9WqnFzZPCD+fbsZcgOV26XaWykaAKXU+xoZ0iw DpJdQOBZUxjzllBGi7EkAH9X7pNaEc2/Odztg5PR2oNB8Q37Na4tX4g0/8BfQfM/41SdF1cc2KwZZ sBjmi+pX7uQqmALGQODebJ4tAygmx8fjxNokdwRkYBwIlBF3FArEag3da+2hAVs/kSp2zMCEESfpH AVK/Ac2A==; Received: from [177.34.169.227] (helo=bowie..) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1p7EvO-006HsS-GX; Mon, 19 Dec 2022 13:07:19 +0100 From: =?UTF-8?q?Ma=C3=ADra=20Canal?= To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Oded Gabbay , Jani Nikula Cc: Melissa Wen , =?UTF-8?q?Andr=C3=A9=20Almeida?= , Emma Anholt , Rodrigo Siqueira , Wambui Karuga , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Ma=C3=ADra=20Canal?= Subject: [PATCH v4 6/7] drm/vkms: use new debugfs device-centered functions Date: Mon, 19 Dec 2022 09:06:20 -0300 Message-Id: <20221219120621.15086-7-mcanal@igalia.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221219120621.15086-1-mcanal@igalia.com> References: <20221219120621.15086-1-mcanal@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Replace the use of drm_debugfs_create_files() with the new drm_debugfs_add_files() function, which centers the debugfs files management on the drm_device instead of drm_minor. Moreover, remove the debugfs_init hook and add the debugfs files directly on vkms_create(), before drm_dev_register(). Signed-off-by: MaĆ­ra Canal --- drivers/gpu/drm/vkms/vkms_drv.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c index 69346906ec81..6d3a2d57d992 100644 --- a/drivers/gpu/drm/vkms/vkms_drv.c +++ b/drivers/gpu/drm/vkms/vkms_drv.c @@ -92,8 +92,8 @@ static void vkms_atomic_commit_tail(struct drm_atomic_state *old_state) static int vkms_config_show(struct seq_file *m, void *data) { - struct drm_info_node *node = (struct drm_info_node *)m->private; - struct drm_device *dev = node->minor->dev; + struct drm_debugfs_entry *entry = m->private; + struct drm_device *dev = entry->dev; struct vkms_device *vkmsdev = drm_device_to_vkms_device(dev); seq_printf(m, "writeback=%d\n", vkmsdev->config->writeback); @@ -103,24 +103,16 @@ static int vkms_config_show(struct seq_file *m, void *data) return 0; } -static const struct drm_info_list vkms_config_debugfs_list[] = { +static const struct drm_debugfs_info vkms_config_debugfs_list[] = { { "vkms_config", vkms_config_show, 0 }, }; -static void vkms_config_debugfs_init(struct drm_minor *minor) -{ - drm_debugfs_create_files(vkms_config_debugfs_list, ARRAY_SIZE(vkms_config_debugfs_list), - minor->debugfs_root, minor); -} - static const struct drm_driver vkms_driver = { .driver_features = DRIVER_MODESET | DRIVER_ATOMIC | DRIVER_GEM, .release = vkms_release, .fops = &vkms_driver_fops, DRM_GEM_SHMEM_DRIVER_OPS, - .debugfs_init = vkms_config_debugfs_init, - .name = DRIVER_NAME, .desc = DRIVER_DESC, .date = DRIVER_DATE, @@ -202,6 +194,9 @@ static int vkms_create(struct vkms_config *config) if (ret) goto out_devres; + drm_debugfs_add_files(&vkms_device->drm, vkms_config_debugfs_list, + ARRAY_SIZE(vkms_config_debugfs_list)); + ret = drm_dev_register(&vkms_device->drm, 0); if (ret) goto out_devres; -- 2.38.1