Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp2547482rwj; Mon, 19 Dec 2022 06:06:19 -0800 (PST) X-Google-Smtp-Source: AA0mqf68B7qv1D8hBzikiSkkRGJu2pdZeoiudg/Sn2aNDxwyer4gAdpLJ0z1AbptK33qKS23GECx X-Received: by 2002:a17:906:ca18:b0:7c0:a181:90c5 with SMTP id jt24-20020a170906ca1800b007c0a18190c5mr34734086ejb.1.1671458778739; Mon, 19 Dec 2022 06:06:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671458778; cv=none; d=google.com; s=arc-20160816; b=e+jVl5CEfdUMIuffkBBe8sWiMw0q8u0Z2tJwU8ifu11rq4Hht+IoUP3/B7UO/PcRgJ Kt4DRppqP/9pgZRVa8dNZLC1lKkXoe7xAeWCn8cPNQEKqKENlzbWxagkfrZ/UPPILga9 POkIIo3xCpQxlNKR3V+clJCZxd6jl00e2Rw6dOgyy8PfSFTTRQgH7BmXYsVQGkqctemM nMIX843+WW38lgGEnvKhDyuu0Bhpmh81CuKKBYlQgHrtzEgKs+Q4gyaZJ3M/ID95SFiN hpjqnnEW7TZg0qIb8HhWeUS3Ad5AVP8ssA+HSvqF2fBIn5JUdnV7og4kw8oYnfEqDjJC JnPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :organization:references:cc:to:content-language:subject:reply-to :from:user-agent:mime-version:date:message-id:dkim-signature; bh=FcJ82GGLWcA9YJ8tR5Iaod2DuXgS0nv7MKzMcf1yMiM=; b=NE5WzrvH9lSKhhXtGcl9EX5EUi6fkr+h6Fh07dq9nUTeU3BXVvWc33JKowGp71wyb+ cu5hmm59h6hsgzr4jp3LqPDDTNCoKY2IzmH7jrUTPOibFnogheUgRl08pOr6400cEBbi vBYXN9zfh5LqRjLPmCmlMljseYmE6UJtko4Ylqu55ZW5qM6MCjiEsXpM3TDgyca/4olH Faqzbt2rYq2l5k07d4z9Ioasct9SKQB2FNTVpMguHwh9gvcUO2/TNXomdkNYWpi0las6 eke2tbuyJcEDMKxXUYeWbJcLXD4ipFVfZOKagDWJZCboKc54ll1y92VDtQgSoaFZcFvU QR5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=okHBtBIh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e22-20020a17090658d600b008045639b422si4248290ejs.720.2022.12.19.06.06.00; Mon, 19 Dec 2022 06:06:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=okHBtBIh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231586AbiLSNn1 (ORCPT + 70 others); Mon, 19 Dec 2022 08:43:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231453AbiLSNnY (ORCPT ); Mon, 19 Dec 2022 08:43:24 -0500 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E50A8F03C for ; Mon, 19 Dec 2022 05:43:21 -0800 (PST) Received: by mail-wm1-x329.google.com with SMTP id bg10so6444824wmb.1 for ; Mon, 19 Dec 2022 05:43:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=FcJ82GGLWcA9YJ8tR5Iaod2DuXgS0nv7MKzMcf1yMiM=; b=okHBtBIhbvCRep+pxNLz9lBYrDAmFORXzEx6qK8V0FRSuRR0jezAYYpXAzZTwxe3qj gETGKsaOF6cK37DyiAQp8BOkWzIgFzepwajcjCqCT8hfhnnJBEFMoQrBGdIxO2K6BVSd lkxt0flRjnIPfe7A1RKSfqQbMe2pwzRh9X06sAChU5eeyiHqRH/hZXDDgVsow7nHlAR5 p1r6/UUrkupYkijuId+Vll4GwY04Dmr6BzhC6oGs95yAV75N90ZxyKpoVvjRNUhnVIW2 Kw4OLsGqNuqB/cdGTu4Lq9+ecqa1m2xQ4iHqwU5/Jai1D2LsRk3WoxDruckJ2S62PmPJ vltA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FcJ82GGLWcA9YJ8tR5Iaod2DuXgS0nv7MKzMcf1yMiM=; b=R2ToOe5BPayX2OijjPyHqJyEYPHxeBP+PAxCp+WJlGgG8lUMaefJD55zd0yEpyiCOr LHYxDO7xGTYoNXFJLz3As8Z4foZapUBcGW6b2BRyPaJROZF27UeEyhu6jAq4PjOA9b1d n/xvN0TDAreVseFlhYEBTIqo+KiHoGccn7+2+RSSh6HuU10eYPkb/YjWpvlLLtBH/4c/ OFSkZlnIHALLEa+pFzktoKHss71/f7z9POBdfreEF/IZdiFdvEdpWl9P9fMU+WRmHqDh iju38MrAO3Xd0QH42sAC751mwdTUqesGoWcEv/gJdNFFYeeEYdj8YagIigkB26z2I4uj U1vg== X-Gm-Message-State: ANoB5pmcVrH2n6/mRuzB33Sodc9qclqXBi/OMuWOgzRoLzauvus6CGL3 AQko+BFruZcXhaIxt4Jgdu0KpA== X-Received: by 2002:a05:600c:5570:b0:3d1:ee6c:f897 with SMTP id ja16-20020a05600c557000b003d1ee6cf897mr32073903wmb.3.1671457400483; Mon, 19 Dec 2022 05:43:20 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:976a:eb00:7b11:28de? ([2a01:e0a:982:cbb0:976a:eb00:7b11:28de]) by smtp.gmail.com with ESMTPSA id f9-20020a05600c154900b003b49bd61b19sm17513376wmg.15.2022.12.19.05.43.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Dec 2022 05:43:20 -0800 (PST) Message-ID: <19de9bfc-2012-451d-f5d1-59a04ea9d813@linaro.org> Date: Mon, 19 Dec 2022 14:43:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v4 0/2] Make ILI9486 driver working with 16-bits SPI controllers Content-Language: en-US To: Carlo Caione , Kevin Hilman , Jerome Brunet , Mark Brown , Daniel Vetter , David Airlie , Kamlesh Gurudasani , Martin Blumenstingl Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org References: <20221116-s905x_spi_ili9486-v4-0-f86b4463b9e4@baylibre.com> Organization: Linaro Developer Services In-Reply-To: <20221116-s905x_spi_ili9486-v4-0-f86b4463b9e4@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kamlesh, On 19/12/2022 10:02, Carlo Caione wrote: > This patchset is trying to fix problems seen on S905X boards when interfacing > with an ILI9486 equipped SPI panel. I fully reviewed both patches, but I'd like a review from the maintainer, can you have a look ? Thanks, Neil > > To: Kamlesh Gurudasani > To: David Airlie > To: Daniel Vetter > To: Mark Brown > To: Neil Armstrong > To: Kevin Hilman > To: Jerome Brunet > To: Martin Blumenstingl > Cc: dri-devel@lists.freedesktop.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-amlogic@lists.infradead.org > Signed-off-by: Carlo Caione > > --- > Changes in v4: > - Removed NAK-ed patch from patchset > - Link to v3: https://lore.kernel.org/r/20221116-s905x_spi_ili9486-v3-0-59c6b58cbfe3@baylibre.com > > Changes in v3: > - Added trailers > - Added new patch to use drm_aperture_remove_framebuffers() > - Link to v2: https://lore.kernel.org/r/20221116-s905x_spi_ili9486-v2-0-084c6e3cd930@baylibre.com > > Changes in v2: > - Removed SPICC patch > - Reworked commit message > - Link to v1: https://lore.kernel.org/r/20221116-s905x_spi_ili9486-v1-0-630401cb62d5@baylibre.com > > --- > Carlo Caione (2): > drm/tiny: ili9486: Enable driver module autoloading > drm/tiny: ili9486: Do not assume 8-bit only SPI controllers > > drivers/gpu/drm/tiny/ili9486.c | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > --- > base-commit: 84e57d292203a45c96dbcb2e6be9dd80961d981a > change-id: 20221116-s905x_spi_ili9486-aed54ff3cb21 > > Best regards,