Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 19 Dec 2022 21:04:02 +0530
From:   Siddh Raman Pant <code@siddh.me>
To:     "Thomas Zimmermann" <tzimmermann@suse.de>
Cc:     "maarten lankhorst" <maarten.lankhorst@linux.intel.com>,
        "maxime ripard" <mripard@kernel.org>,
        "david airlie" <airlied@gmail.com>,
        "daniel vetter" <daniel@ffwll.ch>,
        "dri-devel" <dri-devel@lists.freedesktop.org>,
        "linux-kernel" <linux-kernel@vger.kernel.org>
Message-ID: <1852b054022.16e87c6b116450.6116081892972417758@siddh.me>
In-Reply-To: <0693327a-4951-6864-12c6-88cfe81abd12@suse.de>
References: <20221219142319.79827-1-code@siddh.me> <0693327a-4951-6864-12c6-88cfe81abd12@suse.de>
Subject: Re: [PATCH] drm: Replace DRM_INFO() with pr_info()
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Importance: Medium
User-Agent: Zoho Mail
Precedence: bulk

On Mon, 19 Dec 2022 20:27:45 +0530, Thomas Zimmermann wrote:
> Hi
> 
> Am 19.12.22 um 15:23 schrieb Siddh Raman Pant:
> > Line 536 of drm_print.h says DRM_INFO() is deprecated
> > in favor of pr_info().
> 
> That's a misleading comment. DRM_INFO() is deprecated for drm_info(). 
> pr_info() et al is only to be used of you don't have a dev pointer.
> 
> Best regards
> Thomas

Maybe you are confusing it with DRM_DEV_INFO? It takes the dev pointer,
and is indeed told to be deprecated in favour of drm_info() in the
comments (see line 394).

DRM_INFO is a separate macro for printing stuff, and does not take the
dev pointer. They seem to be early wrappers for printk, I guess when
pr_info did not exist. And all they do different from pr_info is to add
DRM_NAME (which seems to be just "drm") in front of the string.

Thanks,
Siddh