Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932733AbXHPHwX (ORCPT ); Thu, 16 Aug 2007 03:52:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756590AbXHPHwO (ORCPT ); Thu, 16 Aug 2007 03:52:14 -0400 Received: from mga03.intel.com ([143.182.124.21]:65402 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755953AbXHPHwN (ORCPT ); Thu, 16 Aug 2007 03:52:13 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.19,270,1183359600"; d="scan'208";a="263884091" Subject: Re: [PATCH 0/3] x86_64 EFI runtime service support From: "Huang, Ying" To: Andrew Morton Cc: Andi Kleen , "Eric W. Biederman" , Chandramouli Narayanan , linux-kernel@vger.kernel.org, "H. Peter Anvin" In-Reply-To: <20070815161642.1bfbbe9c.akpm@linux-foundation.org> References: <1186990219.22431.37.camel@caritas-dev.intel.com> <20070815161642.1bfbbe9c.akpm@linux-foundation.org> Content-Type: text/plain Content-Transfer-Encoding: 7bit Date: Thu, 16 Aug 2007 15:52:29 +0800 Message-Id: <1187250749.15063.3.camel@caritas-dev.intel.com> Mime-Version: 1.0 X-Mailer: Evolution 2.10.2 X-OriginalArrivalTime: 16 Aug 2007 07:52:00.0605 (UTC) FILETIME=[53DAA0D0:01C7DFDA] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2643 Lines: 65 On Thu, 2007-08-16 at 07:16 +0800, Andrew Morton wrote: > On Mon, 13 Aug 2007 15:30:19 +0800 > "Huang, Ying" wrote: > > > Following sets of patches add EFI/UEFI (Unified Extensible Firmware > > Interface) runtime services support to x86_64 architecture. > > OK, we have a major trainwreck when these patches meet Peter's > get-newsetup.patch. > > I'm halfway into fixing it when I see this. You have: > > #define SYS_DESC_TABLE (*(struct sys_desc_table_struct*)(PARAM+0xa0)) > +#define EFI_LOADER_SIG ((unsigned char *)(PARAM+0x1c0)) > +#define EFI_MEMDESC_SIZE (*((unsigned int *) (PARAM+0x1c4))) > +#define EFI_MEMDESC_VERSION (*((unsigned int *) (PARAM+0x1c8))) > +#define EFI_MEMMAP_SIZE (*((unsigned int *) (PARAM+0x1cc))) > +#define EFI_MEMMAP (*((unsigned long *)(PARAM+0x1d0))) > +#define EFI_SYSTAB (*((unsigned long *)(PARAM+0x1d8))) > #define MOUNT_ROOT_RDONLY (*(unsigned short *) (PARAM+0x1F2)) > > But Peter's include/asm-i386/bootparam.h has: > > struct efi_info { > u32 _pad1; > u32 efi_systab; > u32 efi_memdesc_size; > u32 efi_memdesc_version; > u32 efi_memmap; > u32 efi_memmap_size; > u32 _pad2[2]; > }; > > /* The so-called "zeropage" */ > struct boot_params { > struct screen_info screen_info; /* 0x000 */ > struct apm_bios_info apm_bios_info; /* 0x040 */ > u8 _pad2[12]; /* 0x054 */ > struct ist_info ist_info; /* 0x060 */ > u8 _pad3[16]; /* 0x070 */ > u8 hd0_info[16]; /* obsolete! */ /* 0x080 */ > u8 hd1_info[16]; /* obsolete! */ /* 0x090 */ > struct sys_desc_table sys_desc_table; /* 0x0a0 */ > u8 _pad4[144]; /* 0x0b0 */ > struct edid_info edid_info; /* 0x140 */ > struct efi_info efi_info; /* 0x1c0 */ > u32 alt_mem_k; /* 0x1e0 */ > > So for example, Peter has memdesc_size at 0x1c8 and you have it at > 0x1c4. > > I'll give up and will drop the EFI patches. I'd suggest that you work > with > Peter on getting these patches integrated. > OK, I will work with Peter to solve the problem. Best Regards, Huang Ying - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/