Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9198499b-8bfc-6405-e6a9-00af6f28e506@intel.com>
Date:   Mon, 19 Dec 2022 13:24:30 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH v1] iavfs/iavf_main: actually log ->src mask when talking
 about it
Content-Language: en-US
To:     Daniil Tatianin <d-tatianin@yandex-team.ru>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>
CC:     Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Harshitha Ramamurthy <harshitha.ramamurthy@intel.com>,
        Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
        <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20221216091326.1457454-1-d-tatianin@yandex-team.ru>
From:   Tony Nguyen <anthony.l.nguyen@intel.com>
In-Reply-To: <20221216091326.1457454-1-d-tatianin@yandex-team.ru>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eUpRMjNYYVBZLzAyUkdwZUpoY2EyZWdjdi9TbW1BNmhhZ294bDVoSklJa3hD?=
 =?utf-8?B?Tk1aU1NrZGlFNVhQQlhOYzZzdVhnOHNtZUJNLzdQWHZuL00zUDhxazU1eFI3?=
 =?utf-8?B?RTlKdnhhNHdiWFdlQWJoNnhqVUhDODNkSGZseW9CWWhVZklGQU9WTktnd1Jm?=
 =?utf-8?B?Wm5qUTNCL2NURzE3bGExVFNwYmJ4VHdkczkxeFVFMTJWMHQxYXUyLzVzYktJ?=
 =?utf-8?B?NHJGb01zOG1tK0I4dlV2UlQ3WDk5NzZLRW91bDh3c3ZlRXM4VDAzTzJwVjBG?=
 =?utf-8?B?QlFOM1drWTl1blUwN2liRTVKYmhzd1pyVXM0VlVGNXAxd1pZVVVSZkcvKzZq?=
 =?utf-8?B?VHJwNnd5OElIWG9nMndQV3lFd21MTXFhS2QvMU9wTFpmY0VFQ3NGQlNFTGpN?=
 =?utf-8?B?SHp1TDFJS3kyWmZ3L1JWMGdGSEN0YWNqWGt6eWdpeCt1M09OaVdURm9lSkIx?=
 =?utf-8?B?Ry9haDlFNDFMWkJmRnpGNXJKOFJGamswUFRyUE50R0NzOVhnNEl0T1Vtbk1s?=
 =?utf-8?B?R052MmlMYjBOaWxrR0p5TGxoOFc5Z3Q5VUdNdUg0MXlxQmw1YkFtRWRod3dY?=
 =?utf-8?B?NWlodnJMRWJKcVg0UE1JeHNCVWdlSHBzb1ZmRnRNNXVNY0VLYTRobjlnUEwv?=
 =?utf-8?B?d2ZqUFpHRlBzQUEzVEljQkY3dkNoUVlsekVhd3JOUVFIUmp0M2doaXNVc21x?=
 =?utf-8?B?eCsrR3AyMWZVQi8rYTdqOUo4cjNPZWphdW5pSGxQcjh1b25xU3ZEUTBRaXlE?=
 =?utf-8?B?VVo4dEZvdDhVV29Ncm9MZGx4Q0pDR1A1QnlzZVU5eEhvNEd2bnJ1L2VPQUtz?=
 =?utf-8?B?RXpOMUNDcVhCb24rVkpQb0JvcHIvVllpd3NTRlRlbk0yb1ZldG1hNitmV2V3?=
 =?utf-8?B?OTJEUTdzNkpqNE5vQ3p5SlNWRGJOSVJ6aFJUNnBRbE4wRjgva2JrbkZqRXZM?=
 =?utf-8?B?cXFxMU9EWTlubmxab3BReTV1TnFuTGpHRjNaRFJIYkZyZkcrNFZ1T1Yyd3dl?=
 =?utf-8?B?NzZRUlVOL2MxbTNHUEYyK2hkZTBaWTJyY3UrbXVxMkoxYUFtR2tUazc5SHpu?=
 =?utf-8?B?NlJYNjlMYlBPcnYyUThSbkFtS1lEMGF5dEo5ako1REo3OGxqMmhnTm1vQklG?=
 =?utf-8?B?QUhlVmVQRi9PMUl3Q3B3dnl2Q3E1VEZsaTljV3RoSGRjZnRvYjZJVDJDMFBt?=
 =?utf-8?B?eGh3a0VuZUJBd2lCME41VVl1VGZmMGJGVy82UzVabDRpL1dEQVNnZkt5L1VY?=
 =?utf-8?B?YVpNTEp1QzZLaWVxS0E1a1dmT1pTS1NTcWFMeVJSa3F3emVKZURqSmFaVWlI?=
 =?utf-8?B?akN4YVNVcG1sKzFMYTZtcC8rUVVqTHl1Vm5CZTBXUlY4dEpYNGkyWWtmS3hV?=
 =?utf-8?B?RCtJVnF5STRYY0pnZFM2Q2VIajJZWnhVUUFyWXpaZk5ZMkgwYzA2NXR2b3N3?=
 =?utf-8?B?NWZaZUJHNmw0c1VHdHdHRmR0WVpVTjRSWTEyTEQzRGVTQ3ppazRHZXFkUWxI?=
 =?utf-8?B?QTBuSytNZFlGTWtpWW9peW1wcEdtczd1VFcwcm9FNFR5cFQrQnp3OHFHYzJF?=
 =?utf-8?B?TFlpaWIyU3NZTUNiQ3VhNklqOElmT3NINE40OEthZ0k1TkNBRCtXVzlTTk5T?=
 =?utf-8?B?S1dxd0o1djFpWEZjZkhnb2ZUNTNOQjdDMWRnWUhzTmx2MWVBU2ZTYmVCMHlO?=
 =?utf-8?B?QStVTlhwY3hNbmhlOXRCYmswUzZwNFFEaEhIU3Y4UzlDdngzdTFGU2NJKzRs?=
 =?utf-8?B?V08wbkhScnlHcHpJS2w0WWJZbEc4U2NVZGFIa0E2UkVIT2M0T1dTYmh4aWR3?=
 =?utf-8?B?TmJnTVdEYmEwSHVjY2k4M1JKUExwNUJuUmc5SXZCN0J0QnpxUklseVZPKzZu?=
 =?utf-8?B?RGUzcUw4TnMwOVdjZWEyaDB6QzJXYzhSaDBFT20zM3Y1ZU5xOGNwcFkxTjda?=
 =?utf-8?B?UXJkZDF5ZzF2b3FlSUtINHRGOWQ3YXg5T0k1S2ZSbWhYTXhzVFFNbk5STkcw?=
 =?utf-8?B?L0UwNzhyMkxvZFY1QmVSUm1nRm90aWhzZldBbXJadFJ4R280cXJVWmt0b3ZR?=
 =?utf-8?B?bjFKZ1RqbU9YcGxtMlpZUXdOU2xYZXBlaDlXV1ptSjdEaDJZM2tIODJMRU0w?=
 =?utf-8?B?bkFNcExQV0xhbmtuUDRjbSsrWGVUbGZJeW5WUXMvR0tYNXg1NHU1RHJNVGEx?=
 =?utf-8?B?aUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ed8152b9-afcb-4992-392a-08dae2076c15
X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3229.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2022 21:24:33.4356
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aHI05apzoF7WW/r+sy1iYM6fuxAzPno4RjgBFmCjfh+oTL6EwDIrnhVlg4d13lbelrVGUrdxqhwcSkdWPkZtp0casG4fd4JVTRby/LcGrxs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7787
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/16/2022 1:13 AM, Daniil Tatianin wrote:

A couple of nits.

For the title, s/iavfs/iavf

> This fixes a copy-paste issue where dev_err would log the dst mask even
> though it is clearly talking about src.
> 
> Found by Linux Verification Center (linuxtesting.org) with the SVACE
> static analysis tool.
> 
> Fixes: 0075fa0fadd0a ("i40evf: Add support to apply cloud filters")

This should just be 12 chars:

WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> 
("<title line>")' - ie: 'Fixes: 0075fa0fadd0 ("i40evf: Add support to 
apply cloud filters")'

> Signed-off-by: Daniil Tatianin <d-tatianin@yandex-team.ru>
> ---
>   drivers/net/ethernet/intel/iavf/iavf_main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
> index c4e451ef7942..adc02adef83a 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
> @@ -3850,7 +3850,7 @@ static int iavf_parse_cls_flower(struct iavf_adapter *adapter,
>   				field_flags |= IAVF_CLOUD_FIELD_IIP;
>   			} else {
>   				dev_err(&adapter->pdev->dev, "Bad ip src mask 0x%08x\n",
> -					be32_to_cpu(match.mask->dst));
> +					be32_to_cpu(match.mask->src));
>   				return -EINVAL;
>   			}
>   		}