Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp3211299rwj; Mon, 19 Dec 2022 14:53:28 -0800 (PST) X-Google-Smtp-Source: AA0mqf402BPbkZCoQA15vzfKo9Cf2PEp8YY3jqSomKu47MfIISqhMvorkQTiiMfn2K72Gxr0s5cM X-Received: by 2002:a05:6a21:6d9c:b0:aa:4010:2789 with SMTP id wl28-20020a056a216d9c00b000aa40102789mr67585908pzb.53.1671490408198; Mon, 19 Dec 2022 14:53:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671490408; cv=none; d=google.com; s=arc-20160816; b=wUc96VIdeqPIpzQZeFCr38StzRtgZp7XMuL/K6OT0a5H8jFQv1wQEhEZYtwarnz7++ H/7dTTD0QKzITvEPE7Dl76+u4N3svSmUptijcqA+/eSAxfCm+GvLYQT5Qv7Uf3mIEyB6 c9Hksi3x5qnCwK/JYEYLhZwKQfpRxAyjl+gHzPM26oL4ZJgBM+YYEWqeci9JeYvAp99/ aMQq2kHri8BXstYn/TIP/yI5TsQH62Gp5bPagC4O4O0XyP1D55GI6HAYaETScnYCCtCV 00HWT0zuu1jPAFKNtvjKFdBaIOVC8EqgOPmi7TAtGsL913EGKbikYR/uQvi9u9gW8OGg Rh6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=2DLgRxkuY2I8K4QTeN46X8kdGgp55C0GtJzNVnKN7PU=; b=XAwnB05eXcNYXqz31aWrn7xiPmxQeKUGJ5k0CuIp/GK2IYjIfsHh+a8TCIM3nDhyhZ 6DfvHOOdQmAyoTVizoY1N0UtxGhQcfPkD7KgP7Hw10M2TwMi5eWf9y3bEl5ComM8zV0W pl9lQqz50xozKg6TwMtxEf3RydMlQ3jXcRqbX/3H75Rx5S/Lh/DEzcL42tZCzqHJNytj Iq7GSJMzZhcjD9g5mR/BwTueXtW7ginvdIU/Gmzy2m1xcXlkdyOJuamWnsSGB0dBml1k 0Ychb+fE94cMTRJNhu7PpXxOOYkWQXrA9z2Kg9bqqinm5IQJPqJp/tdNHT4RK8p7wgdK 2Y0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=lpbVP7fJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u17-20020a17090341d100b0018994e35cbfsi12960330ple.364.2022.12.19.14.53.18; Mon, 19 Dec 2022 14:53:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=lpbVP7fJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232394AbiLSWm5 (ORCPT + 71 others); Mon, 19 Dec 2022 17:42:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229489AbiLSWmz (ORCPT ); Mon, 19 Dec 2022 17:42:55 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04FE113F36; Mon, 19 Dec 2022 14:42:55 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 797E961184; Mon, 19 Dec 2022 22:42:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 362ACC433EF; Mon, 19 Dec 2022 22:42:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1671489773; bh=BGre2r5SHKHnb8b4Q50Q+a/dxymK6XCdQgeYGSWrbak=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lpbVP7fJ/uOaGEd9aeQZ3P2o/kt4VheUXmT+dpCikhKJTLyA5nZhN69lTh+1W5j/d qcDyiIudJ3f7/d8OI3zQmbTIiBqFrdiZTeEfCcpiXrHtRWQxjBK5P9AVk4mTHu/NqH JSYoHx0maXMcg7CuyoiiZnQARL/sW0ZOGa8qWNEY= Date: Mon, 19 Dec 2022 14:42:52 -0800 From: Andrew Morton To: Michal Hocko Cc: Mina Almasry , Tejun Heo , Zefan Li , Johannes Weiner , Jonathan Corbet , Roman Gushchin , Shakeel Butt , Muchun Song , Huang Ying , Yang Shi , Yosry Ahmed , weixugc@google.com, fvdl@google.com, bagasdotme@gmail.com, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] Revert "mm: add nodes= arg to memory.reclaim" Message-Id: <20221219144252.f3da256e75e176905346b4d1@linux-foundation.org> In-Reply-To: References: <20221202223533.1785418-1-almasrymina@google.com> <20221216101820.3f4a370af2c93d3c2e78ed8a@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 17 Dec 2022 10:57:06 +0100 Michal Hocko wrote: > > I think it's a bit premature to revert at this stage. Possibly we can > > get to the desired end state by modifying the existing code. Possibly > > we can get to the desired end state by reverting this and by adding > > something new. > > Sure if we can converge to a proper implementation during the rc phase > then it would be ok. I cannot speak for others but at least for me > upcoming 2 weeks would be mostly offline so I cannot really contribute > much. A revert would be much more easier from the coordination POV IMHO. > > Also I do not think there is any strong reason to rush this in. I do not > really see any major problems to have this extension in 6.2 I'll queue the revert in mm-unstable with a plan to merge it upstream around the -rc5 timeframe if there hasn't been resolution. Please check Mina's issues with this revert's current changelog and perhaps send along a revised one.