Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <01480f4e-9ca6-50bd-6a95-b2e61834d2e4@amd.com>
Date:   Mon, 19 Dec 2022 17:29:34 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH v8 11/13] Documentation: introduce amd pstate active mode
 kernel command line options
Content-Language: en-US
To:     Perry Yuan <perry.yuan@amd.com>, rafael.j.wysocki@intel.com,
        ray.huang@amd.com, viresh.kumar@linaro.org
Cc:     Deepak.Sharma@amd.com, Nathan.Fontenot@amd.com,
        Alexander.Deucher@amd.com, Shimmer.Huang@amd.com,
        Xiaojian.Du@amd.com, Li.Meng@amd.com, wyes.karny@amd.com,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20221219064042.661122-1-perry.yuan@amd.com>
 <20221219064042.661122-12-perry.yuan@amd.com>
From:   "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <20221219064042.661122-12-perry.yuan@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R3lKNVIzVGRzWEhiajN6Ynh4Y2U4U2x3YS8ybWFaYjRWMGZDWTZBMUFqT3BD?=
 =?utf-8?B?UDZNSDRPU25XbGZOK0V1eDFVdkVvbXRDNkV0Ujdic1RYYm1EaUdReW9lSXB3?=
 =?utf-8?B?THprQlAzYThudCtQbG5aMVMxNGZrdTBOREpkOEdpZi82RjRpWUlxNjFHMXA3?=
 =?utf-8?B?d041VVBnSG5Gc1p4VndLS1pORWoyRmw5RFFCVlhHZHVaaDFscXhqQ2NBT0t5?=
 =?utf-8?B?Z0o2dU5wRTdXMDBrUDQ1dVI0VmtrWTlMSEhVOWNlUkVxUUpRb0ZQUjBpdysr?=
 =?utf-8?B?clNiSTY3ZTJqbG91RytHTFZVQllTazZZMGhoL2lCMVhiQzh3WTJmSjgrVXJK?=
 =?utf-8?B?RzFsSFg2dzJSczRiVnlzUlVCYzdvbzF0VmgzTXFYbXZtRnFIbzFPK1FxclE5?=
 =?utf-8?B?UjU5UWMxNERNM1NtYmdwcEs1ZWhBSk9RREJwcHEwL0IxK0NjUy9yZUR6VWI5?=
 =?utf-8?B?aWd0V3lLM3Ntc2tuWlNwUzZKODNaV3FIYnBOUWJxdWJoWDBPOFpzMEZrdmZS?=
 =?utf-8?B?VWRKV2cvQURmUkE2bnpKVHlHM3pVczJHbk5Cd01aZ1Y5NXZBZmczWi9wQkRM?=
 =?utf-8?B?cGloZ3A3YVZ4MWF5RzlONFdEWHRkQjhCS1huOWh1QTMzWmRZa2Q0SGpPcWFn?=
 =?utf-8?B?eWdqZkl0cjZ4RUZkTnR5SlZqejZnVWY3ZnZ1NU5YUjdPbVdkS0s3Rit3R1I4?=
 =?utf-8?B?VXA3Nm5Na2xWSVd5VEhJVWtvZkIwSVVSZklac1Fac1hkMjFkMVp4ajR3MkMz?=
 =?utf-8?B?VEMwaWpoWW5uWTIwL01EZjZ1dzJZbXpiWjRwd3UxaXUxSU9GZHNnbHEvN2lU?=
 =?utf-8?B?dFdOREtpSHJzMnZjTmFuMkRmQUtNVGZrYjFyMDI5VXZFRjFudVlXV01hVlBw?=
 =?utf-8?B?UGs0MTdjT2hBeHByYnJkaWo5Sk8zNGNJUWRZbnl1SklqVnQ4MUFZdWJ2ZzY5?=
 =?utf-8?B?clh4RllQM1kzb3dQbVRnMzlaNDIxUndGM3UyQndHNGhzOUF6ZXgrNTlYTVRU?=
 =?utf-8?B?RzJGWWJsNzhiM0Y4YmlqTGlsTmhQWWtNUVFUY3hPN3hHV0xqWTR5Lzdydk9l?=
 =?utf-8?B?RW91ZWczZE05T3VOTkRIVmZKMHI4ZkhJZmQ4aU9NbWJGaWpRenhkZVA5d2Nj?=
 =?utf-8?B?QjJDVHJBVXp4NGNSN080WE82WUdVL2NzU2xobTc5OGdqMEFzS1N1bVZkVzJ5?=
 =?utf-8?B?WmRoSFl1NUE1enltTVBCaWo3V0dCRk10Y2g5VUkyUHd4N2xhZVcxUUMvN2pS?=
 =?utf-8?B?SUcyVW1sblE3WkNnR0N1cE4xeGJtR2ppRWcwQXlFZXhnWGJwNUgwUTJKQmJt?=
 =?utf-8?B?c3EzdXQvMCtUZjBMSUY5WC9LT3V0YjFxSk4xdWY4RUc4QmxkbFZvRnV0NHRl?=
 =?utf-8?B?NXl1UWdYdGFnQmgvb1pFcG9abmlTd1UrRG5BWDQ3ZktCOVNkRlQ2akxMK3RK?=
 =?utf-8?B?VUIwVEdOQTVKYjIzVGlVMnRqVjdEdnNHT0F2UHIveEF1VVVkT2RZT201VFpT?=
 =?utf-8?B?L3dsd0g4WVY3MjlKM2xGajJLeUl3VEFoNUhoRmh6N2tCU2J0UTBPM1dqTzla?=
 =?utf-8?B?V1R1MDNwbnliRG1nMi9WREZmZUFiR0FxT1NiOEZCV1BMQ29xUmhtNzF0WXha?=
 =?utf-8?B?dm1ETUxkZDB2TGRKb29sVk9xbWljbjlabDUybjQ0R1FZd3k1V2hPVzZiS08w?=
 =?utf-8?B?b0R0ZGRBZHRnUXR5Vy9WNG92SlJWcmIxWkxZSEhvV0EvUkJFL3NlYkx5OUQx?=
 =?utf-8?B?b0FmTXYxdWc3amRFcTRiUVpYZ2ZDbFJ1V0dYaEV0L054bDZRbU1EaHJQOTli?=
 =?utf-8?B?ZzFOTlhhUnQrNXJhRk5HRjRUN0EwTDE3aFUvZWJBTkJRWElnakwybUJmUTJE?=
 =?utf-8?B?NWRqdHcyNmcvaVpvcXdXVWN2dkMzOFM3aGd5R0NLb3Z5NHowY3ZuV3BFVHVQ?=
 =?utf-8?B?dWp2TkQ4VDBiYnZ2Q3Z3bklQQlNEdDRLVnZBd2ZGck9Jc0h2dXltQVRPcTY1?=
 =?utf-8?B?S1FTVDJHWWdlNTJheER1U3A2aktTOEk1SXRSVUJVUW9DL24reENSOXgrZjg3?=
 =?utf-8?B?QXlkVk5YZmpCRGFhTkNzUHJZWU5yeGlOWUlNck1VM05jMmo2cFFHWFA1akRO?=
 =?utf-8?Q?2gl6/Ss5qtGaoG8n5ro9+4ZsW?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1bb0ef80-d3f9-4e4d-dd95-08dae218e4b3
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2022 23:29:37.1213
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WNQAEB89c5GfpUb5jw+ScRXigxu+QGCTa4bNzevvnaSf6WH5gLE2IAX0PRbekUkFejP7HS0sOHAI+eckg7Nwjg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7553
X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/19/2022 00:40, Perry Yuan wrote:
> AMD Pstate driver support another firmware based autonomous mode
> with "amd_pstate=active" added to the kernel command line.
> In autonomous mode SMU firmware decides frequencies at 1 ms timescale

This might be the case right now, but I don't know that it will always
be this timescale.  Suggest to drop drop "at 1ms timescale".

> based on workload utilization, usage in other IPs, infrastructure
> limits such as power, thermals and so on.
> 
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>

With nit fixed:

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

> ---
>   Documentation/admin-guide/kernel-parameters.txt | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 42af9ca0127e..73a02816f6f8 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -6970,3 +6970,10 @@
>   			  management firmware translates the requests into actual
>   			  hardware states (core frequency, data fabric and memory
>   			  clocks etc.)
> +			active
> +			  Use amd_pstate_epp driver instance as the scaling driver,
> +			  driver provides a hint to the hardware if software wants
> +			  to bias toward performance (0x0) or energy efficiency (0xff)
> +			  to the CPPC firmware. then CPPC power algorithm will
> +			  calculate the runtime workload and adjust the realtime cores
> +			  frequency.