Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <420e1f4d-90c1-1887-7d5d-7d2c4b38d2e0@amd.com>
Date:   Mon, 19 Dec 2022 17:28:11 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH v8 10/13] Documentation: amd-pstate: add amd pstate driver
 mode introduction
Content-Language: en-US
To:     Perry Yuan <perry.yuan@amd.com>, rafael.j.wysocki@intel.com,
        ray.huang@amd.com, viresh.kumar@linaro.org
Cc:     Deepak.Sharma@amd.com, Nathan.Fontenot@amd.com,
        Alexander.Deucher@amd.com, Shimmer.Huang@amd.com,
        Xiaojian.Du@amd.com, Li.Meng@amd.com, wyes.karny@amd.com,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20221219064042.661122-1-perry.yuan@amd.com>
 <20221219064042.661122-11-perry.yuan@amd.com>
From:   "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <20221219064042.661122-11-perry.yuan@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UVI4UFJPZkM2VWZYNlhqbU5UME9FTTgrRWZXeVJzMFpCMFNsWkNTa1FrMmNM?=
 =?utf-8?B?NktQZ3lMQXMxVXlrMXJyYXBZVk82VWRNdUdibDYrTmNmTUpjV3ZSOXkvRGNM?=
 =?utf-8?B?OW03QlFlNFJFbUhNMC9kM3gzZHZocTBDdkgwY0RZeVloaHY1Q1JFWVBYeUpm?=
 =?utf-8?B?cW8wODBmVHRZUzVMd0Z0cTJwY09EbEtKTHBjbUIxMDZocE5zNTdLOFExODhP?=
 =?utf-8?B?RmE4VWkxL1JvU2xaZTkweWRBczVYbUVMNDUremZhb2toZGp0YUcwSzhSSzdF?=
 =?utf-8?B?RERNZk1mSWRQWTFVT1BENisvbGd4UjRhWHcvcVJQOTg4L0tYdFdzZVo5dFlh?=
 =?utf-8?B?aUs4dlAyRnIxR2MvV3pjWHBJamNNVVQ3Y3U2cEpkRmxMSS9KZDhxQ1NqamJQ?=
 =?utf-8?B?Tnh3QnAvb3IzMzkrVnhFRUVzNlA0VDVwallTckxQOXJpM25pby9nNUk3dXoz?=
 =?utf-8?B?cnFseE8rSGtwOVhTT0JPcURNV3c1SldKQTRTZmlWSElWM0tYM3dRVlFDVWdl?=
 =?utf-8?B?bHpqa2hsMmFCTStBRmw0VGphM0NrSGdtNHNzYUM0d0JVNE5WMlNuQ0V6Vm5i?=
 =?utf-8?B?bm5JZEU0ZWUvVUZ4RmFyZFhxNnpWU1RYbTBJUGdlcTNtK3hmeDVWSjF3Zndl?=
 =?utf-8?B?QlNRZlFmbWpLL2QxWEM0aGZHbnFCY3hRb2wzcHJjUFpRenNxMXB1eDNXK09W?=
 =?utf-8?B?YXRubkpvMTJscDM5UUdReFNxZG9RTjlndzF3cXI3V0hzQVhRWkl0RlZBN3Fj?=
 =?utf-8?B?Vm42VjhraFZVMGlHQ1VCODZ1cEUwN0ZyQ0dKVEtqK1FqTXd4ZS9BYlZTY2Fi?=
 =?utf-8?B?Z0hmdE91T2k4K2VYc2RtSjdQcDV1QzFZY3o0RVNOd3F1YXZ2MEJPSVRQUFkr?=
 =?utf-8?B?MksxMXlqYS9YdXg1Q29ZdUpYTmV4MHhna0lyRm1qVHR2NmROdk9JYW5la1gy?=
 =?utf-8?B?ZUIwUjY1V1liY3pIbjErZWcwM3hBbTRlVXR2aHRqOHB0Y0JrUEx6eXFKenN6?=
 =?utf-8?B?eUE2OEwrOEQrZFpKeWdDRTI5aWVTMHdyd2NpS0lzT0ErcUR6a2NnRldWc0Nk?=
 =?utf-8?B?RXNQYUI2a2I0MzhqRWV4aHJpdmVvdWRpWldKNzE3TEI2NllJdGdBYXBVemlq?=
 =?utf-8?B?Z3dDU09zYjR1c20yclNYYlpOTDJXSTEwcGNNdTRnZ0Y4VjFDbmVCRklUQXow?=
 =?utf-8?B?YzdYaWdmczRLaFVqdUR4R1VHeDE1bjBIVGRVTS9KRDRDTUUxdjdFdFU0Yk04?=
 =?utf-8?B?T1J4MWM3dTRMS3Q0NXpBKzdLWnRNMVNwdWQxV0dlMml3ZWZ3UG0zL2d6aGx5?=
 =?utf-8?B?dWEwWi96Yis0eUdhQm1halJjcFhkWW5rQkp4bEQ2Q2h1dFgyd2dBakNyUStz?=
 =?utf-8?B?NGoybXU3Znd1dGdIbXJrejlRR0ZWREVlZUZtcGF6SmMzZkI5TWdNRkVpWjZn?=
 =?utf-8?B?UFA2Wk9kVEloMXpRK3RxVGV5S3J2QUhVOXF2YjRTVnBibUlhTXV2dWk0VEU0?=
 =?utf-8?B?QUs1ZXNzbW8vTHV1Vi85KzV0eWg3MDE4VXlFbVFqQkpjU2VFNjJ3RnZ5TDE4?=
 =?utf-8?B?V2ErdEV1eG5rS2QvUVlsRnlZUUQxVkowVmFzT1NhZFBWaW9yY2dScFptTU5Z?=
 =?utf-8?B?Q3JQdldHOFBYQk5BNzFTUmk2VnRmbXRHN2VaVGZHVWlJUWdjMitGSW96U1Qz?=
 =?utf-8?B?Rm5zQlJycHNMVmd2Rkxma3B2c3lPUzdaM1Q3cHVlejlnQXRwWVZqbHBqTStX?=
 =?utf-8?B?MXpleDhSdW0rYVM3QUl3QytCMHIvdjkrYm9KVXluUlZxcDZIK0ZPNGx3VURx?=
 =?utf-8?B?YU1yMDJKRENQeG9mVUNWbllESWc1aU9GcElzRzJDTTFlNWhockdLV011d2FF?=
 =?utf-8?B?K3l1ak1OVFBDSDZqTnd1c3Y2aWZURUp4SnlPK3ZMSys0K0tSMWNnMmk1ZitD?=
 =?utf-8?B?aFkxakZBSk5RaGR4RHFyMUgwVEZpR2Z5c0ErTk84NkJPT2M4dkhxUEtTS3Ru?=
 =?utf-8?B?L2pzTHgzYjBEaWxFUWRqUDlUY1FpWTV0dUZvZHcrTWV6YkU3by9wME55Q1k1?=
 =?utf-8?B?ZEhqRjE1N1MrZEROQTZMRXh4UTF1WFBGaHA1Z01QMXlLN0FFbWh0NFlTSXlI?=
 =?utf-8?Q?puHQPE2B7wwHRMg9vwvkwiKMr?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fb172929-773f-420a-f88e-08dae218b315
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2022 23:28:14.0343
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: liRhk2BzXQNJfh8LLXo6zirTvTIBP70zeWfWrYhTuRnkr009cCsKhWz2fzbxor1vQHDnnS2QdOVaE7YIWf7ofg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7553
X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/19/2022 00:40, Perry Yuan wrote:
> From: Perry Yuan <Perry.Yuan@amd.com>
> 
> Introduce ``amd-pstate`` CPPC has two operation modes:

Drop the word Introduce.

> * CPPC Autonomous (active) mode
> * CPPC non-autonomous (passive) mode.
> active mode and passive mode can be chosen by different kernel parameters.
> 
> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>

With nit fixed:

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

> ---
>   Documentation/admin-guide/pm/amd-pstate.rst | 26 +++++++++++++++++++--
>   1 file changed, 24 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/admin-guide/pm/amd-pstate.rst b/Documentation/admin-guide/pm/amd-pstate.rst
> index 33ab8ec8fc2f..62744dae3c5f 100644
> --- a/Documentation/admin-guide/pm/amd-pstate.rst
> +++ b/Documentation/admin-guide/pm/amd-pstate.rst
> @@ -299,8 +299,30 @@ module which supports the new AMD P-States mechanism on most of the future AMD
>   platforms. The AMD P-States mechanism is the more performance and energy
>   efficiency frequency management method on AMD processors.
>   
> -Kernel Module Options for ``amd-pstate``
> -=========================================
> +
> +AMD Pstate Driver Operation Modes
> +=================================
> +
> +``amd_pstate`` CPPC has two operation modes: CPPC Autonomous(active) mode and
> +CPPC non-autonomous(passive) mode.
> +active mode and passive mode can be chosen by different kernel parameters.
> +When in Autonomous mode, CPPC ignores requests done in the Desired Performance
> +Target register and takes into account only the values set to the Minimum requested
> +performance, Maximum requested performance, and Energy Performance Preference
> +registers. When Autonomous is disabled, it only considers the Desired Performance Target.
> +
> +Active Mode
> +------------
> +
> +``amd_pstate=active``
> +
> +This is the low-level firmware control mode which is implemented by ``amd_pstate_epp``
> +driver with ``amd_pstate=active`` passed to the kernel in the command line.
> +In this mode, ``amd_pstate_epp`` driver provides a hint to the hardware if software
> +wants to bias toward performance (0x0) or energy efficiency (0xff) to the CPPC firmware.
> +then CPPC power algorithm will calculate the runtime workload and adjust the realtime
> +cores frequency according to the power supply and thermal, core voltage and some other
> +hardware conditions.
>   
>   Passive Mode
>   ------------