Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ed4ea9ae-78bf-b323-9380-47b1fd58c72b@huawei.com>
Date:   Tue, 20 Dec 2022 09:40:05 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH] tracing: Add a way to filter function addresses to
 function names
Content-Language: en-US
To:     Steven Rostedt <rostedt@goodmis.org>
CC:     LKML <linux-kernel@vger.kernel.org>,
        Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Ross Zwisler <zwisler@google.com>,
        Tom Zanussi <zanussi@kernel.org>
References: <20221214125209.09d736dd@gandalf.local.home>
 <68fa6a9d-7a7f-00ba-e5a2-9b64f0aa7db3@huawei.com>
 <20221219132102.0dc6b7b9@gandalf.local.home>
From:   Zheng Yejian <zhengyejian1@huawei.com>
In-Reply-To: <20221219132102.0dc6b7b9@gandalf.local.home>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2022/12/20 02:21, Steven Rostedt wrote:
> On Mon, 19 Dec 2022 10:38:50 +0800
> Zheng Yejian <zhengyejian1@huawei.com> wrote:
> 
>>> diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
>>> index 33e0b4f8ebe6..db6e2f399440 100644
>>> --- a/kernel/trace/trace_events.c
>>> +++ b/kernel/trace/trace_events.c
>>> @@ -2822,7 +2822,7 @@ static __init int setup_trace_triggers(char *str)
>>>    		if (!trigger)
>>>    			break;
>>>    		bootup_triggers[i].event = strsep(&trigger, ".");
>>> -		bootup_triggers[i].trigger = strsep(&trigger, ".");
>>> +		bootup_triggers[i].trigger = strsep(&trigger, "");
>>
>> Would it be better to change to:
>>
>>        bootup_triggers[i].trigger = trigger;
>>
> 
> Sure, I'll make the update.
> 
>> Because there is unnecessary loop if call strsep(s, "") :-)
>>     strsep(s, ct) {
>>       strpbrk(cs, ct) {
>>         // when 'ct' is empty string, here will always return NULL
>>         // after traversing string 'cs'
> 
> I'm not sure what you mean about an extra loop.

I just mean above "traversing string 'cs'" in strpbrk(s, "") is 
unnecessary. Sorry for making the ambiguity :-(

> 
> Thanks,
> 
> -- Steve
>