Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp3567512rwj; Mon, 19 Dec 2022 21:40:52 -0800 (PST) X-Google-Smtp-Source: AA0mqf6jXeyB+6EfF1CTsQXsVx0U4BvUV47KE/ksEzqhJ6W5BGfuhZUWpA5SBwu1EsJfXEA3NXhD X-Received: by 2002:a17:90a:d78b:b0:219:20b8:a6fe with SMTP id z11-20020a17090ad78b00b0021920b8a6femr45539913pju.46.1671514852592; Mon, 19 Dec 2022 21:40:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671514852; cv=none; d=google.com; s=arc-20160816; b=lwNkAJCjgQLqstHrDlbKcNeY5De3ievEWJisU0sUOU8X4+G9p4A+6dohgdi0C+iXhU vBBBj+nzepbCqxg13H3qUWQW14WK1f5c9YiRst2VjdT/7gxhIHaoNj2J7SnwPswW4/fl oqBLCjfJi2smpP7r7Y7jjIJ6/nhm+a4gSNimQgDcclme+6SJ1sgKhlrF6DbiL/KgE5qU 41HWK5y/EgHJopCRLLJvdSn44+S58nPQO3MGHLyhw8OnV2DS4BsjpBoUgK9IDsiBz/AA zbRXanuESpccyqVWlEV3M28LlLN5KFernn0tUFkwvdESf9+1v0m1Go9mMGltXrlfaXBX yVFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version; bh=L9NRxmq9Ol6UgGscvab2tRr3azN13Jn/Nlca5MuVBDE=; b=vCYB9idk5lygiNU2y71rzBVTqrH1VubTwpAZSETYCs6WrnTgpMefuOI+HiiMY0BibX VwwoP+n0EqlGR8JcjieQU+NlYcFdmo3sGPh2/gkVCBJAOGgiYDoHn0/1U5qlniWBewN3 6qkuroczzaZq514S2vci+eY1z6efPzRvP4PG1dYKcwQ33c8uZnHbJrbthMt7Nhbqr4nk w1A8nJbvait7eLqdDJGb2SXd3TPKpMxoAkBmBmeAxrp0Plojf3/UC686pESmo2AFclVM Kpo+NoSfnjpWdmPF9pNMoYZ5COVyVclbk53Z7o/PToXpK0sEozlqEFUVGi4WC1uN9pZv ZSTg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hi9-20020a17090b30c900b001fab0d18bcasi12375521pjb.66.2022.12.19.21.40.43; Mon, 19 Dec 2022 21:40:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232918AbiLTF1d convert rfc822-to-8bit (ORCPT + 70 others); Tue, 20 Dec 2022 00:27:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229454AbiLTF1a (ORCPT ); Tue, 20 Dec 2022 00:27:30 -0500 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8084FB9; Mon, 19 Dec 2022 21:27:29 -0800 (PST) Received: by mail-pf1-f176.google.com with SMTP id 124so7818735pfy.0; Mon, 19 Dec 2022 21:27:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9fgdIcNnHtv/UvgykaD5KYGncbrMyeY4TxNRMdBaCn4=; b=LUEOG8MgTans4f30L2NcYeXm80k6UeeTVN6/YSumqyr1lAx4ghQXLfotJwxEWB5Bl3 Vvm2XlPQvFTk1A38TQu35mWDN8sxQiSHhHfYvP2BX1UmaJfU6DZivotRFo5jqfarDYb6 qPe4p3SKFWw/TPcnIBVxAPhdXAQbTWkvHSZwJeNqy5cA0UMIDGaUH+oJJ0ZFzrmlkPdD 0ftArsZ/4ErMsSkYs4XOg7+KOf2XCK1VdV30Q/mWZH5E295/ryJ2tWvPY1O4Sj2Y7wDc blcqOXHxbxBXzAQvDPkuvB0HOOKZaCN3AszxSnVoJLilK3TAwmKOP8IR31IyPxLb+SFM z35w== X-Gm-Message-State: AFqh2koqscvnC/i2VNTOXrYsEd4e1Fta5G8qdGtHTjSyMFL8FzZloYGG EgXRD2EzJht8qxkuTSWMV+lq7OtddnLtcvEee0s= X-Received: by 2002:a63:584c:0:b0:484:2672:2c6a with SMTP id i12-20020a63584c000000b0048426722c6amr854698pgm.535.1671514048877; Mon, 19 Dec 2022 21:27:28 -0800 (PST) MIME-Version: 1.0 References: <20221219212717.1298282-1-frank.jungclaus@esd.eu> <20221219212717.1298282-2-frank.jungclaus@esd.eu> In-Reply-To: <20221219212717.1298282-2-frank.jungclaus@esd.eu> From: Vincent MAILHOL Date: Tue, 20 Dec 2022 14:27:17 +0900 Message-ID: Subject: Re: [PATCH 3/3] can: esd_usb: Improved decoding for ESD_EV_CAN_ERROR_EXT messages To: Frank Jungclaus Cc: linux-can@vger.kernel.org, Marc Kleine-Budde , Wolfgang Grandegger , =?UTF-8?Q?Stefan_M=C3=A4tje?= , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le mar. 20 déc. 2022 à 06:28, Frank Jungclaus a écrit : > > As suggested by Marc there now is a union plus a struct ev_can_err_ext > for easier decoding of an ESD_EV_CAN_ERROR_EXT event message (which > simply is a rx_msg with some dedicated data). > > Suggested-by: Marc Kleine-Budde > Link: https://lore.kernel.org/linux-can/20220621071152.ggyhrr5sbzvwpkpx@pengutronix.de/ > Signed-off-by: Frank Jungclaus > --- > drivers/net/can/usb/esd_usb.c | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/can/usb/esd_usb.c b/drivers/net/can/usb/esd_usb.c > index 09745751f168..f90bb2c0ba15 100644 > --- a/drivers/net/can/usb/esd_usb.c > +++ b/drivers/net/can/usb/esd_usb.c > @@ -127,7 +127,15 @@ struct rx_msg { > u8 dlc; > __le32 ts; > __le32 id; /* upper 3 bits contain flags */ > - u8 data[8]; > + union { > + u8 data[8]; > + struct { > + u8 status; /* CAN Controller Status */ > + u8 ecc; /* Error Capture Register */ > + u8 rec; /* RX Error Counter */ > + u8 tec; /* TX Error Counter */ > + } ev_can_err_ext; /* For ESD_EV_CAN_ERROR_EXT */ > + }; > }; > > struct tx_msg { > @@ -229,10 +237,10 @@ static void esd_usb_rx_event(struct esd_usb_net_priv *priv, > u32 id = le32_to_cpu(msg->msg.rx.id) & ESD_IDMASK; > > if (id == ESD_EV_CAN_ERROR_EXT) { > - u8 state = msg->msg.rx.data[0]; > - u8 ecc = msg->msg.rx.data[1]; > - u8 rxerr = msg->msg.rx.data[2]; > - u8 txerr = msg->msg.rx.data[3]; > + u8 state = msg->msg.rx.ev_can_err_ext.status; > + u8 ecc = msg->msg.rx.ev_can_err_ext.ecc; > + u8 rxerr = msg->msg.rx.ev_can_err_ext.rec; > + u8 txerr = msg->msg.rx.ev_can_err_ext.tec; I do not like how you have to write msg->msg.rx.something. I think it would be better to make the union within struct esd_usb_msg anonymous: https://elixir.bootlin.com/linux/latest/source/drivers/net/can/usb/esd_usb.c#L169 That said, this is not a criticism of this patch but more something to be addressed in a separate clean-up patch. > netdev_dbg(priv->netdev, > "CAN_ERR_EV_EXT: dlc=%#02x state=%02x ecc=%02x rec=%02x tec=%02x\n", > -- > 2.25.1 >