Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Ashwin Dayanand Kamat <kashwindayan@vmware.com>
To:     Vlad Yasevich <vyasevich@gmail.com>,
        Neil Horman <nhorman@tuxdriver.com>,
        Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, linux-sctp@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Ashwin Dayanand Kamat <kashwindayan@vmware.com>,
        srivatsab@vmware.com, srivatsa@csail.mit.edu, amakhalov@vmware.com,
        vsirnapalli@vmware.com, akaher@vmware.com
Subject: [PATCH] sctp: Make sha1 as default algorithm if fips is enabled
Date:   Tue, 20 Dec 2022 10:40:37 +0530
Message-Id: <1671513037-8958-1-git-send-email-kashwindayan@vmware.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Y36s/Rk1A0g76gv7BxYAOb5ml0PBFQiiwXjYkDtF6y/D3cufg6mbAGKRUhqj?=
 =?us-ascii?Q?FffIrI/7zQmQZWXftcuJwRkZrPNwfkwyraKXBFqs5LdKUDonCzGIVUBwo7I/?=
 =?us-ascii?Q?78z53SoECDLzL1lowK1V3C+fDpuT6qYy4fc6IGjivTjySU6dJ2bJzbYZNd/w?=
 =?us-ascii?Q?NO+ZEVQrAhq8Gf0D5FoFA7M7KUyhCQc+CKG0Oqb6nf/lIxZI/pvzWhwVy/q8?=
 =?us-ascii?Q?nd7yp4yJEDP7s63siwD1mjBBwQYX4WZkuudDhcDx1bemaNEz5X9KBo4PZTdg?=
 =?us-ascii?Q?qiuQAxLXjdlbxHjSPqztVEzm4s5L6zgrVFQLY6bMxdMyqcCg66kqff9Wf3UV?=
 =?us-ascii?Q?Ua0Go9PUrAVY64FVYVfGajRRQ3Ek8Ej1jRAktLW8cpA0xskoKrRvTsRNeTwe?=
 =?us-ascii?Q?ASAc++azjuGi6IJKa7+PVtQqBsuNT4jbuZn5qLS6a2KY1lNw63M4QYz3zdOr?=
 =?us-ascii?Q?ZMMHDiN/awM/6vSSgnfnGHZtgtjAO9e5riJ0ap+zisGK2lxRljwJzTF10MXm?=
 =?us-ascii?Q?+27YtQLozIBUan1hnDEWgRaz/+3/GI1dlDWKM3hV5Oq//0JkfMHeEt8M1jqG?=
 =?us-ascii?Q?n1FM95zXdl6LmSdub+BhpJp3vvMZFCjQku/nDRsQNxejAEB9h8R5nE8eCtQu?=
 =?us-ascii?Q?Tt+q7GVM5fPngZCOO0TUZuZuPy+ct1WZdvIqrf3e13n+InzARbwmSy/Kcu9n?=
 =?us-ascii?Q?FgpBb8HBdmFI1Q3TuyhNeAkeZCjQMW6bCkqzHSAWNidzHUr51HrH5tRwIflF?=
 =?us-ascii?Q?Ziji6MyGIkQX+4tBMJAnlTOhD1R7izX/AWWQCSLbqy+1TfqABN2FRcFIMfAb?=
 =?us-ascii?Q?t64UEu/xthyF6KOeRpfwjr5JIRE+JY19a14nNi+prIedBAw78e8R9LFUNslH?=
 =?us-ascii?Q?bywwFXm5DKngsdyatIS/FC4IahmsNAAMn9Rv7HFWya4gP0ReYmio+VmyTMOK?=
 =?us-ascii?Q?2Fwl/1Y8KCiz2CaRXHS6N/Vs5omndiNmQ1grokyD46sKIWf+i18fenLih9TU?=
 =?us-ascii?Q?9Ewd/FJs0a6nUcRBUMgKfQmewM4Zm7JiM7lcz2St0fN5hkZJaFiJhkdvMQSL?=
 =?us-ascii?Q?R699z84iU/tEMreXxUOTlVYFJM2lvxMMxBhZSm3onqD2Er2t4ezYiIi4WAB9?=
 =?us-ascii?Q?XmaTg3mMXJoG8bitZxmexqjJMsyTj+Ft5JxVE8TwM2C7M2wrPR5Yei2lFYGi?=
 =?us-ascii?Q?7Jjww3RlyerK2EIGnR+E0Bz2uIJ/77bwpThyG/rem7R5GSrLkthirDBzoquG?=
 =?us-ascii?Q?e7bcCmrLwpQWpUerPZ74p0t3ZHAtDOOSs+PRhcAJODntN2HpkDmjhXtYsBso?=
 =?us-ascii?Q?D3CVqEwaz2rEC1pcrJgE/URfX9cEtNszWQD8BROBZrBFgogsD57l+Cu1PC1f?=
 =?us-ascii?Q?tLzNsQGzkVkiknjM/Yy7y7e4ElBnWzZ1rv3YAGex1o0OUOUBkvX/zSN9P1a1?=
 =?us-ascii?Q?zX8NkLXdwZZh2ju/ZbwFNW1Yu6X2Wu96mx4G7ct1xp8VoCODNlwx14Hmrmzb?=
 =?us-ascii?Q?rTeGSTsJS8rMzSKRROz1kziJLdDnwtYGAZWkfUtTgMwBvbnTDYeDnDRggh+Z?=
 =?us-ascii?Q?sbDjJcAX9N4qf2mNzy02m5WN24gCVtZDY46yJ1GD?=
X-OriginatorOrg: vmware.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d2eebb17-0b54-4c92-bbc2-08dae24896f4
X-MS-Exchange-CrossTenant-AuthSource: BL0PR05MB5409.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2022 05:11:02.5896
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: giHW+muOgBRkZnV+ptTqa6P5Mmb8NX76UBFrG5/swq7SIjSH/WJ/4a8JVtZCB+8DntJxjUL9g74hUv3aPv65BA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR05MB5552
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_NONE autolearn=no
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

MD5 is not FIPS compliant. But still md5 was used as the default algorithm
for sctp if fips was enabled.
Due to this, listen() system call in ltp tests was failing for sctp
in fips environment, with below error message.

[ 6397.892677] sctp: failed to load transform for md5: -2

Fix is to not assign md5 as default algorithm for sctp
if fips_enabled is true. Instead make sha1 as default algorithm.

Signed-off-by: Ashwin Dayanand Kamat <kashwindayan@vmware.com>
---
 net/sctp/protocol.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c
index 909a89a..b6e9810 100644
--- a/net/sctp/protocol.c
+++ b/net/sctp/protocol.c
@@ -34,6 +34,7 @@
 #include <linux/memblock.h>
 #include <linux/highmem.h>
 #include <linux/slab.h>
+#include <linux/fips.h>
 #include <net/net_namespace.h>
 #include <net/protocol.h>
 #include <net/ip.h>
@@ -1321,14 +1322,13 @@ static int __net_init sctp_defaults_init(struct net *net)
 	/* Whether Cookie Preservative is enabled(1) or not(0) */
 	net->sctp.cookie_preserve_enable 	= 1;
 
-	/* Default sctp sockets to use md5 as their hmac alg */
-#if defined (CONFIG_SCTP_DEFAULT_COOKIE_HMAC_MD5)
-	net->sctp.sctp_hmac_alg			= "md5";
-#elif defined (CONFIG_SCTP_DEFAULT_COOKIE_HMAC_SHA1)
-	net->sctp.sctp_hmac_alg			= "sha1";
-#else
-	net->sctp.sctp_hmac_alg			= NULL;
-#endif
+	/* Default sctp sockets to use md5 as default only if fips is not enabled */
+	if (!fips_enabled && IS_ENABLED(CONFIG_SCTP_DEFAULT_COOKIE_HMAC_MD5))
+		net->sctp.sctp_hmac_alg = "md5";
+	else if (IS_ENABLED(CONFIG_SCTP_DEFAULT_COOKIE_HMAC_SHA1))
+		net->sctp.sctp_hmac_alg = "sha1";
+	else
+		net->sctp.sctp_hmac_alg = NULL;
 
 	/* Max.Burst		    - 4 */
 	net->sctp.max_burst			= SCTP_DEFAULT_MAX_BURST;
-- 
2.7.4