Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4a378429-9a23-13a2-5837-512823e182c3@linaro.org>
Date:   Tue, 20 Dec 2022 07:51:38 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH] mtd: cfi: allow building spi-intel standalone
Content-Language: en-US
To:     Tokunori Ikegami <ikegami.t@gmail.com>,
        Arnd Bergmann <arnd@kernel.org>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>
Cc:     Arnd Bergmann <arnd@arndb.de>, Lee Jones <lee.jones@linaro.org>,
        Mauro Lima <mauro.lima@eclypsium.com>,
        Tudor Ambarus <tudor.ambarus@microchip.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Boris Brezillon <boris.brezillon@collabora.com>,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20221215163950.649791-1-arnd@kernel.org>
 <d68c9137-f485-e0a0-dfc3-c72c26d0433a@gmail.com>
From:   Tudor Ambarus <tudor.ambarus@linaro.org>
In-Reply-To: <d68c9137-f485-e0a0-dfc3-c72c26d0433a@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 19.12.2022 17:12, Tokunori Ikegami wrote:
> 
> On 2022/12/16 1:39, Arnd Bergmann wrote:
>> From: Arnd Bergmann<arnd@arndb.de>
>>
>> When MTD or MTD_CFI_GEOMETRY is disabled, the spi-intel driver
>> fails to build, as it includes the shared CFI header:
> The header file linux/mtd/cfi.h is included by the head file 
> linux/mtd/spi-nor.h so seems the warning caused.
> Is it really necessary to inculude linux/mtd/cfi.h from 
> linux/mtd/spi-nor.h?
> (It seems that it can be resolved the issue by removing the including 
> cfi.h from spi-nor.h if unnecessary.)

SPI NOR does not depend on CFI. cfi.h shouldn't be included by
spi-nor.h, indeed.

Cheers,
ta