Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kuniyuki Iwashima <kuniyu@amazon.com>
To:     <jirislaby@kernel.org>
CC:     <davem@davemloft.net>, <edumazet@google.com>,
        <joannelkoong@gmail.com>, <kuba@kernel.org>, <kuniyu@amazon.com>,
        <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
        <pabeni@redhat.com>
Subject: Re: [PULL] Networking for next-6.1
Date:   Tue, 20 Dec 2022 15:28:44 +0900
Message-ID: <20221220062844.26368-1-kuniyu@amazon.com>
In-Reply-To: <5bb57ae6-c2a7-e6ea-3fe8-62b8b61bc7c5@kernel.org>
References: <5bb57ae6-c2a7-e6ea-3fe8-62b8b61bc7c5@kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk

From:   Jiri Slaby <jirislaby@kernel.org>
Date:   Tue, 20 Dec 2022 07:22:56 +0100
> On 19. 12. 22, 0:25, Kuniyuki Iwashima wrote:
> > From:   Jiri Slaby <jirislaby@kernel.org>
> > Date:   Fri, 16 Dec 2022 11:49:01 +0100
> >> Hi,
> >>
> >> On 04. 10. 22, 7:20, Jakub Kicinski wrote:
> >>> Joanne Koong (7):
> >>
> >>>         net: Add a bhash2 table hashed by port and address
> >>
> >> This makes regression tests of python-ephemeral-port-reserve to fail.
> >>
> >> I'm not sure if the issue is in the commit or in the test.
> > 
> > Hi Jiri,
> > 
> > Thanks for reporting the issue.
> > 
> > It seems we forgot to add TIME_WAIT sockets into bhash2 in
> > inet_twsk_hashdance(), therefore inet_bhash2_conflict() misses
> > TIME_WAIT sockets when validating bind() requests if the address
> > is not a wildcard one.
> > 
> > I'll fix it.
> 
> Hi,
> 
> is there a fix for this available somewhere yet?

Not yet, but I'll CC you when posting a patch.

Thank you.